[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2019-09-11 Thread Mikhail Khludnev (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16927490#comment-16927490 ] Mikhail Khludnev commented on LUCENE-5189: -- Giving that LUCENE-8585, LUCENE-837

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2017-04-03 Thread Erick Erickson (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15954610#comment-15954610 ] Erick Erickson commented on LUCENE-5189: Yep, total inadvertent reassignment, sen

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2017-04-03 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15954500#comment-15954500 ] David Smiley commented on LUCENE-5189: -- [~erickerickson] was this a case of accident

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2014-04-02 Thread Mikhail Khludnev (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13958205#comment-13958205 ] Mikhail Khludnev commented on LUCENE-5189: -- One more note for adopters. if you s

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2014-03-15 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13936279#comment-13936279 ] Shai Erera commented on LUCENE-5189: I checked the code and it looks the same with e.

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2014-03-15 Thread Mikhail Khludnev (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13936265#comment-13936265 ] Mikhail Khludnev commented on LUCENE-5189: -- Just want to leave one caveat for me

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-11-20 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13828524#comment-13828524 ] Shai Erera commented on LUCENE-5189: You're right Simon. The updates are buffered in

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-11-20 Thread Simon Willnauer (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13828149#comment-13828149 ] Simon Willnauer commented on LUCENE-5189: - [~mkhludnev] the updates are buffered

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-11-20 Thread Mikhail Khludnev (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13828140#comment-13828140 ] Mikhail Khludnev commented on LUCENE-5189: -- [~shaie] let me ask a trivial questi

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-11-02 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13812124#comment-13812124 ] ASF subversion and git services commented on LUCENE-5189: - Commit

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-11-01 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13811890#comment-13811890 ] ASF subversion and git services commented on LUCENE-5189: - Commit

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-11-01 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13811872#comment-13811872 ] ASF subversion and git services commented on LUCENE-5189: - Commit

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-10-31 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13811070#comment-13811070 ] Shai Erera commented on LUCENE-5189: Backported to 4x. I'll handle the "TODO (DVU_REN

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-10-31 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13811069#comment-13811069 ] ASF subversion and git services commented on LUCENE-5189: - Commit

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-10-31 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13811057#comment-13811057 ] ASF subversion and git services commented on LUCENE-5189: - Commit

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-10-25 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13805658#comment-13805658 ] Michael McCandless commented on LUCENE-5189: +1 to backport. > Numeric DocVa

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-10-24 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13804640#comment-13804640 ] ASF subversion and git services commented on LUCENE-5189: - Commit

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-10-24 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13804246#comment-13804246 ] Shai Erera commented on LUCENE-5189: I think it's ready to backport to 4x. > Numeric

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-10-12 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13793580#comment-13793580 ] ASF subversion and git services commented on LUCENE-5189: - Commit

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-10-12 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13793579#comment-13793579 ] Shai Erera commented on LUCENE-5189: Thanks for the comments Mike, I fixed the code.

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-10-12 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13793521#comment-13793521 ] Michael McCandless commented on LUCENE-5189: The test case changes look good!

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-10-11 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13793242#comment-13793242 ] ASF subversion and git services commented on LUCENE-5189: - Commit

Re: [jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-10-07 Thread shikhar
yho On Sunday, October 6, 2013, Shai Erera (JIRA) wrote:u > > [ > https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13787730#comment-13787730] > > Shai Erera commented on LUCENE-5189: > -

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-10-06 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13787730#comment-13787730 ] Shai Erera commented on LUCENE-5189: bq. If SR itself doesnt need ref-counting, perha

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-10-06 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13787691#comment-13787691 ] Robert Muir commented on LUCENE-5189: - Thanks shai... I think for me, this is the mai

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-10-06 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13787688#comment-13787688 ] Shai Erera commented on LUCENE-5189: bq. because there isn't a single DVP that all SR

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-10-06 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13787683#comment-13787683 ] Shai Erera commented on LUCENE-5189: Let me explain: SCR is still used for all the sh

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-10-06 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13787650#comment-13787650 ] Uwe Schindler commented on LUCENE-5189: --- Hi, to me the whole code in SegmentReader

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-10-06 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13787648#comment-13787648 ] Robert Muir commented on LUCENE-5189: - Or maybe its a simple oversight that that RefC

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-10-06 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13787642#comment-13787642 ] Robert Muir commented on LUCENE-5189: - To get NRT working for docvalues again, I feel

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-10-06 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13787630#comment-13787630 ] Robert Muir commented on LUCENE-5189: - If someone isn't doing numeric updates, and ju

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-10-06 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13787576#comment-13787576 ] Shai Erera commented on LUCENE-5189: Committed a fix to SegmentReader (r1529611) to c

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-10-03 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13785059#comment-13785059 ] ASF subversion and git services commented on LUCENE-5189: - Commit

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-10-01 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13782923#comment-13782923 ] ASF subversion and git services commented on LUCENE-5189: - Commit

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-10-01 Thread Simon Willnauer (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13782924#comment-13782924 ] Simon Willnauer commented on LUCENE-5189: - backported the renaming to 4x as well.

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-10-01 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13782906#comment-13782906 ] ASF subversion and git services commented on LUCENE-5189: - Commit

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-10-01 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13782905#comment-13782905 ] ASF subversion and git services commented on LUCENE-5189: - Commit

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-10-01 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13782882#comment-13782882 ] Michael McCandless commented on LUCENE-5189: +1 for getAndResetApplyDeletes .

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-10-01 Thread Simon Willnauer (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13782875#comment-13782875 ] Simon Willnauer commented on LUCENE-5189: - bq. So, basically, if you only call IW

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-10-01 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13782863#comment-13782863 ] Michael McCandless commented on LUCENE-5189: +1 for Simon's patch; good catch

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-10-01 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13782802#comment-13782802 ] Shai Erera commented on LUCENE-5189: Looks good. Thanks Simon. > Numeric DocValues U

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-10-01 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13782782#comment-13782782 ] Shai Erera commented on LUCENE-5189: Thanks Simon, good catch. I think there's no tes

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-09-30 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13781991#comment-13781991 ] Michael McCandless commented on LUCENE-5189: bq. I'd not be happy with this

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-09-30 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13781914#comment-13781914 ] Shai Erera commented on LUCENE-5189: I opened LUCENE-5248 to handle the data structur

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-09-30 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13781868#comment-13781868 ] Shai Erera commented on LUCENE-5189: I don't mind if we backport the whole thing in o

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-09-30 Thread Simon Willnauer (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13781810#comment-13781810 ] Simon Willnauer commented on LUCENE-5189: - bq. I suppose we could also wait some

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-09-30 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13781799#comment-13781799 ] Robert Muir commented on LUCENE-5189: - I don't think we should do that: then tests ma

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-09-30 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13781797#comment-13781797 ] Shai Erera commented on LUCENE-5189: I wrote (somewhere, don't remember where) that I

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-09-30 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13781788#comment-13781788 ] Robert Muir commented on LUCENE-5189: - I'm only confused by the strategy of the backp

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-09-30 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13781746#comment-13781746 ] Michael McCandless commented on LUCENE-5189: I think backporting now is OK: w

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-09-30 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13781731#comment-13781731 ] Shai Erera commented on LUCENE-5189: I don't understand - why can't it live in 4x and

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-09-30 Thread Simon Willnauer (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13781720#comment-13781720 ] Simon Willnauer commented on LUCENE-5189: - I don't think we should backport this

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-09-27 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13780670#comment-13780670 ] ASF subversion and git services commented on LUCENE-5189: - Commit

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-09-19 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13772628#comment-13772628 ] ASF subversion and git services commented on LUCENE-5189: - Commit

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-09-19 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13772623#comment-13772623 ] ASF subversion and git services commented on LUCENE-5189: - Commit

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-09-16 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13768274#comment-13768274 ] Shai Erera commented on LUCENE-5189: Jenkins reported this failure, which I'm unable

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-09-16 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13768271#comment-13768271 ] Shai Erera commented on LUCENE-5189: bq. SegmentWriteState flushState; in DWPT is unu

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-09-16 Thread Simon Willnauer (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13768204#comment-13768204 ] Simon Willnauer commented on LUCENE-5189: - I only briefly looked at the changed i

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-09-15 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13767999#comment-13767999 ] ASF subversion and git services commented on LUCENE-5189: - Commit

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-09-15 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13767853#comment-13767853 ] Shai Erera commented on LUCENE-5189: Thanks, committed to trunk, revision 1523461. Af

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-09-15 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13767852#comment-13767852 ] ASF subversion and git services commented on LUCENE-5189: - Commit

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-09-15 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13767799#comment-13767799 ] Robert Muir commented on LUCENE-5189: - +1 to go to trunk. thanks Shai.

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-09-14 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13767578#comment-13767578 ] Michael McCandless commented on LUCENE-5189: New patch looks great! The ref

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-09-04 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13758328#comment-13758328 ] Shai Erera commented on LUCENE-5189: Correct, that's a problem that Rob identified fe

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-09-04 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13758311#comment-13758311 ] Shai Erera commented on LUCENE-5189: I think global FIS is an interesting idea, but p

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-09-04 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13758325#comment-13758325 ] Yonik Seeley commented on LUCENE-5189: -- The problem that Mike highlights "some segme

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-09-04 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13758257#comment-13758257 ] Michael McCandless commented on LUCENE-5189: Actually, that would also solve

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-09-04 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13758251#comment-13758251 ] Michael McCandless commented on LUCENE-5189: One option, to solve the "some s

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-09-04 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13758233#comment-13758233 ] Michael McCandless commented on LUCENE-5189: bq. Frankly I am tired of hearin

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-09-04 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13757921#comment-13757921 ] Shai Erera commented on LUCENE-5189: bq. It does not solve problem #2 (SegmentInfos.a

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-09-04 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13757885#comment-13757885 ] Robert Muir commented on LUCENE-5189: - {quote} Just so I understand, if we gen FieldI

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-09-04 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13757875#comment-13757875 ] Robert Muir commented on LUCENE-5189: - {quote} This would let us proceed (progress no

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-09-04 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13757864#comment-13757864 ] Shai Erera commented on LUCENE-5189: Just so I understand, if we gen FieldInfos, does

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-09-04 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13757802#comment-13757802 ] Robert Muir commented on LUCENE-5189: - {quote} But I also don't mind moving forward w

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-09-04 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13757688#comment-13757688 ] Shai Erera commented on LUCENE-5189: I think it's important to solve FIS.gen, either

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-09-04 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13757674#comment-13757674 ] Michael McCandless commented on LUCENE-5189: We could simply document this as

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-09-03 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13756884#comment-13756884 ] Robert Muir commented on LUCENE-5189: - It really doesn't work: its definitely a block

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-09-03 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13756896#comment-13756896 ] Robert Muir commented on LUCENE-5189: - By the way: the "general" issue is that for up

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-09-03 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13756931#comment-13756931 ] Shai Erera commented on LUCENE-5189: OK, so now I get your point. The problem is that

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-09-03 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13756863#comment-13756863 ] Shai Erera commented on LUCENE-5189: I don't understand the problem that you raise. U

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-09-03 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13756678#comment-13756678 ] Robert Muir commented on LUCENE-5189: - {quote} Patch adds per-field support. I curren

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-09-03 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13756650#comment-13756650 ] Shai Erera commented on LUCENE-5189: Thanks for the review Mike. I nuked the two unus

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-09-03 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13756494#comment-13756494 ] Michael McCandless commented on LUCENE-5189: Patch looks great! I review som

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-08-29 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13753622#comment-13753622 ] Uwe Schindler commented on LUCENE-5189: --- bq. This callback would need to also get t

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-08-29 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13753600#comment-13753600 ] Shai Erera commented on LUCENE-5189: I definitely want to add update by query, but in

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-08-29 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13753586#comment-13753586 ] Uwe Schindler commented on LUCENE-5189: --- Hi, I had an idea yesterday when thinking

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-08-29 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13753557#comment-13753557 ] Shai Erera commented on LUCENE-5189: Regarding problem 1, I hardwired the test to use

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-08-29 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13753500#comment-13753500 ] Shai Erera commented on LUCENE-5189: Regarding problem 3, Mike helped me construct a

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-08-29 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13753482#comment-13753482 ] Shai Erera commented on LUCENE-5189: BTW, this may generally not be a bad idea, to le

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-08-29 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13753476#comment-13753476 ] Shai Erera commented on LUCENE-5189: Regarding problem 1, I don't know if it's a vali

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-08-29 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13753391#comment-13753391 ] Robert Muir commented on LUCENE-5189: - In the case of old codecs: what we do is prett

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-08-28 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13753312#comment-13753312 ] Shai Erera commented on LUCENE-5189: Thanks Rob. I forgot about SuppressCodecs :). I

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-08-28 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13752977#comment-13752977 ] Robert Muir commented on LUCENE-5189: - You can add \@SuppressCodecs(\{"Lucene40", "So

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-08-28 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13752462#comment-13752462 ] Robert Muir commented on LUCENE-5189: - I think its true we can tackle this in a separ

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-08-28 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13752456#comment-13752456 ] Shai Erera commented on LUCENE-5189: The problem is that there are two Directories an

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-08-28 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13752438#comment-13752438 ] Robert Muir commented on LUCENE-5189: - by the way if we want to fix the state.directo

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-08-28 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13752436#comment-13752436 ] Robert Muir commented on LUCENE-5189: - {quote} Maybe for writing it can work, but the

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-08-28 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13752424#comment-13752424 ] Shai Erera commented on LUCENE-5189: bq. Can we refer to this consistently as docValu

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-08-28 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13752419#comment-13752419 ] Robert Muir commented on LUCENE-5189: - {quote} That way you can end up with e.g. _0_L

[jira] [Commented] (LUCENE-5189) Numeric DocValues Updates

2013-08-28 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13752409#comment-13752409 ] Shai Erera commented on LUCENE-5189: I forgot to mention -- this work started from a

  1   2   >