[jira] [Commented] (LUCENE-5569) Rename AtomicReader to LeafReader
[
https://issues.apache.org/jira/browse/LUCENE-5569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14293270#comment-14293270
]
Adrien Grand commented on LUCENE-5569:
--
Actually I think this 5.0 break is one of the easiest ones to fix when
upgrading. Although it might generate lots of compilation errors, especially if
you use experimental APIs like oal.search.Collector, it's very easy to fix
using eg. sed to replace all occurrences of AtomicReader with LeafReader (which
will also rename AtomicReaderContext to LeafReaderContext).
Rename AtomicReader to LeafReader
-
Key: LUCENE-5569
URL: https://issues.apache.org/jira/browse/LUCENE-5569
Project: Lucene - Core
Issue Type: Improvement
Reporter: Adrien Grand
Assignee: Ryan Ernst
Priority: Blocker
Fix For: 5.0
Attachments: LUCENE-5569.patch, LUCENE-5569.patch
See LUCENE-5527 for more context: several of us seem to prefer {{Leaf}} to
{{Atomic}}.
Talking from my experience, I was a bit confused in the beginning that this
thing is named {{AtomicReader}}, since {{Atomic}} is otherwise used in Java
in the context of concurrency. So maybe renaming it to {{Leaf}} would help
remove this confusion and also carry the information that these readers are
used as leaves of top-level readers?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5569) Rename AtomicReader to LeafReader
[
https://issues.apache.org/jira/browse/LUCENE-5569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14291720#comment-14291720
]
Sanne Grinovero commented on LUCENE-5569:
-
As a heavy Lucene consumer I probably have no right at all to complain :)
But now that the time has come to test the candidate release for 5.0, let me
share some facts:
- This change caused some ~600 compile errors in our codebase
- My personal opinion being that {{AtomicReader}} was a very good name, please
take it as a statement that such names are quite a personal choice and someone
just needs to make a call (And stick to it!).
Indeed it's not a major blocker, but as [~ysee...@gmail.com] wisely puts it,
I'd wish the bar against API changes was higher, especially when there isn't a
really good reason.
Rename AtomicReader to LeafReader
-
Key: LUCENE-5569
URL: https://issues.apache.org/jira/browse/LUCENE-5569
Project: Lucene - Core
Issue Type: Improvement
Reporter: Adrien Grand
Assignee: Ryan Ernst
Priority: Blocker
Fix For: 5.0
Attachments: LUCENE-5569.patch, LUCENE-5569.patch
See LUCENE-5527 for more context: several of us seem to prefer {{Leaf}} to
{{Atomic}}.
Talking from my experience, I was a bit confused in the beginning that this
thing is named {{AtomicReader}}, since {{Atomic}} is otherwise used in Java
in the context of concurrency. So maybe renaming it to {{Leaf}} would help
remove this confusion and also carry the information that these readers are
used as leaves of top-level readers?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5569) Rename AtomicReader to LeafReader
[
https://issues.apache.org/jira/browse/LUCENE-5569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14279509#comment-14279509
]
ASF subversion and git services commented on LUCENE-5569:
-
Commit 1652310 from [~rjernst] in branch 'dev/branches/branch_5x'
[ https://svn.apache.org/r1652310 ]
LUCENE-5569: Add MIGRATE entry for 5.0
Rename AtomicReader to LeafReader
-
Key: LUCENE-5569
URL: https://issues.apache.org/jira/browse/LUCENE-5569
Project: Lucene - Core
Issue Type: Improvement
Reporter: Adrien Grand
Assignee: Ryan Ernst
Priority: Blocker
Fix For: 5.0
Attachments: LUCENE-5569.patch, LUCENE-5569.patch
See LUCENE-5527 for more context: several of us seem to prefer {{Leaf}} to
{{Atomic}}.
Talking from my experience, I was a bit confused in the beginning that this
thing is named {{AtomicReader}}, since {{Atomic}} is otherwise used in Java
in the context of concurrency. So maybe renaming it to {{Leaf}} would help
remove this confusion and also carry the information that these readers are
used as leaves of top-level readers?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5569) Rename AtomicReader to LeafReader
[
https://issues.apache.org/jira/browse/LUCENE-5569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14279513#comment-14279513
]
ASF subversion and git services commented on LUCENE-5569:
-
Commit 1652311 from [~rjernst] in branch 'dev/branches/lucene_solr_5_0'
[ https://svn.apache.org/r1652311 ]
LUCENE-5569: Add MIGRATE entry for 5.0 (merged 1652310)
Rename AtomicReader to LeafReader
-
Key: LUCENE-5569
URL: https://issues.apache.org/jira/browse/LUCENE-5569
Project: Lucene - Core
Issue Type: Improvement
Reporter: Adrien Grand
Assignee: Ryan Ernst
Priority: Blocker
Fix For: 5.0
Attachments: LUCENE-5569.patch, LUCENE-5569.patch
See LUCENE-5527 for more context: several of us seem to prefer {{Leaf}} to
{{Atomic}}.
Talking from my experience, I was a bit confused in the beginning that this
thing is named {{AtomicReader}}, since {{Atomic}} is otherwise used in Java
in the context of concurrency. So maybe renaming it to {{Leaf}} would help
remove this confusion and also carry the information that these readers are
used as leaves of top-level readers?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5569) Rename AtomicReader to LeafReader
[
https://issues.apache.org/jira/browse/LUCENE-5569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14279427#comment-14279427
]
ASF subversion and git services commented on LUCENE-5569:
-
Commit 1652295 from [~rjernst] in branch 'dev/branches/lucene_solr_5_0'
[ https://svn.apache.org/r1652295 ]
LUCENE-5569: Backport changes entry (merged 1652294)
Rename AtomicReader to LeafReader
-
Key: LUCENE-5569
URL: https://issues.apache.org/jira/browse/LUCENE-5569
Project: Lucene - Core
Issue Type: Improvement
Reporter: Adrien Grand
Assignee: Ryan Ernst
Priority: Blocker
Fix For: 5.0
Attachments: LUCENE-5569.patch, LUCENE-5569.patch
See LUCENE-5527 for more context: several of us seem to prefer {{Leaf}} to
{{Atomic}}.
Talking from my experience, I was a bit confused in the beginning that this
thing is named {{AtomicReader}}, since {{Atomic}} is otherwise used in Java
in the context of concurrency. So maybe renaming it to {{Leaf}} would help
remove this confusion and also carry the information that these readers are
used as leaves of top-level readers?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5569) Rename AtomicReader to LeafReader
[
https://issues.apache.org/jira/browse/LUCENE-5569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14279444#comment-14279444
]
Ryan Ernst commented on LUCENE-5569:
[~varunthacker] This was an oversight when doing the {{branch_5x}} backport,
because it was done independently (without merge). I've copied the changes
entry back to {{branch_5x}} and {{lucene_solr_5_0}}.
Rename AtomicReader to LeafReader
-
Key: LUCENE-5569
URL: https://issues.apache.org/jira/browse/LUCENE-5569
Project: Lucene - Core
Issue Type: Improvement
Reporter: Adrien Grand
Assignee: Ryan Ernst
Priority: Blocker
Fix For: 5.0
Attachments: LUCENE-5569.patch, LUCENE-5569.patch
See LUCENE-5527 for more context: several of us seem to prefer {{Leaf}} to
{{Atomic}}.
Talking from my experience, I was a bit confused in the beginning that this
thing is named {{AtomicReader}}, since {{Atomic}} is otherwise used in Java
in the context of concurrency. So maybe renaming it to {{Leaf}} would help
remove this confusion and also carry the information that these readers are
used as leaves of top-level readers?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5569) Rename AtomicReader to LeafReader
[
https://issues.apache.org/jira/browse/LUCENE-5569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14279522#comment-14279522
]
Ryan Ernst commented on LUCENE-5569:
Good idea Uwe, I've added a migrate entry.
Rename AtomicReader to LeafReader
-
Key: LUCENE-5569
URL: https://issues.apache.org/jira/browse/LUCENE-5569
Project: Lucene - Core
Issue Type: Improvement
Reporter: Adrien Grand
Assignee: Ryan Ernst
Priority: Blocker
Fix For: 5.0
Attachments: LUCENE-5569.patch, LUCENE-5569.patch
See LUCENE-5527 for more context: several of us seem to prefer {{Leaf}} to
{{Atomic}}.
Talking from my experience, I was a bit confused in the beginning that this
thing is named {{AtomicReader}}, since {{Atomic}} is otherwise used in Java
in the context of concurrency. So maybe renaming it to {{Leaf}} would help
remove this confusion and also carry the information that these readers are
used as leaves of top-level readers?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5569) Rename AtomicReader to LeafReader
[
https://issues.apache.org/jira/browse/LUCENE-5569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14279423#comment-14279423
]
ASF subversion and git services commented on LUCENE-5569:
-
Commit 1652294 from [~rjernst] in branch 'dev/branches/branch_5x'
[ https://svn.apache.org/r1652294 ]
LUCENE-5569: Backport changes entry
Rename AtomicReader to LeafReader
-
Key: LUCENE-5569
URL: https://issues.apache.org/jira/browse/LUCENE-5569
Project: Lucene - Core
Issue Type: Improvement
Reporter: Adrien Grand
Assignee: Ryan Ernst
Priority: Blocker
Fix For: 5.0
Attachments: LUCENE-5569.patch, LUCENE-5569.patch
See LUCENE-5527 for more context: several of us seem to prefer {{Leaf}} to
{{Atomic}}.
Talking from my experience, I was a bit confused in the beginning that this
thing is named {{AtomicReader}}, since {{Atomic}} is otherwise used in Java
in the context of concurrency. So maybe renaming it to {{Leaf}} would help
remove this confusion and also carry the information that these readers are
used as leaves of top-level readers?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5569) Rename AtomicReader to LeafReader
[
https://issues.apache.org/jira/browse/LUCENE-5569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14279500#comment-14279500
]
Uwe Schindler commented on LUCENE-5569:
---
Do we have it in 5.0's MIGRATE.txt? Maybe we should place it there, because
this may be a major rename for people with lots of custom code.
Rename AtomicReader to LeafReader
-
Key: LUCENE-5569
URL: https://issues.apache.org/jira/browse/LUCENE-5569
Project: Lucene - Core
Issue Type: Improvement
Reporter: Adrien Grand
Assignee: Ryan Ernst
Priority: Blocker
Fix For: 5.0
Attachments: LUCENE-5569.patch, LUCENE-5569.patch
See LUCENE-5527 for more context: several of us seem to prefer {{Leaf}} to
{{Atomic}}.
Talking from my experience, I was a bit confused in the beginning that this
thing is named {{AtomicReader}}, since {{Atomic}} is otherwise used in Java
in the context of concurrency. So maybe renaming it to {{Leaf}} would help
remove this confusion and also carry the information that these readers are
used as leaves of top-level readers?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5569) Rename AtomicReader to LeafReader
[
https://issues.apache.org/jira/browse/LUCENE-5569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14276387#comment-14276387
]
Varun Thacker commented on LUCENE-5569:
---
Hi [~rjernst] ,
I don't see an entry for this in the CHANGES.txt. Should there be one or is it
documented somewhere else?
Rename AtomicReader to LeafReader
-
Key: LUCENE-5569
URL: https://issues.apache.org/jira/browse/LUCENE-5569
Project: Lucene - Core
Issue Type: Improvement
Reporter: Adrien Grand
Assignee: Ryan Ernst
Priority: Blocker
Fix For: 5.0
Attachments: LUCENE-5569.patch, LUCENE-5569.patch
See LUCENE-5527 for more context: several of us seem to prefer {{Leaf}} to
{{Atomic}}.
Talking from my experience, I was a bit confused in the beginning that this
thing is named {{AtomicReader}}, since {{Atomic}} is otherwise used in Java
in the context of concurrency. So maybe renaming it to {{Leaf}} would help
remove this confusion and also carry the information that these readers are
used as leaves of top-level readers?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5569) Rename AtomicReader to LeafReader
[
https://issues.apache.org/jira/browse/LUCENE-5569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14146075#comment-14146075
]
ASF subversion and git services commented on LUCENE-5569:
-
Commit 1627258 from [~rjernst] in branch 'dev/trunk'
[ https://svn.apache.org/r1627258 ]
LUCENE-5569: Rename more locations in test classes and comments
Rename AtomicReader to LeafReader
-
Key: LUCENE-5569
URL: https://issues.apache.org/jira/browse/LUCENE-5569
Project: Lucene - Core
Issue Type: Improvement
Reporter: Adrien Grand
Priority: Blocker
Fix For: Trunk
Attachments: LUCENE-5569.patch, LUCENE-5569.patch
See LUCENE-5527 for more context: several of us seem to prefer {{Leaf}} to
{{Atomic}}.
Talking from my experience, I was a bit confused in the beginning that this
thing is named {{AtomicReader}}, since {{Atomic}} is otherwise used in Java
in the context of concurrency. So maybe renaming it to {{Leaf}} would help
remove this confusion and also carry the information that these readers are
used as leaves of top-level readers?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5569) Rename AtomicReader to LeafReader
[
https://issues.apache.org/jira/browse/LUCENE-5569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14146123#comment-14146123
]
ASF subversion and git services commented on LUCENE-5569:
-
Commit 1627266 from [~rjernst] in branch 'dev/branches/branch_5x'
[ https://svn.apache.org/r1627266 ]
LUCENE-5569: Rename more locations in test classes and comments (merged 1627258)
Rename AtomicReader to LeafReader
-
Key: LUCENE-5569
URL: https://issues.apache.org/jira/browse/LUCENE-5569
Project: Lucene - Core
Issue Type: Improvement
Reporter: Adrien Grand
Priority: Blocker
Fix For: 5.0
Attachments: LUCENE-5569.patch, LUCENE-5569.patch
See LUCENE-5527 for more context: several of us seem to prefer {{Leaf}} to
{{Atomic}}.
Talking from my experience, I was a bit confused in the beginning that this
thing is named {{AtomicReader}}, since {{Atomic}} is otherwise used in Java
in the context of concurrency. So maybe renaming it to {{Leaf}} would help
remove this confusion and also carry the information that these readers are
used as leaves of top-level readers?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5569) Rename AtomicReader to LeafReader
[
https://issues.apache.org/jira/browse/LUCENE-5569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14145643#comment-14145643
]
ASF subversion and git services commented on LUCENE-5569:
-
Commit 1627178 from [~rjernst] in branch 'dev/trunk'
[ https://svn.apache.org/r1627178 ]
LUCENE-5569: *AtomicReader/AtomicReaderContext have been renamed to
*LeafReader/LeafReaderContext
Rename AtomicReader to LeafReader
-
Key: LUCENE-5569
URL: https://issues.apache.org/jira/browse/LUCENE-5569
Project: Lucene - Core
Issue Type: Improvement
Reporter: Adrien Grand
Priority: Blocker
Fix For: Trunk
Attachments: LUCENE-5569.patch, LUCENE-5569.patch
See LUCENE-5527 for more context: several of us seem to prefer {{Leaf}} to
{{Atomic}}.
Talking from my experience, I was a bit confused in the beginning that this
thing is named {{AtomicReader}}, since {{Atomic}} is otherwise used in Java
in the context of concurrency. So maybe renaming it to {{Leaf}} would help
remove this confusion and also carry the information that these readers are
used as leaves of top-level readers?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5569) Rename AtomicReader to LeafReader
[
https://issues.apache.org/jira/browse/LUCENE-5569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14145739#comment-14145739
]
ASF subversion and git services commented on LUCENE-5569:
-
Commit 1627188 from [~rjernst] in branch 'dev/branches/branch_5x'
[ https://svn.apache.org/r1627188 ]
LUCENE-5569: *AtomicReader/AtomicReaderContext have been renamed to
*LeafReader/LeafReaderContext (merged 1627178)
Rename AtomicReader to LeafReader
-
Key: LUCENE-5569
URL: https://issues.apache.org/jira/browse/LUCENE-5569
Project: Lucene - Core
Issue Type: Improvement
Reporter: Adrien Grand
Priority: Blocker
Fix For: Trunk
Attachments: LUCENE-5569.patch, LUCENE-5569.patch
See LUCENE-5527 for more context: several of us seem to prefer {{Leaf}} to
{{Atomic}}.
Talking from my experience, I was a bit confused in the beginning that this
thing is named {{AtomicReader}}, since {{Atomic}} is otherwise used in Java
in the context of concurrency. So maybe renaming it to {{Leaf}} would help
remove this confusion and also carry the information that these readers are
used as leaves of top-level readers?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5569) Rename AtomicReader to LeafReader
[
https://issues.apache.org/jira/browse/LUCENE-5569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14143635#comment-14143635
]
Michael McCandless commented on LUCENE-5569:
+1
Rename AtomicReader to LeafReader
-
Key: LUCENE-5569
URL: https://issues.apache.org/jira/browse/LUCENE-5569
Project: Lucene - Core
Issue Type: Improvement
Reporter: Adrien Grand
Priority: Blocker
Fix For: Trunk
Attachments: LUCENE-5569.patch, LUCENE-5569.patch
See LUCENE-5527 for more context: several of us seem to prefer {{Leaf}} to
{{Atomic}}.
Talking from my experience, I was a bit confused in the beginning that this
thing is named {{AtomicReader}}, since {{Atomic}} is otherwise used in Java
in the context of concurrency. So maybe renaming it to {{Leaf}} would help
remove this confusion and also carry the information that these readers are
used as leaves of top-level readers?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5569) Rename AtomicReader to LeafReader
[
https://issues.apache.org/jira/browse/LUCENE-5569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13961012#comment-13961012
]
Robert Muir commented on LUCENE-5569:
-
Yes 5.0 is the time to fix this stuff. Tim is wrong, its not a horrible burden
to users. Users don't have to upgrade. And fixing the api makes it easier on
newer users.
Rename AtomicReader to LeafReader
-
Key: LUCENE-5569
URL: https://issues.apache.org/jira/browse/LUCENE-5569
Project: Lucene - Core
Issue Type: Improvement
Reporter: Adrien Grand
Priority: Minor
Fix For: 5.0
Attachments: LUCENE-5569.patch
See LUCENE-5527 for more context: several of us seem to prefer {{Leaf}} to
{{Atomic}}.
Talking from my experience, I was a bit confused in the beginning that this
thing is named {{AtomicReader}}, since {{Atomic}} is otherwise used in Java
in the context of concurrency. So maybe renaming it to {{Leaf}} would help
remove this confusion and also carry the information that these readers are
used as leaves of top-level readers?
--
This message was sent by Atlassian JIRA
(v6.2#6252)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5569) Rename AtomicReader to LeafReader
[
https://issues.apache.org/jira/browse/LUCENE-5569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13961013#comment-13961013
]
Adrien Grand commented on LUCENE-5569:
--
+1 to the patch. Maybe we should leave a note about this renaming in the
lucene/MIGRATE.txt?
Rename AtomicReader to LeafReader
-
Key: LUCENE-5569
URL: https://issues.apache.org/jira/browse/LUCENE-5569
Project: Lucene - Core
Issue Type: Improvement
Reporter: Adrien Grand
Priority: Minor
Fix For: 5.0
Attachments: LUCENE-5569.patch
See LUCENE-5527 for more context: several of us seem to prefer {{Leaf}} to
{{Atomic}}.
Talking from my experience, I was a bit confused in the beginning that this
thing is named {{AtomicReader}}, since {{Atomic}} is otherwise used in Java
in the context of concurrency. So maybe renaming it to {{Leaf}} would help
remove this confusion and also carry the information that these readers are
used as leaves of top-level readers?
--
This message was sent by Atlassian JIRA
(v6.2#6252)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5569) Rename AtomicReader to LeafReader
[
https://issues.apache.org/jira/browse/LUCENE-5569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13961017#comment-13961017
]
Robert Muir commented on LUCENE-5569:
-
We should also follow up by completely nuking readercontext,
atomicreadercontext. This indirection hurts and complicates all core lucene
apis, for all use cases, just to support bad practices and esoteric shit, like
climbing up reader tree and using slow wrappers.
Its ok if we are a little less flexible and simplify the API. For example we
could declare readers are instances and have a docbase and parent. Multireaders
and other weird shit could wrap the readers to fix this up.
Rename AtomicReader to LeafReader
-
Key: LUCENE-5569
URL: https://issues.apache.org/jira/browse/LUCENE-5569
Project: Lucene - Core
Issue Type: Improvement
Reporter: Adrien Grand
Priority: Minor
Fix For: 5.0
Attachments: LUCENE-5569.patch
See LUCENE-5527 for more context: several of us seem to prefer {{Leaf}} to
{{Atomic}}.
Talking from my experience, I was a bit confused in the beginning that this
thing is named {{AtomicReader}}, since {{Atomic}} is otherwise used in Java
in the context of concurrency. So maybe renaming it to {{Leaf}} would help
remove this confusion and also carry the information that these readers are
used as leaves of top-level readers?
--
This message was sent by Atlassian JIRA
(v6.2#6252)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5569) Rename AtomicReader to LeafReader
[
https://issues.apache.org/jira/browse/LUCENE-5569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13961018#comment-13961018
]
Adrien Grand commented on LUCENE-5569:
--
+1 to do that in a follow-up issue
Rename AtomicReader to LeafReader
-
Key: LUCENE-5569
URL: https://issues.apache.org/jira/browse/LUCENE-5569
Project: Lucene - Core
Issue Type: Improvement
Reporter: Adrien Grand
Priority: Minor
Fix For: 5.0
Attachments: LUCENE-5569.patch
See LUCENE-5527 for more context: several of us seem to prefer {{Leaf}} to
{{Atomic}}.
Talking from my experience, I was a bit confused in the beginning that this
thing is named {{AtomicReader}}, since {{Atomic}} is otherwise used in Java
in the context of concurrency. So maybe renaming it to {{Leaf}} would help
remove this confusion and also carry the information that these readers are
used as leaves of top-level readers?
--
This message was sent by Atlassian JIRA
(v6.2#6252)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5569) Rename AtomicReader to LeafReader
[
https://issues.apache.org/jira/browse/LUCENE-5569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13961068#comment-13961068
]
Yonik Seeley commented on LUCENE-5569:
--
FWIW, I agree with Tim. There's not a right or wrong to it... it's a judgement
call. It's clear to me that the bar these days to renaming public APIs is far
too low... but I appear to be outnumbered.
Rename AtomicReader to LeafReader
-
Key: LUCENE-5569
URL: https://issues.apache.org/jira/browse/LUCENE-5569
Project: Lucene - Core
Issue Type: Improvement
Reporter: Adrien Grand
Priority: Minor
Fix For: 5.0
Attachments: LUCENE-5569.patch
See LUCENE-5527 for more context: several of us seem to prefer {{Leaf}} to
{{Atomic}}.
Talking from my experience, I was a bit confused in the beginning that this
thing is named {{AtomicReader}}, since {{Atomic}} is otherwise used in Java
in the context of concurrency. So maybe renaming it to {{Leaf}} would help
remove this confusion and also carry the information that these readers are
used as leaves of top-level readers?
--
This message was sent by Atlassian JIRA
(v6.2#6252)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5569) Rename AtomicReader to LeafReader
[
https://issues.apache.org/jira/browse/LUCENE-5569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13961076#comment-13961076
]
Uwe Schindler commented on LUCENE-5569:
---
Hi,
I also tend to aggree with Yonik and Tim. In general I would also prefer to
rename it. Unfortunately i was the one who added that name in the big
IndexReader refactoring. But at that time we all agreed on that name.
But we should have thought better about it. LeafReader is fine, especially
becaus ethe other APIs already use leave: Like {{ReaderContext#leaves()}}.
If we really want to rename that, we should do this shortly before the release
of 5.0. Otherwise merging might be much harder from trunk to 4.x. As this is
just an eclipse rename of 2 classes (AtomicReader, AtomicReaderContext), this
is not much work, just an Eclipse-automatism. The remaining classes is the
same: FilterAtomicReader, and various test-only readers.
Rename AtomicReader to LeafReader
-
Key: LUCENE-5569
URL: https://issues.apache.org/jira/browse/LUCENE-5569
Project: Lucene - Core
Issue Type: Improvement
Reporter: Adrien Grand
Priority: Minor
Fix For: 5.0
Attachments: LUCENE-5569.patch
See LUCENE-5527 for more context: several of us seem to prefer {{Leaf}} to
{{Atomic}}.
Talking from my experience, I was a bit confused in the beginning that this
thing is named {{AtomicReader}}, since {{Atomic}} is otherwise used in Java
in the context of concurrency. So maybe renaming it to {{Leaf}} would help
remove this confusion and also carry the information that these readers are
used as leaves of top-level readers?
--
This message was sent by Atlassian JIRA
(v6.2#6252)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5569) Rename AtomicReader to LeafReader
[
https://issues.apache.org/jira/browse/LUCENE-5569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13959083#comment-13959083
]
Michael McCandless commented on LUCENE-5569:
+1
Rename AtomicReader to LeafReader
-
Key: LUCENE-5569
URL: https://issues.apache.org/jira/browse/LUCENE-5569
Project: Lucene - Core
Issue Type: Improvement
Reporter: Adrien Grand
Priority: Minor
Fix For: 5.0
See LUCENE-5527 for more context: several of us seem to prefer {{Leaf}} to
{{Atomic}}.
Talking from my experience, I was a bit confused in the beginning that this
thing is named {{AtomicReader}}, since {{Atomic}} is otherwise used in Java
in the context of concurrency. So maybe renaming it to {{Leaf}} would help
remove this confusion and also carry the information that these readers are
used as leaves of top-level readers?
--
This message was sent by Atlassian JIRA
(v6.2#6252)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5569) Rename AtomicReader to LeafReader
[
https://issues.apache.org/jira/browse/LUCENE-5569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13959096#comment-13959096
]
Tim Smith commented on LUCENE-5569:
---
-1
please don't do this
renaming things for the sake of renaming them is a horrible burden on people
using these apis
for instance, every single minor version of lucene 4.x has broken api
signatures, resulting in hours, or days worth of time to reconcile the changes
add in a major name change like this and it adds in significant noise to fixing
any real compile errors and significantly complicates the porting process (it
took me weeks to upgrade from lucene 3.x to 4.x, i don't want to do that again)
AtomicReader is a public api in lucene and should not be renamed just because a
new name seems better
Rename AtomicReader to LeafReader
-
Key: LUCENE-5569
URL: https://issues.apache.org/jira/browse/LUCENE-5569
Project: Lucene - Core
Issue Type: Improvement
Reporter: Adrien Grand
Priority: Minor
Fix For: 5.0
See LUCENE-5527 for more context: several of us seem to prefer {{Leaf}} to
{{Atomic}}.
Talking from my experience, I was a bit confused in the beginning that this
thing is named {{AtomicReader}}, since {{Atomic}} is otherwise used in Java
in the context of concurrency. So maybe renaming it to {{Leaf}} would help
remove this confusion and also carry the information that these readers are
used as leaves of top-level readers?
--
This message was sent by Atlassian JIRA
(v6.2#6252)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
