[jira] [Commented] (LUCENE-7715) Simplify NearSpansUnordered
[
https://issues.apache.org/jira/browse/LUCENE-7715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15892930#comment-15892930
]
Paul Elschot commented on LUCENE-7715:
--
Thanks Adrien.
> Simplify NearSpansUnordered
> ---
>
> Key: LUCENE-7715
> URL: https://issues.apache.org/jira/browse/LUCENE-7715
> Project: Lucene - Core
> Issue Type: Bug
> Components: core/search
>Affects Versions: master (7.0)
>Reporter: Paul Elschot
>Priority: Minor
> Fix For: master (7.0), 6.5
>
> Attachments: LUCENE-7715.patch
>
>
> {code}
> git diff --stat master...
> .../spans/NearSpansUnordered.java | 211 -
> 1 file changed, 59 insertions(+), 152 deletions(-)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7715) Simplify NearSpansUnordered
[
https://issues.apache.org/jira/browse/LUCENE-7715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15892247#comment-15892247
]
ASF subversion and git services commented on LUCENE-7715:
-
Commit 3087eb50066ce9335012b718a310249ac5b9ce5c in lucene-solr's branch
refs/heads/master from [~jpountz]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=3087eb5 ]
LUCENE-7715: NearSpansUnordered simplifications.
> Simplify NearSpansUnordered
> ---
>
> Key: LUCENE-7715
> URL: https://issues.apache.org/jira/browse/LUCENE-7715
> Project: Lucene - Core
> Issue Type: Bug
> Components: core/search
>Affects Versions: master (7.0)
>Reporter: Paul Elschot
>Priority: Minor
> Attachments: LUCENE-7715.patch
>
>
> {code}
> git diff --stat master...
> .../spans/NearSpansUnordered.java | 211 -
> 1 file changed, 59 insertions(+), 152 deletions(-)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7715) Simplify NearSpansUnordered
[
https://issues.apache.org/jira/browse/LUCENE-7715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15892246#comment-15892246
]
ASF subversion and git services commented on LUCENE-7715:
-
Commit 780690b1e9fe9b029ee15cdf81d1f697e2fe4cc7 in lucene-solr's branch
refs/heads/branch_6x from [~jpountz]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=780690b ]
LUCENE-7715: NearSpansUnordered simplifications.
> Simplify NearSpansUnordered
> ---
>
> Key: LUCENE-7715
> URL: https://issues.apache.org/jira/browse/LUCENE-7715
> Project: Lucene - Core
> Issue Type: Bug
> Components: core/search
>Affects Versions: master (7.0)
>Reporter: Paul Elschot
>Priority: Minor
> Attachments: LUCENE-7715.patch
>
>
> {code}
> git diff --stat master...
> .../spans/NearSpansUnordered.java | 211 -
> 1 file changed, 59 insertions(+), 152 deletions(-)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7715) Simplify NearSpansUnordered
[
https://issues.apache.org/jira/browse/LUCENE-7715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891997#comment-15891997
]
Adrien Grand commented on LUCENE-7715:
--
OK, I just applied the patch to understand how it works. It looks good to me,
I'll merge it soon. Thanks Paul!
> Simplify NearSpansUnordered
> ---
>
> Key: LUCENE-7715
> URL: https://issues.apache.org/jira/browse/LUCENE-7715
> Project: Lucene - Core
> Issue Type: Bug
> Components: core/search
>Affects Versions: master (7.0)
>Reporter: Paul Elschot
>Priority: Minor
> Attachments: LUCENE-7715.patch
>
>
> {code}
> git diff --stat master...
> .../spans/NearSpansUnordered.java | 211 -
> 1 file changed, 59 insertions(+), 152 deletions(-)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7715) Simplify NearSpansUnordered
[
https://issues.apache.org/jira/browse/LUCENE-7715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15888703#comment-15888703
]
Paul Elschot commented on LUCENE-7715:
--
bq. ... how it deals with the initial state that all sub spans have a start
position of -1.
There is no need for that, the intermediate data structure is a priority queue
that is not a Spans itself.
If the names of this priority queue (SpanTotalLengthEndPositionWindow) and its
methods (startDocument/nextPosition) are misleading, they need to be improved.
The core search tests and precommit pass.
> Simplify NearSpansUnordered
> ---
>
> Key: LUCENE-7715
> URL: https://issues.apache.org/jira/browse/LUCENE-7715
> Project: Lucene - Core
> Issue Type: Bug
> Components: core/search
>Affects Versions: master (7.0)
>Reporter: Paul Elschot
>Priority: Minor
> Attachments: LUCENE-7715.patch
>
>
> {code}
> git diff --stat master...
> .../spans/NearSpansUnordered.java | 211 -
> 1 file changed, 59 insertions(+), 152 deletions(-)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7715) Simplify NearSpansUnordered
[
https://issues.apache.org/jira/browse/LUCENE-7715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15887663#comment-15887663
]
Adrien Grand commented on LUCENE-7715:
--
I haven't tried the patch, but I don't see how it deals with the initial state
that all sub spans have a start position of -1. In master currently,
nextStartPosition iterates over the pq until the start position of the top
element is greater than -1, but I don't see that logic in your patch. There is
a {{startDocument}} method but if I am not mistaken it is only called from
two-phase iteration, so if {{NearSpansUnordered}} are consumed directly, that
would work, but not if they are nested within other spans? (I'm not very
familiar with spans so I could easily miss something.)
> Simplify NearSpansUnordered
> ---
>
> Key: LUCENE-7715
> URL: https://issues.apache.org/jira/browse/LUCENE-7715
> Project: Lucene - Core
> Issue Type: Bug
> Components: core/search
>Affects Versions: master (7.0)
>Reporter: Paul Elschot
>Priority: Minor
> Attachments: LUCENE-7715.patch
>
>
> {code}
> git diff --stat master...
> .../spans/NearSpansUnordered.java | 211 -
> 1 file changed, 59 insertions(+), 152 deletions(-)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
