[jira] [Commented] (LUCENE-7738) Add new InetAddressRangeField

2017-04-05 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15957156#comment-15957156 ] ASF subversion and git services commented on LUCENE-7738: - Commit

[jira] [Commented] (LUCENE-7738) Add new InetAddressRangeField

2017-04-05 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15957153#comment-15957153 ] ASF subversion and git services commented on LUCENE-7738: - Commit

[jira] [Commented] (LUCENE-7738) Add new InetAddressRangeField

2017-04-05 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15957148#comment-15957148 ] ASF subversion and git services commented on LUCENE-7738: - Commit

[jira] [Commented] (LUCENE-7738) Add new InetAddressRangeField

2017-03-18 Thread Erick Erickson (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15931235#comment-15931235 ] Erick Erickson commented on LUCENE-7738: This has been committed, can it be closed? > Add new

[jira] [Commented] (LUCENE-7738) Add new InetAddressRangeField

2017-03-11 Thread Nicholas Knize (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15906383#comment-15906383 ] Nicholas Knize commented on LUCENE-7738: I opened LUCENE-7740 to refactor class names and move

[jira] [Commented] (LUCENE-7738) Add new InetAddressRangeField

2017-03-11 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15906384#comment-15906384 ] Adrien Grand commented on LUCENE-7738: -- Actually can you remove the {{e.printStackTrace()}} call in

[jira] [Commented] (LUCENE-7738) Add new InetAddressRangeField

2017-03-11 Thread Nicholas Knize (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15906385#comment-15906385 ] Nicholas Knize commented on LUCENE-7738: +1 > Add new InetAddressRangeField >

[jira] [Commented] (LUCENE-7738) Add new InetAddressRangeField

2017-03-11 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15906380#comment-15906380 ] ASF subversion and git services commented on LUCENE-7738: - Commit

[jira] [Commented] (LUCENE-7738) Add new InetAddressRangeField

2017-03-11 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15906379#comment-15906379 ] Adrien Grand commented on LUCENE-7738: -- +1 to the patch +1 to removing the "Field" suffix from range

[jira] [Commented] (LUCENE-7738) Add new InetAddressRangeField

2017-03-11 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15906378#comment-15906378 ] ASF subversion and git services commented on LUCENE-7738: - Commit

[jira] [Commented] (LUCENE-7738) Add new InetAddressRangeField

2017-03-11 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15906343#comment-15906343 ] David Smiley commented on LUCENE-7738: -- RE naming; some consistency is good. So if the non-range

[jira] [Commented] (LUCENE-7738) Add new InetAddressRangeField

2017-03-11 Thread Nicholas Knize (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15906274#comment-15906274 ] Nicholas Knize commented on LUCENE-7738: Thanks [~dsmiley]! I have no problem putting both

[jira] [Commented] (LUCENE-7738) Add new InetAddressRangeField

2017-03-10 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15906029#comment-15906029 ] David Smiley commented on LUCENE-7738: -- This is very nice and especially well documented; nice job

[jira] [Commented] (LUCENE-7738) Add new InetAddressRangeField

2017-03-10 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15905838#comment-15905838 ] Adrien Grand commented on LUCENE-7738: -- +1 Could you just create ipv4 addresses in the test from a