[jira] [Commented] (LUCENE-7844) UnifiedHighlighter: simplify "maxPassages" input API

2017-05-30 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16029975#comment-16029975 ] David Smiley commented on LUCENE-7844: -- bq. I'd be in favor of leaving the current p

[jira] [Commented] (LUCENE-7844) UnifiedHighlighter: simplify "maxPassages" input API

2017-05-25 Thread Timothy M. Rodriguez (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16025178#comment-16025178 ] Timothy M. Rodriguez commented on LUCENE-7844: -- This syntax looks really goo

[jira] [Commented] (LUCENE-7844) UnifiedHighlighter: simplify "maxPassages" input API

2017-05-25 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16024934#comment-16024934 ] David Smiley commented on LUCENE-7844: -- bq. For example, a user may want to highlig

[jira] [Commented] (LUCENE-7844) UnifiedHighlighter: simplify "maxPassages" input API

2017-05-25 Thread Timothy M. Rodriguez (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16024765#comment-16024765 ] Timothy M. Rodriguez commented on LUCENE-7844: -- +1 on the comparator use. T

[jira] [Commented] (LUCENE-7844) UnifiedHighlighter: simplify "maxPassages" input API

2017-05-24 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16023374#comment-16023374 ] David Smiley commented on LUCENE-7844: -- {{int maxPassages}} (the parameter) does not

[jira] [Commented] (LUCENE-7844) UnifiedHighlighter: simplify "maxPassages" input API

2017-05-24 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16023119#comment-16023119 ] Jim Ferenczi commented on LUCENE-7844: -- +1 for the cleanup/code style of the code.