[jira] [Commented] (LUCENE-8206) TestIndexWriterWithThreads has wall-clock time dependency
[
https://issues.apache.org/jira/browse/LUCENE-8206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16404494#comment-16404494
]
Simon Willnauer commented on LUCENE-8206:
-
[~dweiss] no worries. Both comments were style / taste and/or optional. I am ok
with the patch, thanks for working on it!
> TestIndexWriterWithThreads has wall-clock time dependency
> -
>
> Key: LUCENE-8206
> URL: https://issues.apache.org/jira/browse/LUCENE-8206
> Project: Lucene - Core
> Issue Type: Task
>Reporter: Dawid Weiss
>Assignee: Dawid Weiss
>Priority: Minor
> Fix For: 7.4, master (8.0)
>
> Attachments: LUCENE-8206.patch
>
>
> {code}
> final long stopTime = System.currentTimeMillis() + 200;
> {code}
> This can cause failures on slower machines.
> {code}
> Build: https://builds.apache.org/job/Lucene-Solr-Tests-master/2422/
> 3 tests failed.
> FAILED:
> org.apache.lucene.index.TestIndexWriterWithThreads.testCloseWithThreads
> Error Message:
> thread failed before indexing a single document
> Stack Trace:
> java.lang.AssertionError: thread failed before indexing a single document
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8206) TestIndexWriterWithThreads has wall-clock time dependency
[
https://issues.apache.org/jira/browse/LUCENE-8206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16404096#comment-16404096
]
Dawid Weiss commented on LUCENE-8206:
-
Argh.. sorry Simon! Please go ahead and do a follow-up. AssertionError is fine,
but it wouldn't make much difference in general (the test framework would
handle whatever is thrown up to the the default handler). I was thinking about
adding yield... but eventually didn't since it was too scare for me to touch
that stuff. ;)
> TestIndexWriterWithThreads has wall-clock time dependency
> -
>
> Key: LUCENE-8206
> URL: https://issues.apache.org/jira/browse/LUCENE-8206
> Project: Lucene - Core
> Issue Type: Task
>Reporter: Dawid Weiss
>Assignee: Dawid Weiss
>Priority: Minor
> Fix For: 7.4, master (8.0)
>
> Attachments: LUCENE-8206.patch
>
>
> {code}
> final long stopTime = System.currentTimeMillis() + 200;
> {code}
> This can cause failures on slower machines.
> {code}
> Build: https://builds.apache.org/job/Lucene-Solr-Tests-master/2422/
> 3 tests failed.
> FAILED:
> org.apache.lucene.index.TestIndexWriterWithThreads.testCloseWithThreads
> Error Message:
> thread failed before indexing a single document
> Stack Trace:
> java.lang.AssertionError: thread failed before indexing a single document
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8206) TestIndexWriterWithThreads has wall-clock time dependency
[
https://issues.apache.org/jira/browse/LUCENE-8206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16404095#comment-16404095
]
Simon Willnauer commented on LUCENE-8206:
-
ah bummer I was just reviewing it. I think it LGTM mostly. I'd just throw
AssertionError instead of wrapping it in a RT exception if the barrier barfs.
There is also a _Thread.sleep(100);_ in there that I would love to see gone
maybe replace it with a yield()? thanks for taking care of it.
> TestIndexWriterWithThreads has wall-clock time dependency
> -
>
> Key: LUCENE-8206
> URL: https://issues.apache.org/jira/browse/LUCENE-8206
> Project: Lucene - Core
> Issue Type: Task
>Reporter: Dawid Weiss
>Assignee: Dawid Weiss
>Priority: Minor
> Fix For: master (8.0)
>
> Attachments: LUCENE-8206.patch
>
>
> {code}
> final long stopTime = System.currentTimeMillis() + 200;
> {code}
> This can cause failures on slower machines.
> {code}
> Build: https://builds.apache.org/job/Lucene-Solr-Tests-master/2422/
> 3 tests failed.
> FAILED:
> org.apache.lucene.index.TestIndexWriterWithThreads.testCloseWithThreads
> Error Message:
> thread failed before indexing a single document
> Stack Trace:
> java.lang.AssertionError: thread failed before indexing a single document
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8206) TestIndexWriterWithThreads has wall-clock time dependency
[
https://issues.apache.org/jira/browse/LUCENE-8206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16404094#comment-16404094
]
ASF subversion and git services commented on LUCENE-8206:
-
Commit 633d20fa07b87c65cc96b5cdde2739e1ea5043df in lucene-solr's branch
refs/heads/branch_7x from [~dawid.weiss]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=633d20f ]
LUCENE-8206: improvements to TestIndexWriterWithThreads.
> TestIndexWriterWithThreads has wall-clock time dependency
> -
>
> Key: LUCENE-8206
> URL: https://issues.apache.org/jira/browse/LUCENE-8206
> Project: Lucene - Core
> Issue Type: Task
>Reporter: Dawid Weiss
>Assignee: Dawid Weiss
>Priority: Minor
> Attachments: LUCENE-8206.patch
>
>
> {code}
> final long stopTime = System.currentTimeMillis() + 200;
> {code}
> This can cause failures on slower machines.
> {code}
> Build: https://builds.apache.org/job/Lucene-Solr-Tests-master/2422/
> 3 tests failed.
> FAILED:
> org.apache.lucene.index.TestIndexWriterWithThreads.testCloseWithThreads
> Error Message:
> thread failed before indexing a single document
> Stack Trace:
> java.lang.AssertionError: thread failed before indexing a single document
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8206) TestIndexWriterWithThreads has wall-clock time dependency
[
https://issues.apache.org/jira/browse/LUCENE-8206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16404093#comment-16404093
]
ASF subversion and git services commented on LUCENE-8206:
-
Commit d09cc1cb0b8cf6e30079c4f4e42d59e6e47d0e1a in lucene-solr's branch
refs/heads/master from [~dawid.weiss]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=d09cc1c ]
LUCENE-8206: improvements to TestIndexWriterWithThreads.
> TestIndexWriterWithThreads has wall-clock time dependency
> -
>
> Key: LUCENE-8206
> URL: https://issues.apache.org/jira/browse/LUCENE-8206
> Project: Lucene - Core
> Issue Type: Task
>Reporter: Dawid Weiss
>Assignee: Dawid Weiss
>Priority: Minor
> Attachments: LUCENE-8206.patch
>
>
> {code}
> final long stopTime = System.currentTimeMillis() + 200;
> {code}
> This can cause failures on slower machines.
> {code}
> Build: https://builds.apache.org/job/Lucene-Solr-Tests-master/2422/
> 3 tests failed.
> FAILED:
> org.apache.lucene.index.TestIndexWriterWithThreads.testCloseWithThreads
> Error Message:
> thread failed before indexing a single document
> Stack Trace:
> java.lang.AssertionError: thread failed before indexing a single document
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8206) TestIndexWriterWithThreads has wall-clock time dependency
[
https://issues.apache.org/jira/browse/LUCENE-8206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16404063#comment-16404063
]
Dawid Weiss commented on LUCENE-8206:
-
Ok, cleaned up testOpenTwoIndexWritersOnDifferentThreads a bit more and did
succeed in making it reach the assertions block (2 per 1000 runs, so chances
are slim). It passed. I'll commit those changes in.
> TestIndexWriterWithThreads has wall-clock time dependency
> -
>
> Key: LUCENE-8206
> URL: https://issues.apache.org/jira/browse/LUCENE-8206
> Project: Lucene - Core
> Issue Type: Task
>Reporter: Dawid Weiss
>Assignee: Dawid Weiss
>Priority: Minor
> Attachments: LUCENE-8206.patch
>
>
> {code}
> final long stopTime = System.currentTimeMillis() + 200;
> {code}
> This can cause failures on slower machines.
> {code}
> Build: https://builds.apache.org/job/Lucene-Solr-Tests-master/2422/
> 3 tests failed.
> FAILED:
> org.apache.lucene.index.TestIndexWriterWithThreads.testCloseWithThreads
> Error Message:
> thread failed before indexing a single document
> Stack Trace:
> java.lang.AssertionError: thread failed before indexing a single document
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8206) TestIndexWriterWithThreads has wall-clock time dependency
[
https://issues.apache.org/jira/browse/LUCENE-8206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16403738#comment-16403738
]
Dawid Weiss commented on LUCENE-8206:
-
So this test is pretty ugly in general... I tried to improve wall-time hacks by
adding a cyclic barrier instead of a main thread sleep and by removing the
forked thread timeout condition entirely: if the test deadlocks, the framework
will issue the failure, including stack traces.
I could not get testOpenTwoIndexWritersOnDifferentThreads to *ever* complete.
This test is strange... it has assumptions inside (instead of an if
statement?). I don't understand what it should be testing and why the
assumptions are there, but I didn't take a very close look.
> TestIndexWriterWithThreads has wall-clock time dependency
> -
>
> Key: LUCENE-8206
> URL: https://issues.apache.org/jira/browse/LUCENE-8206
> Project: Lucene - Core
> Issue Type: Task
>Reporter: Dawid Weiss
>Assignee: Dawid Weiss
>Priority: Minor
> Attachments: LUCENE-8206.patch
>
>
> {code}
> final long stopTime = System.currentTimeMillis() + 200;
> {code}
> This can cause failures on slower machines.
> {code}
> Build: https://builds.apache.org/job/Lucene-Solr-Tests-master/2422/
> 3 tests failed.
> FAILED:
> org.apache.lucene.index.TestIndexWriterWithThreads.testCloseWithThreads
> Error Message:
> thread failed before indexing a single document
> Stack Trace:
> java.lang.AssertionError: thread failed before indexing a single document
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
