[jira] [Commented] (LUCENE-8862) Collector Level Dynamic Memory Accounting

[ https://issues.apache.org/jira/browse/LUCENE-8862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16876134#comment-16876134 ] ASF subversion and git services commented on LUCENE-8862: - Commi

[jira] [Commented] (LUCENE-8862) Collector Level Dynamic Memory Accounting

[ https://issues.apache.org/jira/browse/LUCENE-8862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16876130#comment-16876130 ] Atri Sharma commented on LUCENE-8862: - [~jpountz] Thanks for pushing and reviewing!

[jira] [Commented] (LUCENE-8862) Collector Level Dynamic Memory Accounting

[ https://issues.apache.org/jira/browse/LUCENE-8862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16876129#comment-16876129 ] ASF subversion and git services commented on LUCENE-8862: - Commi

[jira] [Commented] (LUCENE-8862) Collector Level Dynamic Memory Accounting

[ https://issues.apache.org/jira/browse/LUCENE-8862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16874013#comment-16874013 ] Atri Sharma commented on LUCENE-8862: - Updated the PR with latest comments and moved

[jira] [Commented] (LUCENE-8862) Collector Level Dynamic Memory Accounting

[ https://issues.apache.org/jira/browse/LUCENE-8862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16867325#comment-16867325 ] Atri Sharma commented on LUCENE-8862: - I have opened a PR for the same. Please let m

[jira] [Commented] (LUCENE-8862) Collector Level Dynamic Memory Accounting

[ https://issues.apache.org/jira/browse/LUCENE-8862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16866467#comment-16866467 ] Atri Sharma commented on LUCENE-8862: - Right, agreed.   Another thought was if we

[jira] [Commented] (LUCENE-8862) Collector Level Dynamic Memory Accounting

[ https://issues.apache.org/jira/browse/LUCENE-8862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16866460#comment-16866460 ] Adrien Grand commented on LUCENE-8862: -- Right, but the benefit of doing it from wit

[jira] [Commented] (LUCENE-8862) Collector Level Dynamic Memory Accounting

[ https://issues.apache.org/jira/browse/LUCENE-8862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16866452#comment-16866452 ] Atri Sharma commented on LUCENE-8862: - {quote}doing it in setNextReader might perfor

[jira] [Commented] (LUCENE-8862) Collector Level Dynamic Memory Accounting

[ https://issues.apache.org/jira/browse/LUCENE-8862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16866447#comment-16866447 ] Adrien Grand commented on LUCENE-8862: -- bq. your thought is that the memory tracker

[jira] [Commented] (LUCENE-8862) Collector Level Dynamic Memory Accounting

[ https://issues.apache.org/jira/browse/LUCENE-8862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16866438#comment-16866438 ] Atri Sharma commented on LUCENE-8862: - Ah, hmm, so your thought is that the memory t

[jira] [Commented] (LUCENE-8862) Collector Level Dynamic Memory Accounting

[ https://issues.apache.org/jira/browse/LUCENE-8862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16866436#comment-16866436 ] Adrien Grand commented on LUCENE-8862: -- Could you pass the MemoryTrackerObject that

[jira] [Commented] (LUCENE-8862) Collector Level Dynamic Memory Accounting

[ https://issues.apache.org/jira/browse/LUCENE-8862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16866431#comment-16866431 ] Atri Sharma commented on LUCENE-8862: - Another option could be to introduce an inter

[jira] [Commented] (LUCENE-8862) Collector Level Dynamic Memory Accounting

[ https://issues.apache.org/jira/browse/LUCENE-8862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16866423#comment-16866423 ] Atri Sharma commented on LUCENE-8862: - [~jpountz] What are your thoughts on the opti

[jira] [Commented] (LUCENE-8862) Collector Level Dynamic Memory Accounting

[ https://issues.apache.org/jira/browse/LUCENE-8862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16866364#comment-16866364 ] Adrien Grand commented on LUCENE-8862: -- I'd like to avoid adding new methods to the

[jira] [Commented] (LUCENE-8862) Collector Level Dynamic Memory Accounting

[ https://issues.apache.org/jira/browse/LUCENE-8862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16866349#comment-16866349 ] Atri Sharma commented on LUCENE-8862: - We should probably add a visitLeafCollector(L

[jira] [Commented] (LUCENE-8862) Collector Level Dynamic Memory Accounting

[ https://issues.apache.org/jira/browse/LUCENE-8862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16865883#comment-16865883 ] Atri Sharma commented on LUCENE-8862: - The reason I was thinking of a visitor api is

[jira] [Commented] (LUCENE-8862) Collector Level Dynamic Memory Accounting

[ https://issues.apache.org/jira/browse/LUCENE-8862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16865879#comment-16865879 ] Adrien Grand commented on LUCENE-8862: -- I see. Do we need a visitor at all, we coul

[jira] [Commented] (LUCENE-8862) Collector Level Dynamic Memory Accounting

[ https://issues.apache.org/jira/browse/LUCENE-8862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16865873#comment-16865873 ] Atri Sharma commented on LUCENE-8862: - Visitor could have an API to take in a memory

[jira] [Commented] (LUCENE-8862) Collector Level Dynamic Memory Accounting

[ https://issues.apache.org/jira/browse/LUCENE-8862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16865859#comment-16865859 ] Adrien Grand commented on LUCENE-8862: -- One you have a visitor API, how would you i

[jira] [Commented] (LUCENE-8862) Collector Level Dynamic Memory Accounting

[ https://issues.apache.org/jira/browse/LUCENE-8862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16865809#comment-16865809 ] Atri Sharma commented on LUCENE-8862: - Thinking more about this, I am more inclined

[jira] [Commented] (LUCENE-8862) Collector Level Dynamic Memory Accounting

[ https://issues.apache.org/jira/browse/LUCENE-8862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16865610#comment-16865610 ] Atri Sharma commented on LUCENE-8862: - {quote}Memory accounting has a cost API-wise

[jira] [Commented] (LUCENE-8862) Collector Level Dynamic Memory Accounting

[ https://issues.apache.org/jira/browse/LUCENE-8862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16865469#comment-16865469 ] Adrien Grand commented on LUCENE-8862: -- Memory accounting has a cost API-wise. Like