[jira] [Commented] (SOLR-10153) UnifiedSolrHighlighter support for CustomSeparatorBreakIterator (LUCENE-6485)

2017-03-02 Thread Amrit Sarkar (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15892011#comment-15892011 ] Amrit Sarkar commented on SOLR-10153: - [~dsmiley] LUCENE-7729 has incorporated string type separator

[jira] [Commented] (SOLR-10153) UnifiedSolrHighlighter support for CustomSeparatorBreakIterator (LUCENE-6485)

2017-03-01 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891480#comment-15891480 ] ASF subversion and git services commented on SOLR-10153: Commit

[jira] [Commented] (SOLR-10153) UnifiedSolrHighlighter support for CustomSeparatorBreakIterator (LUCENE-6485)

2017-03-01 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891477#comment-15891477 ] ASF subversion and git services commented on SOLR-10153: Commit

[jira] [Commented] (SOLR-10153) UnifiedSolrHighlighter support for CustomSeparatorBreakIterator (LUCENE-6485)

2017-03-01 Thread Amrit Sarkar (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891270#comment-15891270 ] Amrit Sarkar commented on SOLR-10153: - It seems it was bigger pain for you refactoring everything than

[jira] [Commented] (SOLR-10153) UnifiedSolrHighlighter support for CustomSeparatorBreakIterator (LUCENE-6485)

2017-03-01 Thread Amrit Sarkar (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15890544#comment-15890544 ] Amrit Sarkar commented on SOLR-10153: - Alright :) Yes, +1 for the suggestion. I hate long worded

[jira] [Commented] (SOLR-10153) UnifiedSolrHighlighter support for CustomSeparatorBreakIterator (LUCENE-6485)

2017-03-01 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15890402#comment-15890402 ] David Smiley commented on SOLR-10153: - It's okay; I think _all_ software developers struggle with

[jira] [Commented] (SOLR-10153) UnifiedSolrHighlighter support for CustomSeparatorBreakIterator (LUCENE-6485)

2017-03-01 Thread Amrit Sarkar (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15890303#comment-15890303 ] Amrit Sarkar commented on SOLR-10153: - Elegant. I struggle with naming conventions and this make much

[jira] [Commented] (SOLR-10153) UnifiedSolrHighlighter support for CustomSeparatorBreakIterator (LUCENE-6485)

2017-03-01 Thread Amrit Sarkar (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15889717#comment-15889717 ] Amrit Sarkar commented on SOLR-10153: - Just a follow up David, Are we planning to include this

[jira] [Commented] (SOLR-10153) UnifiedSolrHighlighter support for CustomSeparatorBreakIterator (LUCENE-6485)

2017-02-21 Thread Amrit Sarkar (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15876884#comment-15876884 ] Amrit Sarkar commented on SOLR-10153: - Mr. Smiley, Thank you for the feedback and glad you found the

[jira] [Commented] (SOLR-10153) UnifiedSolrHighlighter support for CustomSeparatorBreakIterator (LUCENE-6485)

2017-02-21 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15876724#comment-15876724 ] David Smiley commented on SOLR-10153: - Hello Amrit; thanks for contributing this. Why the change of

[jira] [Commented] (SOLR-10153) UnifiedSolrHighlighter support for CustomSeparatorBreakIterator (LUCENE-6485)

2017-02-18 Thread Amrit Sarkar (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15873056#comment-15873056 ] Amrit Sarkar commented on SOLR-10153: - SOLR-10152.patch uploaded which incorporates