[jira] [Commented] (SOLR-10190) Potential NPE in CloudSolrClient when reading stale alias
[ https://issues.apache.org/jira/browse/SOLR-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15883909#comment-15883909 ] ASF subversion and git services commented on SOLR-10190: Commit 2d63916b70f2853787b545eda6681e64a2c2e352 in lucene-solr's branch refs/heads/branch_6_4 from Tomas Fernandez Lobbe [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=2d63916 ] SOLR-10190: Fix NPE in CloudSolrClient when reading stale alias This closes #160 > Potential NPE in CloudSolrClient when reading stale alias > - > > Key: SOLR-10190 > URL: https://issues.apache.org/jira/browse/SOLR-10190 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: clients - java, SolrJ >Affects Versions: 5.5, 6.x, master (7.0) >Reporter: Janosch Woschitz >Assignee: Tomás Fernández Löbbe > > The CloudSolrClient raises a NullPointerException when CloudSolrClient::add > is invoked and pointed to an alias which references a collection which does > not exist anymore. > {code} > java.lang.NullPointerException > at __randomizedtesting.SeedInfo.seed([1D00539A964E5C5D:D7D145363AD5CCA]:0) > at > org.apache.solr.client.solrj.impl.CloudSolrClient.requestWithRetryOnStaleState(CloudSolrClient.java:1078) > at > org.apache.solr.client.solrj.impl.CloudSolrClient.request(CloudSolrClient.java:1042) > at org.apache.solr.client.solrj.SolrRequest.process(SolrRequest.java:160) > at org.apache.solr.client.solrj.SolrClient.add(SolrClient.java:106) > at org.apache.solr.client.solrj.SolrClient.add(SolrClient.java:71) > at org.apache.solr.client.solrj.SolrClient.add(SolrClient.java:85) > {code} > This is a rather unexpected since the CloudSolrClient usually raises a > SolrException containing a descriptive error message (e.g. "Collection not > found: xyz") when a collection cannot be resolved. > In general this error condition could be triggered also by other edge cases > since CloudSolrClient::getDocCollection might return null but the code > following that invocation is not guarded against null values. > {code} > // track the version of state we're using on the client side using > the _stateVer_ param > DocCollection coll = getDocCollection(requestedCollection, null); > int collVer = coll.getZNodeVersion(); > {code} -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-10190) Potential NPE in CloudSolrClient when reading stale alias
[ https://issues.apache.org/jira/browse/SOLR-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15883910#comment-15883910 ] ASF subversion and git services commented on SOLR-10190: Commit 900367912f2e75c3171fcf64a8b73fd5e11f6098 in lucene-solr's branch refs/heads/branch_6_4 from Tomas Fernandez Lobbe [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=9003679 ] SOLR-10190: Fixed assert message > Potential NPE in CloudSolrClient when reading stale alias > - > > Key: SOLR-10190 > URL: https://issues.apache.org/jira/browse/SOLR-10190 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: clients - java, SolrJ >Affects Versions: 5.5, 6.x, master (7.0) >Reporter: Janosch Woschitz >Assignee: Tomás Fernández Löbbe > > The CloudSolrClient raises a NullPointerException when CloudSolrClient::add > is invoked and pointed to an alias which references a collection which does > not exist anymore. > {code} > java.lang.NullPointerException > at __randomizedtesting.SeedInfo.seed([1D00539A964E5C5D:D7D145363AD5CCA]:0) > at > org.apache.solr.client.solrj.impl.CloudSolrClient.requestWithRetryOnStaleState(CloudSolrClient.java:1078) > at > org.apache.solr.client.solrj.impl.CloudSolrClient.request(CloudSolrClient.java:1042) > at org.apache.solr.client.solrj.SolrRequest.process(SolrRequest.java:160) > at org.apache.solr.client.solrj.SolrClient.add(SolrClient.java:106) > at org.apache.solr.client.solrj.SolrClient.add(SolrClient.java:71) > at org.apache.solr.client.solrj.SolrClient.add(SolrClient.java:85) > {code} > This is a rather unexpected since the CloudSolrClient usually raises a > SolrException containing a descriptive error message (e.g. "Collection not > found: xyz") when a collection cannot be resolved. > In general this error condition could be triggered also by other edge cases > since CloudSolrClient::getDocCollection might return null but the code > following that invocation is not guarded against null values. > {code} > // track the version of state we're using on the client side using > the _stateVer_ param > DocCollection coll = getDocCollection(requestedCollection, null); > int collVer = coll.getZNodeVersion(); > {code} -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-10190) Potential NPE in CloudSolrClient when reading stale alias
[ https://issues.apache.org/jira/browse/SOLR-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15883906#comment-15883906 ] ASF subversion and git services commented on SOLR-10190: Commit f9d9ff94cf3863fdc9189ad3363c71662200ab58 in lucene-solr's branch refs/heads/branch_6x from Tomas Fernandez Lobbe [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=f9d9ff9 ] SOLR-10190: Fix NPE in CloudSolrClient when reading stale alias This closes #160 > Potential NPE in CloudSolrClient when reading stale alias > - > > Key: SOLR-10190 > URL: https://issues.apache.org/jira/browse/SOLR-10190 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: clients - java, SolrJ >Affects Versions: 5.5, 6.x, master (7.0) >Reporter: Janosch Woschitz >Assignee: Tomás Fernández Löbbe > > The CloudSolrClient raises a NullPointerException when CloudSolrClient::add > is invoked and pointed to an alias which references a collection which does > not exist anymore. > {code} > java.lang.NullPointerException > at __randomizedtesting.SeedInfo.seed([1D00539A964E5C5D:D7D145363AD5CCA]:0) > at > org.apache.solr.client.solrj.impl.CloudSolrClient.requestWithRetryOnStaleState(CloudSolrClient.java:1078) > at > org.apache.solr.client.solrj.impl.CloudSolrClient.request(CloudSolrClient.java:1042) > at org.apache.solr.client.solrj.SolrRequest.process(SolrRequest.java:160) > at org.apache.solr.client.solrj.SolrClient.add(SolrClient.java:106) > at org.apache.solr.client.solrj.SolrClient.add(SolrClient.java:71) > at org.apache.solr.client.solrj.SolrClient.add(SolrClient.java:85) > {code} > This is a rather unexpected since the CloudSolrClient usually raises a > SolrException containing a descriptive error message (e.g. "Collection not > found: xyz") when a collection cannot be resolved. > In general this error condition could be triggered also by other edge cases > since CloudSolrClient::getDocCollection might return null but the code > following that invocation is not guarded against null values. > {code} > // track the version of state we're using on the client side using > the _stateVer_ param > DocCollection coll = getDocCollection(requestedCollection, null); > int collVer = coll.getZNodeVersion(); > {code} -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-10190) Potential NPE in CloudSolrClient when reading stale alias
[ https://issues.apache.org/jira/browse/SOLR-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15883907#comment-15883907 ] ASF subversion and git services commented on SOLR-10190: Commit 1b91349fcd29afb931ea77299ac47a7c783b1532 in lucene-solr's branch refs/heads/branch_6x from Tomas Fernandez Lobbe [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=1b91349 ] SOLR-10190: Fixed assert message > Potential NPE in CloudSolrClient when reading stale alias > - > > Key: SOLR-10190 > URL: https://issues.apache.org/jira/browse/SOLR-10190 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: clients - java, SolrJ >Affects Versions: 5.5, 6.x, master (7.0) >Reporter: Janosch Woschitz >Assignee: Tomás Fernández Löbbe > > The CloudSolrClient raises a NullPointerException when CloudSolrClient::add > is invoked and pointed to an alias which references a collection which does > not exist anymore. > {code} > java.lang.NullPointerException > at __randomizedtesting.SeedInfo.seed([1D00539A964E5C5D:D7D145363AD5CCA]:0) > at > org.apache.solr.client.solrj.impl.CloudSolrClient.requestWithRetryOnStaleState(CloudSolrClient.java:1078) > at > org.apache.solr.client.solrj.impl.CloudSolrClient.request(CloudSolrClient.java:1042) > at org.apache.solr.client.solrj.SolrRequest.process(SolrRequest.java:160) > at org.apache.solr.client.solrj.SolrClient.add(SolrClient.java:106) > at org.apache.solr.client.solrj.SolrClient.add(SolrClient.java:71) > at org.apache.solr.client.solrj.SolrClient.add(SolrClient.java:85) > {code} > This is a rather unexpected since the CloudSolrClient usually raises a > SolrException containing a descriptive error message (e.g. "Collection not > found: xyz") when a collection cannot be resolved. > In general this error condition could be triggered also by other edge cases > since CloudSolrClient::getDocCollection might return null but the code > following that invocation is not guarded against null values. > {code} > // track the version of state we're using on the client side using > the _stateVer_ param > DocCollection coll = getDocCollection(requestedCollection, null); > int collVer = coll.getZNodeVersion(); > {code} -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-10190) Potential NPE in CloudSolrClient when reading stale alias
[ https://issues.apache.org/jira/browse/SOLR-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15883904#comment-15883904 ] ASF subversion and git services commented on SOLR-10190: Commit 99e8ef2304b67712d45a2393e649c5319aaac972 in lucene-solr's branch refs/heads/master from Tomas Fernandez Lobbe [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=99e8ef2 ] SOLR-10190: Fixed assert message > Potential NPE in CloudSolrClient when reading stale alias > - > > Key: SOLR-10190 > URL: https://issues.apache.org/jira/browse/SOLR-10190 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: clients - java, SolrJ >Affects Versions: 5.5, 6.x, master (7.0) >Reporter: Janosch Woschitz >Assignee: Tomás Fernández Löbbe > > The CloudSolrClient raises a NullPointerException when CloudSolrClient::add > is invoked and pointed to an alias which references a collection which does > not exist anymore. > {code} > java.lang.NullPointerException > at __randomizedtesting.SeedInfo.seed([1D00539A964E5C5D:D7D145363AD5CCA]:0) > at > org.apache.solr.client.solrj.impl.CloudSolrClient.requestWithRetryOnStaleState(CloudSolrClient.java:1078) > at > org.apache.solr.client.solrj.impl.CloudSolrClient.request(CloudSolrClient.java:1042) > at org.apache.solr.client.solrj.SolrRequest.process(SolrRequest.java:160) > at org.apache.solr.client.solrj.SolrClient.add(SolrClient.java:106) > at org.apache.solr.client.solrj.SolrClient.add(SolrClient.java:71) > at org.apache.solr.client.solrj.SolrClient.add(SolrClient.java:85) > {code} > This is a rather unexpected since the CloudSolrClient usually raises a > SolrException containing a descriptive error message (e.g. "Collection not > found: xyz") when a collection cannot be resolved. > In general this error condition could be triggered also by other edge cases > since CloudSolrClient::getDocCollection might return null but the code > following that invocation is not guarded against null values. > {code} > // track the version of state we're using on the client side using > the _stateVer_ param > DocCollection coll = getDocCollection(requestedCollection, null); > int collVer = coll.getZNodeVersion(); > {code} -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-10190) Potential NPE in CloudSolrClient when reading stale alias
[ https://issues.apache.org/jira/browse/SOLR-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15883900#comment-15883900 ] ASF GitHub Bot commented on SOLR-10190: --- Github user asfgit closed the pull request at: https://github.com/apache/lucene-solr/pull/160 > Potential NPE in CloudSolrClient when reading stale alias > - > > Key: SOLR-10190 > URL: https://issues.apache.org/jira/browse/SOLR-10190 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: clients - java, SolrJ >Affects Versions: 5.5, 6.x, master (7.0) >Reporter: Janosch Woschitz >Assignee: Tomás Fernández Löbbe > > The CloudSolrClient raises a NullPointerException when CloudSolrClient::add > is invoked and pointed to an alias which references a collection which does > not exist anymore. > {code} > java.lang.NullPointerException > at __randomizedtesting.SeedInfo.seed([1D00539A964E5C5D:D7D145363AD5CCA]:0) > at > org.apache.solr.client.solrj.impl.CloudSolrClient.requestWithRetryOnStaleState(CloudSolrClient.java:1078) > at > org.apache.solr.client.solrj.impl.CloudSolrClient.request(CloudSolrClient.java:1042) > at org.apache.solr.client.solrj.SolrRequest.process(SolrRequest.java:160) > at org.apache.solr.client.solrj.SolrClient.add(SolrClient.java:106) > at org.apache.solr.client.solrj.SolrClient.add(SolrClient.java:71) > at org.apache.solr.client.solrj.SolrClient.add(SolrClient.java:85) > {code} > This is a rather unexpected since the CloudSolrClient usually raises a > SolrException containing a descriptive error message (e.g. "Collection not > found: xyz") when a collection cannot be resolved. > In general this error condition could be triggered also by other edge cases > since CloudSolrClient::getDocCollection might return null but the code > following that invocation is not guarded against null values. > {code} > // track the version of state we're using on the client side using > the _stateVer_ param > DocCollection coll = getDocCollection(requestedCollection, null); > int collVer = coll.getZNodeVersion(); > {code} -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-10190) Potential NPE in CloudSolrClient when reading stale alias
[ https://issues.apache.org/jira/browse/SOLR-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15883897#comment-15883897 ] ASF subversion and git services commented on SOLR-10190: Commit 39887b86297e36785607f57cfd0e785bcae3c61a in lucene-solr's branch refs/heads/master from Tomas Fernandez Lobbe [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=39887b8 ] SOLR-10190: Fix NPE in CloudSolrClient when reading stale alias This closes #160 > Potential NPE in CloudSolrClient when reading stale alias > - > > Key: SOLR-10190 > URL: https://issues.apache.org/jira/browse/SOLR-10190 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: clients - java, SolrJ >Affects Versions: 5.5, 6.x, master (7.0) >Reporter: Janosch Woschitz >Assignee: Tomás Fernández Löbbe > > The CloudSolrClient raises a NullPointerException when CloudSolrClient::add > is invoked and pointed to an alias which references a collection which does > not exist anymore. > {code} > java.lang.NullPointerException > at __randomizedtesting.SeedInfo.seed([1D00539A964E5C5D:D7D145363AD5CCA]:0) > at > org.apache.solr.client.solrj.impl.CloudSolrClient.requestWithRetryOnStaleState(CloudSolrClient.java:1078) > at > org.apache.solr.client.solrj.impl.CloudSolrClient.request(CloudSolrClient.java:1042) > at org.apache.solr.client.solrj.SolrRequest.process(SolrRequest.java:160) > at org.apache.solr.client.solrj.SolrClient.add(SolrClient.java:106) > at org.apache.solr.client.solrj.SolrClient.add(SolrClient.java:71) > at org.apache.solr.client.solrj.SolrClient.add(SolrClient.java:85) > {code} > This is a rather unexpected since the CloudSolrClient usually raises a > SolrException containing a descriptive error message (e.g. "Collection not > found: xyz") when a collection cannot be resolved. > In general this error condition could be triggered also by other edge cases > since CloudSolrClient::getDocCollection might return null but the code > following that invocation is not guarded against null values. > {code} > // track the version of state we're using on the client side using > the _stateVer_ param > DocCollection coll = getDocCollection(requestedCollection, null); > int collVer = coll.getZNodeVersion(); > {code} -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-10190) Potential NPE in CloudSolrClient when reading stale alias
[ https://issues.apache.org/jira/browse/SOLR-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15878808#comment-15878808 ] Tomás Fernández Löbbe commented on SOLR-10190: -- I've seen this too. PR looks good > Potential NPE in CloudSolrClient when reading stale alias > - > > Key: SOLR-10190 > URL: https://issues.apache.org/jira/browse/SOLR-10190 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: clients - java, SolrJ >Affects Versions: 5.5, 6.x, master (7.0) >Reporter: Janosch Woschitz >Assignee: Tomás Fernández Löbbe > > The CloudSolrClient raises a NullPointerException when CloudSolrClient::add > is invoked and pointed to an alias which references a collection which does > not exist anymore. > {code} > java.lang.NullPointerException > at __randomizedtesting.SeedInfo.seed([1D00539A964E5C5D:D7D145363AD5CCA]:0) > at > org.apache.solr.client.solrj.impl.CloudSolrClient.requestWithRetryOnStaleState(CloudSolrClient.java:1078) > at > org.apache.solr.client.solrj.impl.CloudSolrClient.request(CloudSolrClient.java:1042) > at org.apache.solr.client.solrj.SolrRequest.process(SolrRequest.java:160) > at org.apache.solr.client.solrj.SolrClient.add(SolrClient.java:106) > at org.apache.solr.client.solrj.SolrClient.add(SolrClient.java:71) > at org.apache.solr.client.solrj.SolrClient.add(SolrClient.java:85) > {code} > This is a rather unexpected since the CloudSolrClient usually raises a > SolrException containing a descriptive error message (e.g. "Collection not > found: xyz") when a collection cannot be resolved. > In general this error condition could be triggered also by other edge cases > since CloudSolrClient::getDocCollection might return null but the code > following that invocation is not guarded against null values. > {code} > // track the version of state we're using on the client side using > the _stateVer_ param > DocCollection coll = getDocCollection(requestedCollection, null); > int collVer = coll.getZNodeVersion(); > {code} -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-10190) Potential NPE in CloudSolrClient when reading stale alias
[ https://issues.apache.org/jira/browse/SOLR-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15878478#comment-15878478 ] ASF GitHub Bot commented on SOLR-10190: --- GitHub user jwoschitz opened a pull request: https://github.com/apache/lucene-solr/pull/160 SOLR-10190 - Potential NPE in CloudSolrClient when reading stale alias Added a test case and potential solution to guard against NPE, see JIRA issue https://issues.apache.org/jira/browse/SOLR-10190 You can merge this pull request into a Git repository by running: $ git pull https://github.com/jwoschitz/lucene-solr jira/solr-10190 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/lucene-solr/pull/160.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #160 commit ee8409b2cf5b983211854a289b58f82d3775da4a Author: Janosch WoschitzDate: 2017-02-22T15:26:29Z SOLR-10190 - Added a test case and potential solution to guard against NPE in CloudSolrClient > Potential NPE in CloudSolrClient when reading stale alias > - > > Key: SOLR-10190 > URL: https://issues.apache.org/jira/browse/SOLR-10190 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: clients - java, SolrJ >Affects Versions: 5.5, 6.x, master (7.0) >Reporter: Janosch Woschitz > > The CloudSolrClient raises a NullPointerException when CloudSolrClient::add > is invoked and pointed to an alias which references a collection which does > not exist anymore. > {code} > java.lang.NullPointerException > at __randomizedtesting.SeedInfo.seed([1D00539A964E5C5D:D7D145363AD5CCA]:0) > at > org.apache.solr.client.solrj.impl.CloudSolrClient.requestWithRetryOnStaleState(CloudSolrClient.java:1078) > at > org.apache.solr.client.solrj.impl.CloudSolrClient.request(CloudSolrClient.java:1042) > at org.apache.solr.client.solrj.SolrRequest.process(SolrRequest.java:160) > at org.apache.solr.client.solrj.SolrClient.add(SolrClient.java:106) > at org.apache.solr.client.solrj.SolrClient.add(SolrClient.java:71) > at org.apache.solr.client.solrj.SolrClient.add(SolrClient.java:85) > {code} > This is a rather unexpected since the CloudSolrClient usually raises a > SolrException containing a descriptive error message (e.g. "Collection not > found: xyz") when a collection cannot be resolved. > In general this error condition could be triggered also by other edge cases > since CloudSolrClient::getDocCollection might return null but the code > following that invocation is not guarded against null values. > {code} > // track the version of state we're using on the client side using > the _stateVer_ param > DocCollection coll = getDocCollection(requestedCollection, null); > int collVer = coll.getZNodeVersion(); > {code} -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org