[jira] [Commented] (SOLR-11731) LatLonPointSpatialField could be improved to return the lat/lon from docValues
[ https://issues.apache.org/jira/browse/SOLR-11731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16438379#comment-16438379 ] David Smiley commented on SOLR-11731: - Sorry I had run one test a bunch of times but forgot about the whole suite, thus Jenkins failed. As explained in the commit message, we're back at 7 decimal places now so that we can retain the desirable property that a number provided with <= 7 decimal places will round-trip (i.e. will be returned in the same precision as given). For example, this keeps 40 as-such instead of 39.9997. This is accurate to ~1.37 cm or so. The theoretical 1.04cm is still possible in terms of the underlying sorting and if you gave the data in that level of accuracy (8 decimal places or more) being accurate to that but when retrieved it's only to 1.37cm accuracy. > LatLonPointSpatialField could be improved to return the lat/lon from docValues > -- > > Key: SOLR-11731 > URL: https://issues.apache.org/jira/browse/SOLR-11731 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: spatial >Reporter: David Smiley >Assignee: David Smiley >Priority: Minor > Fix For: 7.4 > > Attachments: SOLR-11731.patch, SOLR-11731.patch, SOLR-11731.patch > > Time Spent: 4.5h > Remaining Estimate: 0h > > You can only return the lat & lon from a LatLonPointSpatialField if you set > stored=true. But we could allow this (albeit at a small loss in precision) > if stored=false and docValues=true. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11731) LatLonPointSpatialField could be improved to return the lat/lon from docValues
[ https://issues.apache.org/jira/browse/SOLR-11731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16438375#comment-16438375 ] ASF subversion and git services commented on SOLR-11731: Commit 892b4bb6b0dd6e16d31d9f54f0e978d6d78a6091 in lucene-solr's branch refs/heads/branch_7x from [~dsmiley] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=892b4bb ] SOLR-11731: revert to 7 decimal places so we can maintain the round-trip property. Add test that we round-trip random numbers at 7 decimal places. Would fail at 8. (cherry picked from commit dad2d10) > LatLonPointSpatialField could be improved to return the lat/lon from docValues > -- > > Key: SOLR-11731 > URL: https://issues.apache.org/jira/browse/SOLR-11731 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: spatial >Reporter: David Smiley >Assignee: David Smiley >Priority: Minor > Fix For: 7.4 > > Attachments: SOLR-11731.patch, SOLR-11731.patch, SOLR-11731.patch > > Time Spent: 4.5h > Remaining Estimate: 0h > > You can only return the lat & lon from a LatLonPointSpatialField if you set > stored=true. But we could allow this (albeit at a small loss in precision) > if stored=false and docValues=true. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11731) LatLonPointSpatialField could be improved to return the lat/lon from docValues
[ https://issues.apache.org/jira/browse/SOLR-11731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16438374#comment-16438374 ] ASF subversion and git services commented on SOLR-11731: Commit dad2d1076db632535c33fa118eb851ad7d0e2537 in lucene-solr's branch refs/heads/master from [~dsmiley] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=dad2d10 ] SOLR-11731: revert to 7 decimal places so we can maintain the round-trip property. Add test that we round-trip random numbers at 7 decimal places. Would fail at 8. > LatLonPointSpatialField could be improved to return the lat/lon from docValues > -- > > Key: SOLR-11731 > URL: https://issues.apache.org/jira/browse/SOLR-11731 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: spatial >Reporter: David Smiley >Assignee: David Smiley >Priority: Minor > Fix For: 7.4 > > Attachments: SOLR-11731.patch, SOLR-11731.patch, SOLR-11731.patch > > Time Spent: 4.5h > Remaining Estimate: 0h > > You can only return the lat & lon from a LatLonPointSpatialField if you set > stored=true. But we could allow this (albeit at a small loss in precision) > if stored=false and docValues=true. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11731) LatLonPointSpatialField could be improved to return the lat/lon from docValues
[ https://issues.apache.org/jira/browse/SOLR-11731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16437914#comment-16437914 ] ASF subversion and git services commented on SOLR-11731: Commit 6f693ce7f1d57ec8581bd37b1a9a3f3a2abb626d in lucene-solr's branch refs/heads/branch_7x from [~dsmiley] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=6f693ce ] SOLR-11731: one more decimal place (8) and we get the target/theoretical precision (cherry picked from commit e4eb8a8) > LatLonPointSpatialField could be improved to return the lat/lon from docValues > -- > > Key: SOLR-11731 > URL: https://issues.apache.org/jira/browse/SOLR-11731 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: spatial >Reporter: David Smiley >Assignee: David Smiley >Priority: Minor > Fix For: 7.4 > > Attachments: SOLR-11731.patch, SOLR-11731.patch, SOLR-11731.patch > > Time Spent: 4.5h > Remaining Estimate: 0h > > You can only return the lat & lon from a LatLonPointSpatialField if you set > stored=true. But we could allow this (albeit at a small loss in precision) > if stored=false and docValues=true. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11731) LatLonPointSpatialField could be improved to return the lat/lon from docValues
[ https://issues.apache.org/jira/browse/SOLR-11731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16437912#comment-16437912 ] ASF subversion and git services commented on SOLR-11731: Commit e4eb8a870c342b49c8f0a0864d34617cac1deb0f in lucene-solr's branch refs/heads/master from [~dsmiley] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=e4eb8a8 ] SOLR-11731: one more decimal place (8) and we get the target/theoretical precision > LatLonPointSpatialField could be improved to return the lat/lon from docValues > -- > > Key: SOLR-11731 > URL: https://issues.apache.org/jira/browse/SOLR-11731 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: spatial >Reporter: David Smiley >Assignee: David Smiley >Priority: Minor > Fix For: 7.4 > > Attachments: SOLR-11731.patch, SOLR-11731.patch, SOLR-11731.patch > > Time Spent: 4.5h > Remaining Estimate: 0h > > You can only return the lat & lon from a LatLonPointSpatialField if you set > stored=true. But we could allow this (albeit at a small loss in precision) > if stored=false and docValues=true. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11731) LatLonPointSpatialField could be improved to return the lat/lon from docValues
[ https://issues.apache.org/jira/browse/SOLR-11731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16403526#comment-16403526 ] ASF subversion and git services commented on SOLR-11731: Commit 20d7d993f9abc0ca4ba898b3f5729cd103cc755b in lucene-solr's branch refs/heads/branch_7x from [~dsmiley] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=20d7d99 ] SOLR-11731: LatLonPointSpatialField now supports docValue retrieval Closes #323 (cherry picked from commit 4b08efc) > LatLonPointSpatialField could be improved to return the lat/lon from docValues > -- > > Key: SOLR-11731 > URL: https://issues.apache.org/jira/browse/SOLR-11731 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: spatial >Reporter: David Smiley >Assignee: David Smiley >Priority: Minor > Attachments: SOLR-11731.patch, SOLR-11731.patch, SOLR-11731.patch > > Time Spent: 4.5h > Remaining Estimate: 0h > > You can only return the lat & lon from a LatLonPointSpatialField if you set > stored=true. But we could allow this (albeit at a small loss in precision) > if stored=false and docValues=true. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11731) LatLonPointSpatialField could be improved to return the lat/lon from docValues
[ https://issues.apache.org/jira/browse/SOLR-11731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16403523#comment-16403523 ] ASF subversion and git services commented on SOLR-11731: Commit 4b08efcf1c13cee0524777955f1ff7473506f58f in lucene-solr's branch refs/heads/master from [~dsmiley] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=4b08efc ] SOLR-11731: LatLonPointSpatialField now supports docValue retrieval Closes #323 > LatLonPointSpatialField could be improved to return the lat/lon from docValues > -- > > Key: SOLR-11731 > URL: https://issues.apache.org/jira/browse/SOLR-11731 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: spatial >Reporter: David Smiley >Assignee: David Smiley >Priority: Minor > Attachments: SOLR-11731.patch, SOLR-11731.patch, SOLR-11731.patch > > Time Spent: 4h 20m > Remaining Estimate: 0h > > You can only return the lat & lon from a LatLonPointSpatialField if you set > stored=true. But we could allow this (albeit at a small loss in precision) > if stored=false and docValues=true. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11731) LatLonPointSpatialField could be improved to return the lat/lon from docValues
[ https://issues.apache.org/jira/browse/SOLR-11731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16403114#comment-16403114 ] Karthik Ramachandran commented on SOLR-11731: - Looks good to me. [~dsmiley] Thanks for making changes to test. > LatLonPointSpatialField could be improved to return the lat/lon from docValues > -- > > Key: SOLR-11731 > URL: https://issues.apache.org/jira/browse/SOLR-11731 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: spatial >Reporter: David Smiley >Assignee: David Smiley >Priority: Minor > Attachments: SOLR-11731.patch, SOLR-11731.patch, SOLR-11731.patch > > Time Spent: 4h 20m > Remaining Estimate: 0h > > You can only return the lat & lon from a LatLonPointSpatialField if you set > stored=true. But we could allow this (albeit at a small loss in precision) > if stored=false and docValues=true. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11731) LatLonPointSpatialField could be improved to return the lat/lon from docValues
[ https://issues.apache.org/jira/browse/SOLR-11731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16402457#comment-16402457 ] David Smiley commented on SOLR-11731: - Thanks for offering a great starting point. I worked on it further significantly, esp. with testing. * Improved testing: ** test round-trip more methodically using a RetrievalCombo class/struct to hold index & return value ** new testLLPDecodeIsStableAndPrecise to test that the result is stable (can be re-indexed to get the same value), and that it's precise (< 1.3 cm) * Adjusted to BigDecimal setScale(7,CEILING) as comments indicate why. * Ensured we only wrap in an array when the field is multiValued. WDYT? > LatLonPointSpatialField could be improved to return the lat/lon from docValues > -- > > Key: SOLR-11731 > URL: https://issues.apache.org/jira/browse/SOLR-11731 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: spatial >Reporter: David Smiley >Assignee: David Smiley >Priority: Minor > Attachments: SOLR-11731.patch, SOLR-11731.patch, SOLR-11731.patch > > Time Spent: 4h 20m > Remaining Estimate: 0h > > You can only return the lat & lon from a LatLonPointSpatialField if you set > stored=true. But we could allow this (albeit at a small loss in precision) > if stored=false and docValues=true. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11731) LatLonPointSpatialField could be improved to return the lat/lon from docValues
[ https://issues.apache.org/jira/browse/SOLR-11731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16386381#comment-16386381 ] David Smiley commented on SOLR-11731: - I reviewed the PR. I think there may be more to do, maybe not strictly required but would be nice -- org.apache.solr.search.SolrDocumentFetcher#canSubstituteDvForStored that came about from SOLR-11532 > LatLonPointSpatialField could be improved to return the lat/lon from docValues > -- > > Key: SOLR-11731 > URL: https://issues.apache.org/jira/browse/SOLR-11731 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: spatial >Reporter: David Smiley >Priority: Minor > Attachments: SOLR-11731.patch > > Time Spent: 1h 10m > Remaining Estimate: 0h > > You can only return the lat & lon from a LatLonPointSpatialField if you set > stored=true. But we could allow this (albeit at a small loss in precision) > if stored=false and docValues=true. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11731) LatLonPointSpatialField could be improved to return the lat/lon from docValues
[ https://issues.apache.org/jira/browse/SOLR-11731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16363101#comment-16363101 ] Karthik Ramachandran commented on SOLR-11731: - Okay, Thanks! > LatLonPointSpatialField could be improved to return the lat/lon from docValues > -- > > Key: SOLR-11731 > URL: https://issues.apache.org/jira/browse/SOLR-11731 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: spatial >Reporter: David Smiley >Priority: Minor > Attachments: SOLR-11731.patch > > Time Spent: 10m > Remaining Estimate: 0h > > You can only return the lat & lon from a LatLonPointSpatialField if you set > stored=true. But we could allow this (albeit at a small loss in precision) > if stored=false and docValues=true. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11731) LatLonPointSpatialField could be improved to return the lat/lon from docValues
[ https://issues.apache.org/jira/browse/SOLR-11731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16363091#comment-16363091 ] David Smiley commented on SOLR-11731: - I will check this out after my vacation ending Feb 21st > LatLonPointSpatialField could be improved to return the lat/lon from docValues > -- > > Key: SOLR-11731 > URL: https://issues.apache.org/jira/browse/SOLR-11731 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: spatial >Reporter: David Smiley >Priority: Minor > Attachments: SOLR-11731.patch > > Time Spent: 10m > Remaining Estimate: 0h > > You can only return the lat & lon from a LatLonPointSpatialField if you set > stored=true. But we could allow this (albeit at a small loss in precision) > if stored=false and docValues=true. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
