[jira] [Commented] (SOLR-13140) Harden SearchRateTriggerIntegrationTest
[ https://issues.apache.org/jira/browse/SOLR-13140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16749032#comment-16749032 ] ASF subversion and git services commented on SOLR-13140: Commit 6882f43b96c6dc0fec7a1677d6687fa83f5a1669 in lucene-solr's branch refs/heads/branch_7x from Chris M. Hostetter [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=6882f43 ] SOLR-13140: harden SearchRateTriggerIntegrationTest by using more absolute rate thresholds and latches to track when all events have been processed so we don't need to 'guess' about sleep calls This commit also disables testDeleteNode pending an AwaitsFix on SOLR-13163 (cherry picked from commit 15e5ca999ff7e912653db897781b21642d5307f0) > Harden SearchRateTriggerIntegrationTest > --- > > Key: SOLR-13140 > URL: https://issues.apache.org/jira/browse/SOLR-13140 > Project: Solr > Issue Type: Sub-task > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Hoss Man >Assignee: Hoss Man >Priority: Major > Attachments: SOLR-13140.patch, SOLR-13140.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13140) Harden SearchRateTriggerIntegrationTest
[ https://issues.apache.org/jira/browse/SOLR-13140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16749015#comment-16749015 ] ASF subversion and git services commented on SOLR-13140: Commit 4d9c835376e9feb2ca7b9baa514c2306c5fa61c0 in lucene-solr's branch refs/heads/branch_8x from Chris M. Hostetter [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=4d9c835 ] SOLR-13140: harden SearchRateTriggerIntegrationTest by using more absolute rate thresholds and latches to track when all events have been processed so we don't need to 'guess' about sleep calls This commit also disables testDeleteNode pending an AwaitsFix on SOLR-13163 (cherry picked from commit 15e5ca999ff7e912653db897781b21642d5307f0) > Harden SearchRateTriggerIntegrationTest > --- > > Key: SOLR-13140 > URL: https://issues.apache.org/jira/browse/SOLR-13140 > Project: Solr > Issue Type: Sub-task > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Hoss Man >Assignee: Hoss Man >Priority: Major > Attachments: SOLR-13140.patch, SOLR-13140.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13140) Harden SearchRateTriggerIntegrationTest
[ https://issues.apache.org/jira/browse/SOLR-13140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16748999#comment-16748999 ] ASF subversion and git services commented on SOLR-13140: Commit 15e5ca999ff7e912653db897781b21642d5307f0 in lucene-solr's branch refs/heads/master from Chris M. Hostetter [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=15e5ca9 ] SOLR-13140: harden SearchRateTriggerIntegrationTest by using more absolute rate thresholds and latches to track when all events have been processed so we don't need to 'guess' about sleep calls This commit also disables testDeleteNode pending an AwaitsFix on SOLR-13163 > Harden SearchRateTriggerIntegrationTest > --- > > Key: SOLR-13140 > URL: https://issues.apache.org/jira/browse/SOLR-13140 > Project: Solr > Issue Type: Sub-task > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Hoss Man >Assignee: Hoss Man >Priority: Major > Attachments: SOLR-13140.patch, SOLR-13140.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13140) Harden SearchRateTriggerIntegrationTest
[ https://issues.apache.org/jira/browse/SOLR-13140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16748977#comment-16748977 ] Andrzej Bialecki commented on SOLR-13140: -- Sounds good, thanks Hoss! > Harden SearchRateTriggerIntegrationTest > --- > > Key: SOLR-13140 > URL: https://issues.apache.org/jira/browse/SOLR-13140 > Project: Solr > Issue Type: Sub-task > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Hoss Man >Assignee: Hoss Man >Priority: Major > Attachments: SOLR-13140.patch, SOLR-13140.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13140) Harden SearchRateTriggerIntegrationTest
[
https://issues.apache.org/jira/browse/SOLR-13140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16748975#comment-16748975
]
Hoss Man commented on SOLR-13140:
-
I've spun off the issues with DELETENODE into SOLR-13163.
I'll go ahead and:
* mark the {{testDeleteNode}} as @AwaitsFix on that jira
** add additional comments with some details
* commit & backport the rest of the improvements here.
> Harden SearchRateTriggerIntegrationTest
> ---
>
> Key: SOLR-13140
> URL: https://issues.apache.org/jira/browse/SOLR-13140
> Project: Solr
> Issue Type: Sub-task
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: Hoss Man
>Assignee: Hoss Man
>Priority: Major
> Attachments: SOLR-13140.patch, SOLR-13140.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13140) Harden SearchRateTriggerIntegrationTest
[
https://issues.apache.org/jira/browse/SOLR-13140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16744887#comment-16744887
]
Andrzej Bialecki commented on SOLR-13140:
--
bq. ... can you please clarify what you mean by "a (currently unsupported)
DELETENODE request" ?
Sorry, please ignore that part - I mixed this up with another operation. This
is definitely supported (via {{DeleteNodeSuggester}}.
bq. Unless the underlying Collections API impl of DELETENODE is smart enough
not to shutdown a leader (or the last remaining replica) this definitely seems
like a bug.
Correct, it's a bug - {{SearchRateTrigger.calculateColdOps}} has a section at
the end when {{belowNodeOp != null}} and there it should protect leader nodes
from being deleted. There's also a non-javadoc comment there about the dangers
of this functionality, which is also mentioned in the Ref Guide (but perhaps
should be turned into a NOTE?).
> Harden SearchRateTriggerIntegrationTest
> ---
>
> Key: SOLR-13140
> URL: https://issues.apache.org/jira/browse/SOLR-13140
> Project: Solr
> Issue Type: Sub-task
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: Hoss Man
>Assignee: Hoss Man
>Priority: Major
> Attachments: SOLR-13140.patch, SOLR-13140.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-13140) Harden SearchRateTriggerIntegrationTest
[
https://issues.apache.org/jira/browse/SOLR-13140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16744468#comment-16744468
]
Andrzej Bialecki commented on SOLR-13140:
--
The internal traffic is between replicas and shard leader. This analysis makes
sense, and the patch looks good too - indeed, the idea of these tests is to
detect underutilized replicas and nodes, where search traffic falls below the
threshold.
Perhaps it would make sense to roll this method and {{testDeleteNode}} into
one, because it's basically the same as the other methods, only it verifies
that the trigger can generate a (currently unsupported) DELETENODE request in
response to the same condition.
> Harden SearchRateTriggerIntegrationTest
> ---
>
> Key: SOLR-13140
> URL: https://issues.apache.org/jira/browse/SOLR-13140
> Project: Solr
> Issue Type: Sub-task
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: Hoss Man
>Assignee: Hoss Man
>Priority: Major
> Attachments: SOLR-13140.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
