[
https://issues.apache.org/jira/browse/SOLR-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15352798#comment-15352798
]
ASF subversion and git services commented on SOLR-445:
--
Commit
[
https://issues.apache.org/jira/browse/SOLR-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15352790#comment-15352790
]
ASF GitHub Bot commented on SOLR-445:
-
Github user asfgit closed the pull request at:
[
https://issues.apache.org/jira/browse/SOLR-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15352788#comment-15352788
]
ASF subversion and git services commented on SOLR-445:
--
Commit
[
https://issues.apache.org/jira/browse/SOLR-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15327357#comment-15327357
]
ASF GitHub Bot commented on SOLR-445:
-
GitHub user arafalov opened a pull request:
[
https://issues.apache.org/jira/browse/SOLR-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15212418#comment-15212418
]
ASF subversion and git services commented on SOLR-445:
--
Commit
[
https://issues.apache.org/jira/browse/SOLR-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15212417#comment-15212417
]
ASF subversion and git services commented on SOLR-445:
--
Commit
[
https://issues.apache.org/jira/browse/SOLR-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15212415#comment-15212415
]
ASF subversion and git services commented on SOLR-445:
--
Commit
[
https://issues.apache.org/jira/browse/SOLR-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15212181#comment-15212181
]
ASF subversion and git services commented on SOLR-445:
--
Commit
[
https://issues.apache.org/jira/browse/SOLR-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15212179#comment-15212179
]
ASF subversion and git services commented on SOLR-445:
--
Commit
[
https://issues.apache.org/jira/browse/SOLR-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15210827#comment-15210827
]
Timothy Potter commented on SOLR-445:
-
LGTM +1 Nice test coverage of all this! This will be very useful
[
https://issues.apache.org/jira/browse/SOLR-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15210784#comment-15210784
]
Hoss Man commented on SOLR-445:
---
I'm still beasting the tests a bit, but i think this is pretty solid and
[
https://issues.apache.org/jira/browse/SOLR-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15210781#comment-15210781
]
ASF subversion and git services commented on SOLR-445:
--
Commit
[
https://issues.apache.org/jira/browse/SOLR-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15210779#comment-15210779
]
ASF subversion and git services commented on SOLR-445:
--
Commit
[
https://issues.apache.org/jira/browse/SOLR-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15210780#comment-15210780
]
ASF subversion and git services commented on SOLR-445:
--
Commit
[
https://issues.apache.org/jira/browse/SOLR-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15209462#comment-15209462
]
ASF subversion and git services commented on SOLR-445:
--
Commit
[
https://issues.apache.org/jira/browse/SOLR-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15209465#comment-15209465
]
ASF subversion and git services commented on SOLR-445:
--
Commit
[
https://issues.apache.org/jira/browse/SOLR-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15209467#comment-15209467
]
ASF subversion and git services commented on SOLR-445:
--
Commit
[
https://issues.apache.org/jira/browse/SOLR-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15209463#comment-15209463
]
ASF subversion and git services commented on SOLR-445:
--
Commit
[
https://issues.apache.org/jira/browse/SOLR-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15209461#comment-15209461
]
ASF subversion and git services commented on SOLR-445:
--
Commit
[
https://issues.apache.org/jira/browse/SOLR-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15206749#comment-15206749
]
Hoss Man commented on SOLR-445:
---
bq. What is the impact of many docs failing due to missing ID? Is there a
[
https://issues.apache.org/jira/browse/SOLR-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15206743#comment-15206743
]
ASF subversion and git services commented on SOLR-445:
--
Commit
[
https://issues.apache.org/jira/browse/SOLR-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15206741#comment-15206741
]
ASF subversion and git services commented on SOLR-445:
--
Commit
[
https://issues.apache.org/jira/browse/SOLR-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15206746#comment-15206746
]
ASF subversion and git services commented on SOLR-445:
--
Commit
[
https://issues.apache.org/jira/browse/SOLR-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15205787#comment-15205787
]
Tomás Fernández Löbbe commented on SOLR-445:
Looks really good to me.
What is the impact of many
[
https://issues.apache.org/jira/browse/SOLR-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15205503#comment-15205503
]
Anshum Gupta commented on SOLR-445:
---
Thanks Hoss.
I didn't look at the recent commits but from whatever I
[
https://issues.apache.org/jira/browse/SOLR-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15203598#comment-15203598
]
ASF subversion and git services commented on SOLR-445:
--
Commit
[
https://issues.apache.org/jira/browse/SOLR-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15203599#comment-15203599
]
ASF subversion and git services commented on SOLR-445:
--
Commit
[
https://issues.apache.org/jira/browse/SOLR-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15203594#comment-15203594
]
ASF subversion and git services commented on SOLR-445:
--
Commit
[
https://issues.apache.org/jira/browse/SOLR-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15203592#comment-15203592
]
ASF subversion and git services commented on SOLR-445:
--
Commit
[
https://issues.apache.org/jira/browse/SOLR-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15203596#comment-15203596
]
ASF subversion and git services commented on SOLR-445:
--
Commit
[
https://issues.apache.org/jira/browse/SOLR-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15203593#comment-15203593
]
ASF subversion and git services commented on SOLR-445:
--
Commit
[
https://issues.apache.org/jira/browse/SOLR-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15198396#comment-15198396
]
ASF subversion and git services commented on SOLR-445:
--
Commit
[
https://issues.apache.org/jira/browse/SOLR-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15196063#comment-15196063
]
Hoss Man commented on SOLR-445:
---
{{git diff master...jira/SOLR-445}} should be what you are looking for.
[
https://issues.apache.org/jira/browse/SOLR-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15196019#comment-15196019
]
Anshum Gupta commented on SOLR-445:
---
[~hossman] what's the best way to look at the diff here?
I tried the
[
https://issues.apache.org/jira/browse/SOLR-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15195859#comment-15195859
]
ASF subversion and git services commented on SOLR-445:
--
Commit
[
https://issues.apache.org/jira/browse/SOLR-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15194699#comment-15194699
]
David Smiley commented on SOLR-445:
---
The usage you explained looks nice Hoss! This will be very useful.
[
https://issues.apache.org/jira/browse/SOLR-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15194368#comment-15194368
]
Anshum Gupta commented on SOLR-445:
---
Thanks Hoss! I'll take a look at this tonight or tomorrow morning.
>
[
https://issues.apache.org/jira/browse/SOLR-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15194219#comment-15194219
]
Timothy Potter commented on SOLR-445:
-
digging into this now, thanks [~hossman]
> Update Handlers abort
[
https://issues.apache.org/jira/browse/SOLR-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15193606#comment-15193606
]
Hoss Man commented on SOLR-445:
---
(ment to post last friday but was blocked by the jira outage)
Ok ... i think
[
https://issues.apache.org/jira/browse/SOLR-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15174038#comment-15174038
]
ASF subversion and git services commented on SOLR-445:
--
Commit
[
https://issues.apache.org/jira/browse/SOLR-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15174039#comment-15174039
]
ASF subversion and git services commented on SOLR-445:
--
Commit
[
https://issues.apache.org/jira/browse/SOLR-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15166553#comment-15166553
]
ASF subversion and git services commented on SOLR-445:
--
Commit
[
https://issues.apache.org/jira/browse/SOLR-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15166555#comment-15166555
]
ASF subversion and git services commented on SOLR-445:
--
Commit
[
https://issues.apache.org/jira/browse/SOLR-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15166554#comment-15166554
]
ASF subversion and git services commented on SOLR-445:
--
Commit
[
https://issues.apache.org/jira/browse/SOLR-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15166551#comment-15166551
]
ASF subversion and git services commented on SOLR-445:
--
Commit
[
https://issues.apache.org/jira/browse/SOLR-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15166552#comment-15166552
]
ASF subversion and git services commented on SOLR-445:
--
Commit
[
https://issues.apache.org/jira/browse/SOLR-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15166549#comment-15166549
]
ASF subversion and git services commented on SOLR-445:
--
Commit
[
https://issues.apache.org/jira/browse/SOLR-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15166548#comment-15166548
]
ASF subversion and git services commented on SOLR-445:
--
Commit
[
https://issues.apache.org/jira/browse/SOLR-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15166556#comment-15166556
]
ASF subversion and git services commented on SOLR-445:
--
Commit
[
https://issues.apache.org/jira/browse/SOLR-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15155031#comment-15155031
]
Hoss Man commented on SOLR-445:
---
bq. Huh? What does SOLR-8633 have to do with calling setException?
Sorry,
[
https://issues.apache.org/jira/browse/SOLR-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15154793#comment-15154793
]
Mark Miller commented on SOLR-445:
--
Let's not get too pedantic about adding comments to help future devs
[
https://issues.apache.org/jira/browse/SOLR-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15154775#comment-15154775
]
Mark Miller commented on SOLR-445:
--
Huh? What does SOLR-8633 have to do with calling setException?
I'd say
[
https://issues.apache.org/jira/browse/SOLR-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15154647#comment-15154647
]
Hoss Man commented on SOLR-445:
---
bq. and the comment I mentioned above.
I still don't understand why that's
[
https://issues.apache.org/jira/browse/SOLR-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15154641#comment-15154641
]
Mark Miller commented on SOLR-445:
--
Pushed a branch of this patch with some minor cleanup I needed to
[
https://issues.apache.org/jira/browse/SOLR-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15154637#comment-15154637
]
ASF subversion and git services commented on SOLR-445:
--
Commit
[
https://issues.apache.org/jira/browse/SOLR-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15154638#comment-15154638
]
ASF subversion and git services commented on SOLR-445:
--
Commit
[
https://issues.apache.org/jira/browse/SOLR-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15154609#comment-15154609
]
Mark Miller commented on SOLR-445:
--
bq. I'm not sure what exactly it should say, but that seems orthogonal
[
https://issues.apache.org/jira/browse/SOLR-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15154525#comment-15154525
]
Yonik Seeley commented on SOLR-445:
---
bq. I'd also love to make this standard behavior and not some
[
https://issues.apache.org/jira/browse/SOLR-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15154493#comment-15154493
]
Hoss Man commented on SOLR-445:
---
bq. Can we document that on the setException method?
I'm not sure what
[
https://issues.apache.org/jira/browse/SOLR-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15154266#comment-15154266
]
Mark Miller commented on SOLR-445:
--
{code}
if ("LeaderChanged".equals(cause)) {
// let's just
[
https://issues.apache.org/jira/browse/SOLR-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15154253#comment-15154253
]
Mark Miller commented on SOLR-445:
--
{quote}
// nocommit: should this really be a top level exception?
//
[
https://issues.apache.org/jira/browse/SOLR-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15154226#comment-15154226
]
Mark Miller commented on SOLR-445:
--
I have no issue with punting numAdds on this.
> Update Handlers abort
[
https://issues.apache.org/jira/browse/SOLR-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15154220#comment-15154220
]
Mark Miller commented on SOLR-445:
--
bq. One notable change her is that i switched DUP.finish() from
[
https://issues.apache.org/jira/browse/SOLR-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15154210#comment-15154210
]
Mark Miller commented on SOLR-445:
--
Wow, I've never seen this old beast issue.
Goodness, with all this
[
https://issues.apache.org/jira/browse/SOLR-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14633103#comment-14633103
]
Anshum Gupta commented on SOLR-445:
---
I'm seeing a few errors with the current patch and I
[
https://issues.apache.org/jira/browse/SOLR-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14634464#comment-14634464
]
Noble Paul commented on SOLR-445:
-
I guess it would be better if we return the whole command
[
https://issues.apache.org/jira/browse/SOLR-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14269854#comment-14269854
]
Hoss Man commented on SOLR-445:
---
bq. It works only in the case of the update arriving to the
[
https://issues.apache.org/jira/browse/SOLR-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14113986#comment-14113986
]
Tomás Fernández Löbbe commented on SOLR-445:
[~shidunce] Sorry I missed your
[
https://issues.apache.org/jira/browse/SOLR-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14110647#comment-14110647
]
Denis Shishlyannikoc commented on SOLR-445:
---
Question related to this JIRA.
After
[
https://issues.apache.org/jira/browse/SOLR-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13982423#comment-13982423
]
Tomás Fernández Löbbe commented on SOLR-445:
bq. As a side note, this
[
https://issues.apache.org/jira/browse/SOLR-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13974536#comment-13974536
]
Tomás Fernández Löbbe commented on SOLR-445:
I uploaded a new patch with more
[
https://issues.apache.org/jira/browse/SOLR-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13974667#comment-13974667
]
Hoss Man commented on SOLR-445:
---
bq. I think this would make it more confusing. Having this
[
https://issues.apache.org/jira/browse/SOLR-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13968996#comment-13968996
]
Hoss Man commented on SOLR-445:
---
Tomas:
* we need better class level javadocs for the
[
https://issues.apache.org/jira/browse/SOLR-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13967726#comment-13967726
]
Tomás Fernández Löbbe commented on SOLR-445:
Any more thoughts on this patch?
[
https://issues.apache.org/jira/browse/SOLR-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13956720#comment-13956720
]
Hoss Man commented on SOLR-445:
---
bq. . The errors are managed by an UpdateRequestProcessor
[
https://issues.apache.org/jira/browse/SOLR-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13956748#comment-13956748
]
Yonik Seeley commented on SOLR-445:
---
bq. even if the schema doesn't use uniqueKey...
That
[
https://issues.apache.org/jira/browse/SOLR-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13956767#comment-13956767
]
Shalin Shekhar Mangar commented on SOLR-445:
bq. That would lead to some huge
[
https://issues.apache.org/jira/browse/SOLR-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13956790#comment-13956790
]
Tomás Fernández Löbbe commented on SOLR-445:
bq. I think instead the notion of
[
https://issues.apache.org/jira/browse/SOLR-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13956798#comment-13956798
]
Yonik Seeley commented on SOLR-445:
---
bq. Do you mean including the ids of good docs in the
[
https://issues.apache.org/jira/browse/SOLR-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13956848#comment-13956848
]
Tomás Fernández Löbbe commented on SOLR-445:
I see. Maybe I could add then just
[
https://issues.apache.org/jira/browse/SOLR-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13291055#comment-13291055
]
Yonik Seeley commented on SOLR-445:
---
I imagine a maxErrors parameter might be useful (and
[
https://issues.apache.org/jira/browse/SOLR-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13233357#comment-13233357
]
Erick Erickson commented on SOLR-445:
-
Well, it's clear I won't get to this in the 3.6
[
https://issues.apache.org/jira/browse/SOLR-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13042813#comment-13042813
]
Grant Ingersoll commented on SOLR-445:
--
Erick, feel free to take this one and iterate
[
https://issues.apache.org/jira/browse/SOLR-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13027545#comment-13027545
]
Shinichiro Abe commented on SOLR-445:
-
In Solr Cell, There is the same problem.
It
[
https://issues.apache.org/jira/browse/SOLR-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13027245#comment-13027245
]
Lance Norskog commented on SOLR-445:
If the DIH semantics cover all of the use cases,
85 matches
Mail list logo
