[jira] [Commented] (SOLR-4935) persisting solr.xml preserves extraneous values like wt=json in core tags when creating cores via the admin handler
[ https://issues.apache.org/jira/browse/SOLR-4935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13690532#comment-13690532 ] Commit Tag Bot commented on SOLR-4935: -- [trunk commit] erick http://svn.apache.org/viewvc?view=revisionrevision=1495528 SOLR-4935 additional improvements for persisting solr.xml when manipulating cores persisting solr.xml preserves extraneous values like wt=json in core tags when creating cores via the admin handler --- Key: SOLR-4935 URL: https://issues.apache.org/jira/browse/SOLR-4935 Project: Solr Issue Type: Bug Affects Versions: 5.0, 4.4 Reporter: Erick Erickson Assignee: Erick Erickson Attachments: SOLR-4935.patch, SOLR-4935.patch, SOLR-4935.patch I'll be s happy when we stop supporting persistence. Two problems 1 if instanceDir is not specified on the create, it's not persisted. And subsequent starts of Solr will fail. 2 extraneous params are specified, made worse by SolrJ adding some stuff on the create request like wt=javabin etc. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-4935) persisting solr.xml preserves extraneous values like wt=json in core tags when creating cores via the admin handler
[ https://issues.apache.org/jira/browse/SOLR-4935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13690642#comment-13690642 ] Commit Tag Bot commented on SOLR-4935: -- [branch_4x commit] erick http://svn.apache.org/viewvc?view=revisionrevision=1495563 SOLR-4935 additional improvements for persisting solr.xml when manipulating cores persisting solr.xml preserves extraneous values like wt=json in core tags when creating cores via the admin handler --- Key: SOLR-4935 URL: https://issues.apache.org/jira/browse/SOLR-4935 Project: Solr Issue Type: Bug Affects Versions: 5.0, 4.4 Reporter: Erick Erickson Assignee: Erick Erickson Attachments: SOLR-4935.patch, SOLR-4935.patch, SOLR-4935.patch I'll be s happy when we stop supporting persistence. Two problems 1 if instanceDir is not specified on the create, it's not persisted. And subsequent starts of Solr will fail. 2 extraneous params are specified, made worse by SolrJ adding some stuff on the create request like wt=javabin etc. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-4935) persisting solr.xml preserves extraneous values like wt=json in core tags when creating cores via the admin handler
[ https://issues.apache.org/jira/browse/SOLR-4935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13690814#comment-13690814 ] Commit Tag Bot commented on SOLR-4935: -- [trunk commit] erick http://svn.apache.org/viewvc?view=revisionrevision=1495621 test fix for SOLR-4935, path separator issue persisting solr.xml preserves extraneous values like wt=json in core tags when creating cores via the admin handler --- Key: SOLR-4935 URL: https://issues.apache.org/jira/browse/SOLR-4935 Project: Solr Issue Type: Bug Affects Versions: 5.0, 4.4 Reporter: Erick Erickson Assignee: Erick Erickson Fix For: 5.0, 4.4 Attachments: SOLR-4935.patch, SOLR-4935.patch, SOLR-4935.patch I'll be s happy when we stop supporting persistence. Two problems 1 if instanceDir is not specified on the create, it's not persisted. And subsequent starts of Solr will fail. 2 extraneous params are specified, made worse by SolrJ adding some stuff on the create request like wt=javabin etc. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-4935) persisting solr.xml preserves extraneous values like wt=json in core tags when creating cores via the admin handler
[ https://issues.apache.org/jira/browse/SOLR-4935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13690819#comment-13690819 ] Commit Tag Bot commented on SOLR-4935: -- [branch_4x commit] erick http://svn.apache.org/viewvc?view=revisionrevision=1495623 test fix for SOLR-4935, path separator issue persisting solr.xml preserves extraneous values like wt=json in core tags when creating cores via the admin handler --- Key: SOLR-4935 URL: https://issues.apache.org/jira/browse/SOLR-4935 Project: Solr Issue Type: Bug Affects Versions: 5.0, 4.4 Reporter: Erick Erickson Assignee: Erick Erickson Fix For: 5.0, 4.4 Attachments: SOLR-4935.patch, SOLR-4935.patch, SOLR-4935.patch, SOLR-4935-test-fix.patch I'll be s happy when we stop supporting persistence. Two problems 1 if instanceDir is not specified on the create, it's not persisted. And subsequent starts of Solr will fail. 2 extraneous params are specified, made worse by SolrJ adding some stuff on the create request like wt=javabin etc. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-4935) persisting solr.xml preserves extraneous values like wt=json in core tags when creating cores via the admin handler
[ https://issues.apache.org/jira/browse/SOLR-4935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13691042#comment-13691042 ] Commit Tag Bot commented on SOLR-4935: -- [trunk commit] erick http://svn.apache.org/viewvc?view=revisionrevision=1495661 test fix for SOLR-4935, path separator issue (second) persisting solr.xml preserves extraneous values like wt=json in core tags when creating cores via the admin handler --- Key: SOLR-4935 URL: https://issues.apache.org/jira/browse/SOLR-4935 Project: Solr Issue Type: Bug Affects Versions: 5.0, 4.4 Reporter: Erick Erickson Assignee: Erick Erickson Fix For: 5.0, 4.4 Attachments: SOLR-4935.patch, SOLR-4935.patch, SOLR-4935.patch, SOLR-4935-test-fix.patch I'll be s happy when we stop supporting persistence. Two problems 1 if instanceDir is not specified on the create, it's not persisted. And subsequent starts of Solr will fail. 2 extraneous params are specified, made worse by SolrJ adding some stuff on the create request like wt=javabin etc. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-4935) persisting solr.xml preserves extraneous values like wt=json in core tags when creating cores via the admin handler
[ https://issues.apache.org/jira/browse/SOLR-4935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13691047#comment-13691047 ] Commit Tag Bot commented on SOLR-4935: -- [branch_4x commit] erick http://svn.apache.org/viewvc?view=revisionrevision=1495662 test fix for SOLR-4935, path separator issue (second) persisting solr.xml preserves extraneous values like wt=json in core tags when creating cores via the admin handler --- Key: SOLR-4935 URL: https://issues.apache.org/jira/browse/SOLR-4935 Project: Solr Issue Type: Bug Affects Versions: 5.0, 4.4 Reporter: Erick Erickson Assignee: Erick Erickson Fix For: 5.0, 4.4 Attachments: SOLR-4935.patch, SOLR-4935.patch, SOLR-4935.patch, SOLR-4935-test-fix2.patch, SOLR-4935-test-fix.patch I'll be s happy when we stop supporting persistence. Two problems 1 if instanceDir is not specified on the create, it's not persisted. And subsequent starts of Solr will fail. 2 extraneous params are specified, made worse by SolrJ adding some stuff on the create request like wt=javabin etc. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-4935) persisting solr.xml preserves extraneous values like wt=json in core tags when creating cores via the admin handler
[ https://issues.apache.org/jira/browse/SOLR-4935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13686825#comment-13686825 ] Erick Erickson commented on SOLR-4935: -- BTW, I'm running tests now and I plan to commit this tonight. I want to give Al the chance to run it and be sure it cures what he's seeing. But I'm confident this is better than the current behavior, so if he doesn't get a chance today I'll just check it in regardless and we can open new JIRAs if it's not complete yet. persisting solr.xml preserves extraneous values like wt=json in core tags when creating cores via the admin handler --- Key: SOLR-4935 URL: https://issues.apache.org/jira/browse/SOLR-4935 Project: Solr Issue Type: Bug Affects Versions: 5.0, 4.4 Reporter: Erick Erickson Assignee: Erick Erickson Attachments: SOLR-4935.patch, SOLR-4935.patch I'll be s happy when we stop supporting persistence. Two problems 1 if instanceDir is not specified on the create, it's not persisted. And subsequent starts of Solr will fail. 2 extraneous params are specified, made worse by SolrJ adding some stuff on the create request like wt=javabin etc. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-4935) persisting solr.xml preserves extraneous values like wt=json in core tags when creating cores via the admin handler
[ https://issues.apache.org/jira/browse/SOLR-4935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13686831#comment-13686831 ] Shawn Heisey commented on SOLR-4935: What exactly happens if you don't include instanceDir? Does it just use solr.solr.home, or does it use the name of the core as instanceDir? If it's the name of the core, then IMHO the inferred value should be explicitly persisted on RENAME/SWAP. This will definitely be a lot better with core discovery. persisting solr.xml preserves extraneous values like wt=json in core tags when creating cores via the admin handler --- Key: SOLR-4935 URL: https://issues.apache.org/jira/browse/SOLR-4935 Project: Solr Issue Type: Bug Affects Versions: 5.0, 4.4 Reporter: Erick Erickson Assignee: Erick Erickson Attachments: SOLR-4935.patch, SOLR-4935.patch I'll be s happy when we stop supporting persistence. Two problems 1 if instanceDir is not specified on the create, it's not persisted. And subsequent starts of Solr will fail. 2 extraneous params are specified, made worse by SolrJ adding some stuff on the create request like wt=javabin etc. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-4935) persisting solr.xml preserves extraneous values like wt=json in core tags when creating cores via the admin handler
[ https://issues.apache.org/jira/browse/SOLR-4935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13686876#comment-13686876 ] Erick Erickson commented on SOLR-4935: -- bq: What exactly happens if you don't include instanceDir it defaults to the name of the core, pretty much as you'd expect. For instance if I specify name=eoe, the instance dir is eoe/, relative to solr home. The problem is that the core loading isn't smart enough to do the same default behavior if the instanceDir isn't specified in the core tag. One could easily argue that it _should_ be assuming the name is specified, but I'm not all that interested in changing functionality there and dealing with other places such a change might affect things when it's all going away... But good point, I'll add a test with the following steps 1 create 2 cores 2 check persistence is good 3 swap one of the new cores with another core 4 insure persistence is good 5 rename the other core 6 insure that persistence is good It's _probably_ OK, but there's no test that I know of that actually tries this kind of stuff... persisting solr.xml preserves extraneous values like wt=json in core tags when creating cores via the admin handler --- Key: SOLR-4935 URL: https://issues.apache.org/jira/browse/SOLR-4935 Project: Solr Issue Type: Bug Affects Versions: 5.0, 4.4 Reporter: Erick Erickson Assignee: Erick Erickson Attachments: SOLR-4935.patch, SOLR-4935.patch I'll be s happy when we stop supporting persistence. Two problems 1 if instanceDir is not specified on the create, it's not persisted. And subsequent starts of Solr will fail. 2 extraneous params are specified, made worse by SolrJ adding some stuff on the create request like wt=javabin etc. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-4935) persisting solr.xml preserves extraneous values like wt=json in core tags when creating cores via the admin handler
[ https://issues.apache.org/jira/browse/SOLR-4935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13687246#comment-13687246 ] Al Wold commented on SOLR-4935: --- After applying the patch to branch_4x, everything seems to be working well for me. I'll continue to test with this and update if I see any more problems. persisting solr.xml preserves extraneous values like wt=json in core tags when creating cores via the admin handler --- Key: SOLR-4935 URL: https://issues.apache.org/jira/browse/SOLR-4935 Project: Solr Issue Type: Bug Affects Versions: 5.0, 4.4 Reporter: Erick Erickson Assignee: Erick Erickson Attachments: SOLR-4935.patch, SOLR-4935.patch I'll be s happy when we stop supporting persistence. Two problems 1 if instanceDir is not specified on the create, it's not persisted. And subsequent starts of Solr will fail. 2 extraneous params are specified, made worse by SolrJ adding some stuff on the create request like wt=javabin etc. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
