[jira] [Commented] (SOLR-9090) solrj CloudSolrClient: add directUpdatesToLeadersOnly support
[
https://issues.apache.org/jira/browse/SOLR-9090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16209214#comment-16209214
]
Christine Poerschke commented on SOLR-9090:
---
[~dsmiley] - yes, I think so and created SOLR-11507 with patch of how i
understood your suggestions.
> solrj CloudSolrClient: add directUpdatesToLeadersOnly support
> -
>
> Key: SOLR-9090
> URL: https://issues.apache.org/jira/browse/SOLR-9090
> Project: Solr
> Issue Type: New Feature
> Components: SolrJ
>Reporter: Christine Poerschke
>Assignee: Christine Poerschke
>Priority: Minor
> Fix For: 6.2, 7.0
>
> Attachments: SOLR-9090.patch, SOLR-9090.patch
>
>
> solrj CloudSolrClient: add directUpdatesToLeadersOnly support
> (Marvin Justice, Christine Poerschke)
> Proposed change:
> * Addition of a {{directUpdatesToLeadersOnly}} flag to allow clients to
> request that direct updates be sent to the shard leaders and only to the
> shard leaders.
> Motivation:
> * In a scenario where there is temporarily no shard leader the update request
> will 'fail fast' allowing the client to handle retry logic.
> Related tickets:
> * SOLR-6312 concerns the ((currently) no longer used) {{updatesToLeaders}}
> flag. The updatesToLeaders logic however appears to be slightly different
> from the proposed directUpdatesToLeadersOnly logic: {{updatesToLeaders}}
> indicates that sending to leaders is preferred but not mandatory whereas
> {{directUpdatesToLeadersOnly}} mandates sending to leaders only.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9090) solrj CloudSolrClient: add directUpdatesToLeadersOnly support
[
https://issues.apache.org/jira/browse/SOLR-9090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16208225#comment-16208225
]
David Smiley commented on SOLR-9090:
Furthermore, shouldn't {{shardLeadersOnly}} be randomized as well?
> solrj CloudSolrClient: add directUpdatesToLeadersOnly support
> -
>
> Key: SOLR-9090
> URL: https://issues.apache.org/jira/browse/SOLR-9090
> Project: Solr
> Issue Type: New Feature
> Components: SolrJ
>Reporter: Christine Poerschke
>Assignee: Christine Poerschke
>Priority: Minor
> Fix For: 6.2, 7.0
>
> Attachments: SOLR-9090.patch, SOLR-9090.patch
>
>
> solrj CloudSolrClient: add directUpdatesToLeadersOnly support
> (Marvin Justice, Christine Poerschke)
> Proposed change:
> * Addition of a {{directUpdatesToLeadersOnly}} flag to allow clients to
> request that direct updates be sent to the shard leaders and only to the
> shard leaders.
> Motivation:
> * In a scenario where there is temporarily no shard leader the update request
> will 'fail fast' allowing the client to handle retry logic.
> Related tickets:
> * SOLR-6312 concerns the ((currently) no longer used) {{updatesToLeaders}}
> flag. The updatesToLeaders logic however appears to be slightly different
> from the proposed directUpdatesToLeadersOnly logic: {{updatesToLeaders}}
> indicates that sending to leaders is preferred but not mandatory whereas
> {{directUpdatesToLeadersOnly}} mandates sending to leaders only.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9090) solrj CloudSolrClient: add directUpdatesToLeadersOnly support
[
https://issues.apache.org/jira/browse/SOLR-9090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16208224#comment-16208224
]
David Smiley commented on SOLR-9090:
[~cpoerschke] I'm looking at {{SolrTestCaseJ4.CloudSolrClientBuilder}}.
Instead of the somewhat complicated tracking using configuredDUTflag, couldn't
you simply remove all that stuff and just modify the builder's constructor to
randomize the settings?
> solrj CloudSolrClient: add directUpdatesToLeadersOnly support
> -
>
> Key: SOLR-9090
> URL: https://issues.apache.org/jira/browse/SOLR-9090
> Project: Solr
> Issue Type: New Feature
> Components: SolrJ
>Reporter: Christine Poerschke
>Assignee: Christine Poerschke
>Priority: Minor
> Fix For: 6.2, 7.0
>
> Attachments: SOLR-9090.patch, SOLR-9090.patch
>
>
> solrj CloudSolrClient: add directUpdatesToLeadersOnly support
> (Marvin Justice, Christine Poerschke)
> Proposed change:
> * Addition of a {{directUpdatesToLeadersOnly}} flag to allow clients to
> request that direct updates be sent to the shard leaders and only to the
> shard leaders.
> Motivation:
> * In a scenario where there is temporarily no shard leader the update request
> will 'fail fast' allowing the client to handle retry logic.
> Related tickets:
> * SOLR-6312 concerns the ((currently) no longer used) {{updatesToLeaders}}
> flag. The updatesToLeaders logic however appears to be slightly different
> from the proposed directUpdatesToLeadersOnly logic: {{updatesToLeaders}}
> indicates that sending to leaders is preferred but not mandatory whereas
> {{directUpdatesToLeadersOnly}} mandates sending to leaders only.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9090) solrj CloudSolrClient: add directUpdatesToLeadersOnly support
[
https://issues.apache.org/jira/browse/SOLR-9090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15452382#comment-15452382
]
Christine Poerschke commented on SOLR-9090:
---
For the newly added {{directUpdatesToLeadersOnly}} flag to initially default to
existing behaviour made sense I think. However, now that it's no longer a new
flag then, sure, its default value could be changed, SOLR-9464 created with
proposed patch.
> solrj CloudSolrClient: add directUpdatesToLeadersOnly support
> -
>
> Key: SOLR-9090
> URL: https://issues.apache.org/jira/browse/SOLR-9090
> Project: Solr
> Issue Type: New Feature
> Components: SolrJ
>Reporter: Christine Poerschke
>Assignee: Christine Poerschke
>Priority: Minor
> Fix For: 6.2, master (7.0)
>
> Attachments: SOLR-9090.patch, SOLR-9090.patch
>
>
> solrj CloudSolrClient: add directUpdatesToLeadersOnly support
> (Marvin Justice, Christine Poerschke)
> Proposed change:
> * Addition of a {{directUpdatesToLeadersOnly}} flag to allow clients to
> request that direct updates be sent to the shard leaders and only to the
> shard leaders.
> Motivation:
> * In a scenario where there is temporarily no shard leader the update request
> will 'fail fast' allowing the client to handle retry logic.
> Related tickets:
> * SOLR-6312 concerns the ((currently) no longer used) {{updatesToLeaders}}
> flag. The updatesToLeaders logic however appears to be slightly different
> from the proposed directUpdatesToLeadersOnly logic: {{updatesToLeaders}}
> indicates that sending to leaders is preferred but not mandatory whereas
> {{directUpdatesToLeadersOnly}} mandates sending to leaders only.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9090) solrj CloudSolrClient: add directUpdatesToLeadersOnly support
[
https://issues.apache.org/jira/browse/SOLR-9090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15445986#comment-15445986
]
Shalin Shekhar Mangar commented on SOLR-9090:
-
Sorry for being late here but I think directUpdatesToLeadersOnly should be the
default. There is little advantage in sending requests to other nodes in the
hope that even if we didn't see a leader, someone else might.
> solrj CloudSolrClient: add directUpdatesToLeadersOnly support
> -
>
> Key: SOLR-9090
> URL: https://issues.apache.org/jira/browse/SOLR-9090
> Project: Solr
> Issue Type: New Feature
> Components: SolrJ
>Reporter: Christine Poerschke
>Assignee: Christine Poerschke
>Priority: Minor
> Fix For: 6.2, master (7.0)
>
> Attachments: SOLR-9090.patch, SOLR-9090.patch
>
>
> solrj CloudSolrClient: add directUpdatesToLeadersOnly support
> (Marvin Justice, Christine Poerschke)
> Proposed change:
> * Addition of a {{directUpdatesToLeadersOnly}} flag to allow clients to
> request that direct updates be sent to the shard leaders and only to the
> shard leaders.
> Motivation:
> * In a scenario where there is temporarily no shard leader the update request
> will 'fail fast' allowing the client to handle retry logic.
> Related tickets:
> * SOLR-6312 concerns the ((currently) no longer used) {{updatesToLeaders}}
> flag. The updatesToLeaders logic however appears to be slightly different
> from the proposed directUpdatesToLeadersOnly logic: {{updatesToLeaders}}
> indicates that sending to leaders is preferred but not mandatory whereas
> {{directUpdatesToLeadersOnly}} mandates sending to leaders only.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9090) solrj CloudSolrClient: add directUpdatesToLeadersOnly support
[
https://issues.apache.org/jira/browse/SOLR-9090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15407808#comment-15407808
]
Marvin Justice commented on SOLR-9090:
--
If it's a transient condition, and the request is passed off to a non-leader,
then it may succeed if a leader suddenly reappears.
> solrj CloudSolrClient: add directUpdatesToLeadersOnly support
> -
>
> Key: SOLR-9090
> URL: https://issues.apache.org/jira/browse/SOLR-9090
> Project: Solr
> Issue Type: New Feature
> Components: SolrJ
>Reporter: Christine Poerschke
>Assignee: Christine Poerschke
>Priority: Minor
> Fix For: 6.2, master (7.0)
>
> Attachments: SOLR-9090.patch, SOLR-9090.patch
>
>
> solrj CloudSolrClient: add directUpdatesToLeadersOnly support
> (Marvin Justice, Christine Poerschke)
> Proposed change:
> * Addition of a {{directUpdatesToLeadersOnly}} flag to allow clients to
> request that direct updates be sent to the shard leaders and only to the
> shard leaders.
> Motivation:
> * In a scenario where there is temporarily no shard leader the update request
> will 'fail fast' allowing the client to handle retry logic.
> Related tickets:
> * SOLR-6312 concerns the ((currently) no longer used) {{updatesToLeaders}}
> flag. The updatesToLeaders logic however appears to be slightly different
> from the proposed directUpdatesToLeadersOnly logic: {{updatesToLeaders}}
> indicates that sending to leaders is preferred but not mandatory whereas
> {{directUpdatesToLeadersOnly}} mandates sending to leaders only.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9090) solrj CloudSolrClient: add directUpdatesToLeadersOnly support
[
https://issues.apache.org/jira/browse/SOLR-9090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15407382#comment-15407382
]
Varun Thacker commented on SOLR-9090:
-
Hi Christine,
Just curious - Why shouldn't directUpdatesToLeadersOnly be the default
behaviour?
If at a time of an update there are no leaders then won't the request fail
anyways?
> solrj CloudSolrClient: add directUpdatesToLeadersOnly support
> -
>
> Key: SOLR-9090
> URL: https://issues.apache.org/jira/browse/SOLR-9090
> Project: Solr
> Issue Type: New Feature
> Components: SolrJ
>Reporter: Christine Poerschke
>Assignee: Christine Poerschke
>Priority: Minor
> Fix For: 6.2, master (7.0)
>
> Attachments: SOLR-9090.patch, SOLR-9090.patch
>
>
> solrj CloudSolrClient: add directUpdatesToLeadersOnly support
> (Marvin Justice, Christine Poerschke)
> Proposed change:
> * Addition of a {{directUpdatesToLeadersOnly}} flag to allow clients to
> request that direct updates be sent to the shard leaders and only to the
> shard leaders.
> Motivation:
> * In a scenario where there is temporarily no shard leader the update request
> will 'fail fast' allowing the client to handle retry logic.
> Related tickets:
> * SOLR-6312 concerns the ((currently) no longer used) {{updatesToLeaders}}
> flag. The updatesToLeaders logic however appears to be slightly different
> from the proposed directUpdatesToLeadersOnly logic: {{updatesToLeaders}}
> indicates that sending to leaders is preferred but not mandatory whereas
> {{directUpdatesToLeadersOnly}} mandates sending to leaders only.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9090) solrj CloudSolrClient: add directUpdatesToLeadersOnly support
[
https://issues.apache.org/jira/browse/SOLR-9090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15375123#comment-15375123
]
ASF subversion and git services commented on SOLR-9090:
---
Commit 85c8f22ca9aa89a76940641e19da2a688e1a0796 in lucene-solr's branch
refs/heads/branch_6x from [~cpoerschke]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=85c8f22 ]
SOLR-9090: Add directUpdatesToLeadersOnly flag to solrj CloudSolrClient.
(Marvin Justice, Christine Poerschke)
> solrj CloudSolrClient: add directUpdatesToLeadersOnly support
> -
>
> Key: SOLR-9090
> URL: https://issues.apache.org/jira/browse/SOLR-9090
> Project: Solr
> Issue Type: New Feature
> Components: SolrJ
>Reporter: Christine Poerschke
>Assignee: Christine Poerschke
>Priority: Minor
> Attachments: SOLR-9090.patch, SOLR-9090.patch
>
>
> solrj CloudSolrClient: add directUpdatesToLeadersOnly support
> (Marvin Justice, Christine Poerschke)
> Proposed change:
> * Addition of a {{directUpdatesToLeadersOnly}} flag to allow clients to
> request that direct updates be sent to the shard leaders and only to the
> shard leaders.
> Motivation:
> * In a scenario where there is temporarily no shard leader the update request
> will 'fail fast' allowing the client to handle retry logic.
> Related tickets:
> * SOLR-6312 concerns the ((currently) no longer used) {{updatesToLeaders}}
> flag. The updatesToLeaders logic however appears to be slightly different
> from the proposed directUpdatesToLeadersOnly logic: {{updatesToLeaders}}
> indicates that sending to leaders is preferred but not mandatory whereas
> {{directUpdatesToLeadersOnly}} mandates sending to leaders only.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9090) solrj CloudSolrClient: add directUpdatesToLeadersOnly support
[
https://issues.apache.org/jira/browse/SOLR-9090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15366039#comment-15366039
]
ASF subversion and git services commented on SOLR-9090:
---
Commit 976079a8ee8a2cff1c8df01ae9f2856b3ddcdac3 in lucene-solr's branch
refs/heads/master from [~cpoerschke]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=976079a ]
SOLR-9090: Add directUpdatesToLeadersOnly flag to solrj CloudSolrClient.
(Marvin Justice, Christine Poerschke)
> solrj CloudSolrClient: add directUpdatesToLeadersOnly support
> -
>
> Key: SOLR-9090
> URL: https://issues.apache.org/jira/browse/SOLR-9090
> Project: Solr
> Issue Type: New Feature
> Components: SolrJ
>Reporter: Christine Poerschke
>Assignee: Christine Poerschke
>Priority: Minor
> Attachments: SOLR-9090.patch, SOLR-9090.patch
>
>
> solrj CloudSolrClient: add directUpdatesToLeadersOnly support
> (Marvin Justice, Christine Poerschke)
> Proposed change:
> * Addition of a {{directUpdatesToLeadersOnly}} flag to allow clients to
> request that direct updates be sent to the shard leaders and only to the
> shard leaders.
> Motivation:
> * In a scenario where there is temporarily no shard leader the update request
> will 'fail fast' allowing the client to handle retry logic.
> Related tickets:
> * SOLR-6312 concerns the ((currently) no longer used) {{updatesToLeaders}}
> flag. The updatesToLeaders logic however appears to be slightly different
> from the proposed directUpdatesToLeadersOnly logic: {{updatesToLeaders}}
> indicates that sending to leaders is preferred but not mandatory whereas
> {{directUpdatesToLeadersOnly}} mandates sending to leaders only.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-9090) solrj CloudSolrClient: add directUpdatesToLeadersOnly support
[
https://issues.apache.org/jira/browse/SOLR-9090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15276258#comment-15276258
]
Christine Poerschke commented on SOLR-9090:
---
Linking SOLR-6312 as related but slightly different logic.
> solrj CloudSolrClient: add directUpdatesToLeadersOnly support
> -
>
> Key: SOLR-9090
> URL: https://issues.apache.org/jira/browse/SOLR-9090
> Project: Solr
> Issue Type: New Feature
> Components: SolrJ
>Reporter: Christine Poerschke
>Assignee: Christine Poerschke
>Priority: Minor
> Attachments: SOLR-9090.patch
>
>
> solrj CloudSolrClient: add directUpdatesToLeadersOnly support
> (Marvin Justice, Christine Poerschke)
> Proposed change:
> * Addition of a {{directUpdatesToLeadersOnly}} flag to allow clients to
> request that direct updates be sent to the shard leaders and only to the
> shard leaders.
> Motivation:
> * In a scenario where there is temporarily no shard leader the update request
> will 'fail fast' allowing the client to handle retry logic.
> Related tickets:
> * SOLR-6312 concerns the ((currently) no longer used) {{updatesToLeaders}}
> flag. The updatesToLeaders logic however appears to be slightly different
> from the proposed directUpdatesToLeadersOnly logic: {{updatesToLeaders}}
> indicates that sending to leaders is preferred but not mandatory whereas
> {{directUpdatesToLeadersOnly}} mandates sending to leaders only.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
