Thanks for mentioning. I’m adding a README.md to the scripts folder soon. It
will mention this prerequisite:
pip3 install -r requirements.txt
In the requirements file we’ll also gather dependencies for other scripts in
the folder.
Jan Høydahl
> 14. jun. 2019 kl. 22:26 skrev Cassandra Targett
Nice script Jan, thanks.
Just a note for others who may have a less than complete python setup already,
I needed to install pygithub and jira modules to get it to run:
pip install pygithub
pip install jira
Cassandra
On Jun 14, 2019, 7:11 AM -0500, Jan Høydahl , wrote:
> I closed PR #165, #146,
I closed PR #165, #146, #444, #711 and #651
I checked in the python script so you may try to run it for yourself
--
Jan Høydahl, search solution architect
Cominvent AS - www.cominvent.com
> 14. jun. 2019 kl. 13:20 skrev Jan Høydahl :
>
> I wrote a script to find PRs without JIRA in title and to
I wrote a script to find PRs without JIRA in title and to find PRs where
corresponding JIRA is closed. The output is below.
I could also extend the tool with options to also add a comment to the PRs
lacking issue in title, and to close the PRs where JIRA is resolved :)
usage: githubPRs.py [-h]
I committed the pull request template a bit ago. Let’s see if it helps.
I can help do some cleanup of existing open PRs, maybe tomorrow afternoon my
time. It’s worth checking while we’re at it for PRs that are still open even
though the Jira is resolved/closed.
Cassandra
On Jun 13, 2019, 6:08 A
Once we get C in place (Github PR template), this will hopefully fix itself.
So I propose to try PR template as a first measure and then revisit if that is
not enough.
Still left to do is to triage the existing open PRs and link them. Who wants to
help?
https://github.com/apache/lucene-solr
Or the committer can create it if the issue is truly trivial... Also, one
of the things that folks who contribute may gain is learning about
development process. That aspect was extremely helpful to me when I made my
first contributions to Ant many years ago. Not everyone who contributes is
an expe
I think D is important for making the barrier low for new contributors to
get started.
It won't be great as we'll have two places to look a CHANGES entry against
but I'll be okay with that.
Today a new contributor creates a PR and a committer can even merge the PR
from the github interface. But i
Jira has become very heavy-weight over the years and I'm not sure we need all
those features.
I think Github issues are a bit too lightweight perhaps, so I'm not actively
promoting option E, just lifting it up as a real alternative.
> As an example how would you implement the security issue visi
I created an infra "wish" that relates somewhat to this as well...
https://issues.apache.org/jira/browse/INFRA-18518 I also don't like D.
There definitely needs to be only one place to search for issues. I don't
like E either, while convenient from github their issue system has way
fewer features
I created an issue for this at
https://issues.apache.org/jira/browse/LUCENE-8842, and I’ll use that to create
a branch and push up what I have so far for a template.
Cassandra
On Jun 7, 2019, 11:31 AM -0500, Kevin Risden , wrote:
> PR template would definitely be good. Easiest to implement with
PR template would definitely be good. Easiest to implement with biggest
impact. I like that all issues are in Jira. There is already an infra bot
that will auto link Jiras and PRs if the PR has the a JIRA reference in it
I think.
For reference this is also the idea of contributing guidelines in ad
I think a PR template would be great. Lets see yours Cassandra!
~ David Smiley
Apache Lucene/Solr Search Developer
http://www.linkedin.com/in/davidwsmiley
On Fri, Jun 7, 2019 at 9:35 AM Cassandra Targett
wrote:
> Heh, here’s another idea I’ve had in my drafts folder for a while but
> thought
Heh, here’s another idea I’ve had in my drafts folder for a while but thought
if I suggest it I should be available to follow up on it and wasn’t sure if I’d
have time to properly.
I actually started a pull request template and have a mostly complete version I
could share (via a PR, I guess?).
Hi,
We have some contributors that open GitHub PRs without also opening a JIRA and
linking the two. Probably because they are used to that workflow from other
projects and expect someone to have a look at the contribution. There is an
email sent to the dev list, and sometimes it is noticed, oth
15 matches
Mail list logo
