[GitHub] lucenenet pull request: Make sure offsetGap is nullable int

2015-05-03 Thread laimis
Github user laimis commented on the pull request: https://github.com/apache/lucenenet/pull/138#issuecomment-98561035 Hold off on merging this one just yet, the failing test got fixed with this, but now new failures are appearing in the related code. Investigating... --- If your

[GitHub] lucenenet pull request: Make sure offsetGap is nullable int

2015-05-03 Thread laimis
Github user laimis commented on the pull request: https://github.com/apache/lucenenet/pull/138#issuecomment-98565684 It looks like those other tests were failing because they were modified in Lucene.Net to work around the bug, ie tests were adjusted to pass while leaving the bug in

[GitHub] lucenenet pull request: Make sure offsetGap is nullable int

2015-05-03 Thread synhershko
Github user synhershko commented on the pull request: https://github.com/apache/lucenenet/pull/138#issuecomment-98593927 Good catch 2 things come to mind: 1. `OffsetGap_Renamed` and such other `_Renamed` instances need to be, well, renamed and have that suffix

[TeamCity, FAILED] Build Lucene.NET :: Lucene.NET Nightly [master] #410

2015-05-03 Thread tc
Build Lucene.NET :: Lucene.NET Nightly [master] #410 failed (Tests failed: 94 (4 new), passed: 2677, ignored: 122; snapshot dependency failed: Lucene.NET :: Lucene.NET Core). Agent: JetBrains-dotnet-agent01 Build results:

[GitHub] lucenenet pull request: Use SafeGet and SafeSet for BitArray to ma...

2015-05-03 Thread laimis
GitHub user laimis opened a pull request: https://github.com/apache/lucenenet/pull/137 Use SafeGet and SafeSet for BitArray to match Lucene behavior Lucene.Net port uses BitArray as a replacement for BitSet that Lucene uses. However BitArray behaves differently from BitSet when the