[GitHub] lucenenet pull request #176: Ported QueryParser

Github user NightOwl888 commented on a diff in the pull request: https://github.com/apache/lucenenet/pull/176#discussion_r73793556 --- Diff: src/Lucene.Net.Core/Util/ToStringUtils.cs --- @@ -36,12 +37,13 @@ public static string Boost(float boost) { if

[GitHub] lucenenet issue #175: IndexableField API Consistency Fix

Github user NightOwl888 commented on the issue: https://github.com/apache/lucenenet/pull/175 I thought I got everything, but I will take another look. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] lucenenet issue #173: Analysis work

Github user NightOwl888 commented on the issue: https://github.com/apache/lucenenet/pull/173 FYI - I am still working on this. I managed to get past the infinite recursion problem. I have completed nearly all of the standard and core namespaces and ported over 250 tests, with 225 of

Re: [GitHub] lucenenet issue #176: Ported QueryParser

There wasn't one for the 4.8 version, this is what's being ported now -- Itamar Syn-Hershko http://code972.com | @synhershko Freelance Developer & Consultant Lucene.NET committer and PMC member On Fri, Aug 5, 2016 at 4:20 PM, Benjamin Collins

[GitHub] lucenenet issue #176: Ported QueryParser

Github user synhershko commented on the issue: https://github.com/apache/lucenenet/pull/176 Left one minor comments, looks good to merge otherwise. Thanks for your help! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] lucenenet pull request #176: Ported QueryParser

Github user synhershko commented on a diff in the pull request: https://github.com/apache/lucenenet/pull/176#discussion_r73792790 --- Diff: src/Lucene.Net.Core/Util/ToStringUtils.cs --- @@ -36,12 +37,13 @@ public static string Boost(float boost) { if

[GitHub] lucenenet issue #174: Ported over Lucene.Net.Spatial

Github user synhershko commented on the issue: https://github.com/apache/lucenenet/pull/174 Is this a full and complete port (e.g. no classes or functionality left behind)? if so, how did you manage to avoid updating spatial4n to bring it up to date with the latest spatial4j? ---

[GitHub] lucenenet issue #175: IndexableField API Consistency Fix

Github user synhershko commented on the issue: https://github.com/apache/lucenenet/pull/175 Looks good, let's work on getting this in. This PR currently breaks sub-projects, as the API change hasn't been propogated there and to their tests. Can you run the entire solution and make

Re: Lucene.NET to .NET Core

Just reviewed it and it looks great - thanks! added a few minor comments, once you get them fixed we can merge that in. Thanks again! -- Itamar Syn-Hershko http://code972.com | @synhershko Freelance Developer & Consultant Lucene.NET committer and PMC member On

[GitHub] lucenenet issue #177: Limiting uses of static variables and methods in Testc...

Github user synhershko commented on the issue: https://github.com/apache/lucenenet/pull/177 Looks great! Added a few comments (1) might have found a bug - you didn't change local vars in some occasions so I had commented in some of them, (2) please document all test API

[GitHub] lucenenet pull request #177: Limiting uses of static variables and methods i...

Github user synhershko commented on a diff in the pull request: https://github.com/apache/lucenenet/pull/177#discussion_r73790017 --- Diff: src/Lucene.Net.Tests/core/Search/TestPhraseQuery.cs --- @@ -255,7 +255,7 @@ public virtual void TestPhraseQueryWithStopAnalyzer()

[GitHub] lucenenet pull request #177: Limiting uses of static variables and methods i...

Github user synhershko commented on a diff in the pull request: https://github.com/apache/lucenenet/pull/177#discussion_r73789830 --- Diff: src/Lucene.Net.Tests/core/Codecs/Lucene3x/TestLucene3xStoredFieldsFormat.cs --- @@ -35,7 +35,8 @@ protected override Codec Codec

[GitHub] lucenenet pull request #177: Limiting uses of static variables and methods i...

Github user synhershko commented on a diff in the pull request: https://github.com/apache/lucenenet/pull/177#discussion_r73789759 --- Diff: src/Lucene.Net.TestFramework/Index/RandomIndexWriter.cs --- @@ -85,22 +86,22 @@ public static IndexWriter MockIndexWriter(Directory dir,