[GitHub] lucenenet issue #205: Made FSDirectory stale files set synchronized.

2017-05-09 Thread pvginkel
Github user pvginkel commented on the issue: https://github.com/apache/lucenenet/pull/205 Sure, no problem: private void ReplaceStaleFiles(FSDirectory fsDirectory) { // Work around for https://github.com/apache/lucenenet/pull/205. var

[GitHub] lucenenet issue #205: Made FSDirectory stale files set synchronized.

2017-05-09 Thread NightOwl888
Github user NightOwl888 commented on the issue: https://github.com/apache/lucenenet/pull/205 > I am currently working around this using reflection, so for me it's fine. Peter, could you please post your workaround here in case other users need it? --- If your project is set

[GitHub] lucenenet issue #205: Made FSDirectory stale files set synchronized.

2017-05-09 Thread pvginkel
Github user pvginkel commented on the issue: https://github.com/apache/lucenenet/pull/205 I've removed the `[Ignore]` attribute and left the timeout as is. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] lucenenet issue #205: Made FSDirectory stale files set synchronized.

2017-05-09 Thread NightOwl888
Github user NightOwl888 commented on the issue: https://github.com/apache/lucenenet/pull/205 > OK. So I should remove the `[Ignore]` attribute then? Yes. We should only use the `[Ignore]` attribute in cases where the test takes > 30 minutes and must be run manually, or was

[GitHub] lucenenet issue #205: Made FSDirectory stale files set synchronized.

2017-05-09 Thread pvginkel
Github user pvginkel commented on the issue: https://github.com/apache/lucenenet/pull/205 OK. So I should remove the `[Ignore]` attribute then? The only question I still have is about the timeout. In my tests, if it would test, it would test rather quickly. At the moment I

[GitHub] lucenenet issue #205: Made FSDirectory stale files set synchronized.

2017-05-08 Thread synhershko
Github user synhershko commented on the issue: https://github.com/apache/lucenenet/pull/205 This is a great test - and as it happens many bugs in Apache Lucene (Java), even very severe ones, were caught using a randomized testing framework, which by definition is not deterministic.

[GitHub] lucenenet issue #205: Made FSDirectory stale files set synchronized.

2017-05-08 Thread pvginkel
Github user pvginkel commented on the issue: https://github.com/apache/lucenenet/pull/205 I have, but this is a problematic one. This depends on a race condition, which is non-deterministic by definition. The test case I created runs a few threads for a few seconds and fails

[GitHub] lucenenet issue #205: Made FSDirectory stale files set synchronized.

2017-05-08 Thread NightOwl888
Github user NightOwl888 commented on the issue: https://github.com/apache/lucenenet/pull/205 @pvginkel Could you add a test to this PR in the [TestDirectory

[GitHub] lucenenet issue #205: Made FSDirectory stale files set synchronized.

2017-05-08 Thread pvginkel
Github user pvginkel commented on the issue: https://github.com/apache/lucenenet/pull/205 I am currently working around this using reflection, so for me it's fine. However, this is causing real problems. I wrote a prototype which is indexing using 4 threads, a thread that

[GitHub] lucenenet issue #205: Made FSDirectory stale files set synchronized.

2017-05-08 Thread NightOwl888
Github user NightOwl888 commented on the issue: https://github.com/apache/lucenenet/pull/205 @synhershko Not without cancelling the vote and starting over (for the 3rd time) - we have only 12 hours left on the current vote. I suspect there will be several issues such as

[GitHub] lucenenet issue #205: Made FSDirectory stale files set synchronized.

2017-05-08 Thread synhershko
Github user synhershko commented on the issue: https://github.com/apache/lucenenet/pull/205 Good catch, thanks! @NightOwl888 can we get this to the beta version before it's released? --- If your project is set up for it, you can reply to this email and have your reply appear