[GitHub] lucenenet pull request: Make sure offsetGap is nullable int

2015-05-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/lucenenet/pull/138 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] lucenenet pull request: Make sure offsetGap is nullable int

2015-05-03 Thread laimis
Github user laimis commented on the pull request: https://github.com/apache/lucenenet/pull/138#issuecomment-98561035 Hold off on merging this one just yet, the failing test got fixed with this, but now new failures are appearing in the related code. Investigating... --- If your

[GitHub] lucenenet pull request: Make sure offsetGap is nullable int

2015-05-03 Thread laimis
Github user laimis commented on the pull request: https://github.com/apache/lucenenet/pull/138#issuecomment-98565684 It looks like those other tests were failing because they were modified in Lucene.Net to work around the bug, ie tests were adjusted to pass while leaving the bug in

[GitHub] lucenenet pull request: Make sure offsetGap is nullable int

2015-05-03 Thread synhershko
Github user synhershko commented on the pull request: https://github.com/apache/lucenenet/pull/138#issuecomment-98593927 Good catch 2 things come to mind: 1. `OffsetGap_Renamed` and such other `_Renamed` instances need to be, well, renamed and have that suffix