[GitHub] lucenenet pull request: Removing Apache.NMS dependency.

2016-04-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/lucenenet/pull/168 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] lucenenet pull request: Removing Apache.NMS dependency.

2016-04-23 Thread eladmarg
Github user eladmarg commented on a diff in the pull request: https://github.com/apache/lucenenet/pull/168#discussion_r60835981 --- Diff: src/Lucene.Net.Core/Support/AtomicObject.cs --- @@ -0,0 +1,39 @@ +using System; +using System.Threading; + +namespace

[GitHub] lucenenet pull request: Removing Apache.NMS dependency.

2016-04-23 Thread synhershko
Github user synhershko commented on the pull request: https://github.com/apache/lucenenet/pull/168#issuecomment-213845719 Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] lucenenet pull request: Removing Apache.NMS dependency.

2016-04-23 Thread EMaher
Github user EMaher commented on the pull request: https://github.com/apache/lucenenet/pull/168#issuecomment-213839959 OK. Suggested changes have been made. I also verified that passing tests continue to pass, especially the ones that used to use AtomicReference. --- If your

[GitHub] lucenenet pull request: Removing Apache.NMS dependency.

2016-04-23 Thread EMaher
Github user EMaher commented on a diff in the pull request: https://github.com/apache/lucenenet/pull/168#discussion_r60832211 --- Diff: src/Lucene.Net.Tests/core/Index/TestIndexWriterWithThreads.cs --- @@ -726,15 +724,15 @@ public override void Run()

[GitHub] lucenenet pull request: Removing Apache.NMS dependency.

2016-04-23 Thread EMaher
Github user EMaher commented on a diff in the pull request: https://github.com/apache/lucenenet/pull/168#discussion_r60832185 --- Diff: src/Lucene.Net.Tests/core/Index/TestIndexWriterWithThreads.cs --- @@ -657,7 +655,7 @@ public virtual void TestRollbackAndCommitWithThreads()

[GitHub] lucenenet pull request: Removing Apache.NMS dependency.

2016-04-23 Thread conniey
Github user conniey commented on a diff in the pull request: https://github.com/apache/lucenenet/pull/168#discussion_r60831857 --- Diff: src/Lucene.Net.Tests/core/Index/TestIndexWriterWithThreads.cs --- @@ -657,7 +655,7 @@ public virtual void TestRollbackAndCommitWithThreads()

[GitHub] lucenenet pull request: Removing Apache.NMS dependency.

2016-04-22 Thread synhershko
Github user synhershko commented on a diff in the pull request: https://github.com/apache/lucenenet/pull/168#discussion_r60711453 --- Diff: src/Lucene.Net.Tests/core/Index/TestIndexWriterWithThreads.cs --- @@ -726,15 +724,15 @@ public override void Run()

[GitHub] lucenenet pull request: Removing Apache.NMS dependency.

2016-04-22 Thread synhershko
Github user synhershko commented on a diff in the pull request: https://github.com/apache/lucenenet/pull/168#discussion_r60711321 --- Diff: src/Lucene.Net.Tests/core/Index/TestIndexWriterWithThreads.cs --- @@ -657,7 +655,7 @@ public virtual void TestRollbackAndCommitWithThreads()

[GitHub] lucenenet pull request: Removing Apache.NMS dependency.

2016-04-21 Thread EMaher
GitHub user EMaher opened a pull request: https://github.com/apache/lucenenet/pull/168 Removing Apache.NMS dependency. Removing dependency on Apache.NMS. This is needed to build Lucene.Net on .NET Core. -Replaced AtomicReference with use of Interlocked.Exchange. -Replaced