[GitHub] lucenenet pull request #177: Limiting uses of static variables and methods i...

2016-08-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/lucenenet/pull/177 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] lucenenet pull request #177: Limiting uses of static variables and methods i...

2016-08-06 Thread synhershko
Github user synhershko commented on a diff in the pull request: https://github.com/apache/lucenenet/pull/177#discussion_r73790017 --- Diff: src/Lucene.Net.Tests/core/Search/TestPhraseQuery.cs --- @@ -255,7 +255,7 @@ public virtual void TestPhraseQueryWithStopAnalyzer()

[GitHub] lucenenet pull request #177: Limiting uses of static variables and methods i...

2016-08-06 Thread synhershko
Github user synhershko commented on a diff in the pull request: https://github.com/apache/lucenenet/pull/177#discussion_r73789830 --- Diff: src/Lucene.Net.Tests/core/Codecs/Lucene3x/TestLucene3xStoredFieldsFormat.cs --- @@ -35,7 +35,8 @@ protected override Codec Codec

[GitHub] lucenenet pull request #177: Limiting uses of static variables and methods i...

2016-08-06 Thread synhershko
Github user synhershko commented on a diff in the pull request: https://github.com/apache/lucenenet/pull/177#discussion_r73789759 --- Diff: src/Lucene.Net.TestFramework/Index/RandomIndexWriter.cs --- @@ -85,22 +86,22 @@ public static IndexWriter MockIndexWriter(Directory dir,

[GitHub] lucenenet pull request #177: Limiting uses of static variables and methods i...

2016-08-04 Thread conniey
GitHub user conniey opened a pull request: https://github.com/apache/lucenenet/pull/177 Limiting uses of static variables and methods in Testcases This is an improvement from PR #172. The difference is that all the existing constructors are maintained with some additions.