[GitHub] madlib issue #191: KNN: Fix optional parameters and ordering

2017-10-24 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/madlib/pull/191 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/madlib-pr-build/263/ ---

[GitHub] madlib pull request #191: KNN: Fix optional parameters and ordering

2017-10-24 Thread jingyimei
Github user jingyimei commented on a diff in the pull request: https://github.com/apache/madlib/pull/191#discussion_r146700914 --- Diff: src/ports/postgres/modules/knn/knn.py_in --- @@ -160,20 +164,23 @@ def knn(schema_madlib, point_source, point_column_name, point_id,

[GitHub] madlib pull request #191: KNN: Fix optional parameters and ordering

2017-10-24 Thread jingyimei
Github user jingyimei commented on a diff in the pull request: https://github.com/apache/madlib/pull/191#discussion_r146700815 --- Diff: src/ports/postgres/modules/knn/knn.sql_in --- @@ -96,19 +95,19 @@ in a column of type DOUBLE PRECISION[]. point_id TEXT. Name of

[GitHub] madlib pull request #191: KNN: Fix optional parameters and ordering

2017-10-24 Thread jingyimei
Github user jingyimei commented on a diff in the pull request: https://github.com/apache/madlib/pull/191#discussion_r146701746 --- Diff: src/ports/postgres/modules/knn/knn.sql_in --- @@ -218,56 +215,57 @@ INSERT INTO knn_test_data VALUES -# Run KNN for classification:

[GitHub] madlib issue #191: KNN: Fix optional parameters and ordering

2017-10-24 Thread iyerr3
Github user iyerr3 commented on the issue: https://github.com/apache/madlib/pull/191 jenkins ok to retest ---

[GitHub] madlib pull request #191: KNN: Fix optional parameters and ordering

2017-10-24 Thread iyerr3
Github user iyerr3 commented on a diff in the pull request: https://github.com/apache/madlib/pull/191#discussion_r146702427 --- Diff: src/ports/postgres/modules/knn/knn.py_in --- @@ -135,13 +135,17 @@ def knn(schema_madlib, point_source, point_column_name, point_id, label_column_n

[GitHub] madlib pull request #191: KNN: Fix optional parameters and ordering

2017-10-24 Thread iyerr3
Github user iyerr3 commented on a diff in the pull request: https://github.com/apache/madlib/pull/191#discussion_r146702329 --- Diff: src/ports/postgres/modules/knn/knn.py_in --- @@ -135,13 +135,17 @@ def knn(schema_madlib, point_source, point_column_name, point_id, label_column_n

[GitHub] madlib pull request #191: KNN: Fix optional parameters and ordering

2017-10-24 Thread iyerr3
Github user iyerr3 commented on a diff in the pull request: https://github.com/apache/madlib/pull/191#discussion_r146703574 --- Diff: src/ports/postgres/modules/knn/knn.py_in --- @@ -215,7 +222,8 @@ def knn(schema_madlib, point_source, point_column_name, point_id, label_column_n

[GitHub] madlib pull request #191: KNN: Fix optional parameters and ordering

2017-10-24 Thread iyerr3
Github user iyerr3 commented on a diff in the pull request: https://github.com/apache/madlib/pull/191#discussion_r146646995 --- Diff: src/ports/postgres/modules/knn/knn.py_in --- @@ -135,13 +135,17 @@ def knn(schema_madlib, point_source, point_column_name, point_id, label_column_n

[GitHub] madlib issue #191: KNN: Fix optional parameters and ordering

2017-10-24 Thread orhankislal
Github user orhankislal commented on the issue: https://github.com/apache/madlib/pull/191 jenkins ok to test ---

Seg fault when using postgis and madlib at the same time

2017-10-24 Thread James Gregory
When running queries that make use of both madlib cosine_similarity and postgis ST_Intersects, with often get segmentation faults. It doesn't happen 100% of the time - perhaps it needs multiple queries running in parallel to make the segfault happen, or it might be some other random thing that