[GitHub] madlib pull request #251: MLP: Simplify initialization of model coefficients

2018-03-27 Thread iyerr3
GitHub user iyerr3 opened a pull request: https://github.com/apache/madlib/pull/251 MLP: Simplify initialization of model coefficients Changes: 1. Model initialization now happens in the C++ code instead of being passed via Python. 2. Warm start coefficients are

[GitHub] madlib pull request #249: RF: Use NULL::integer[] when no continuous feature...

2018-03-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/madlib/pull/249 ---

[GitHub] madlib pull request #246: DT and RF user doc updates

2018-03-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/madlib/pull/246 ---

[GitHub] madlib issue #249: RF: Use NULL::integer[] when no continuous features

2018-03-27 Thread kaknikhil
Github user kaknikhil commented on the issue: https://github.com/apache/madlib/pull/249 The changes look good. +1 for adding an install check test. I noticed that `con_features` is populated by `decision_tree.py:_classify_features` which does something like `con_types =

[GitHub] madlib pull request #248: DT: Ensure proper quoting in grouping coalesce

2018-03-27 Thread iyerr3
Github user iyerr3 commented on a diff in the pull request: https://github.com/apache/madlib/pull/248#discussion_r177503935 --- Diff: src/ports/postgres/modules/recursive_partitioning/decision_tree.py_in --- @@ -970,16 +970,35 @@ def _get_bins_grps(

[GitHub] madlib pull request #248: DT: Ensure proper quoting in grouping coalesce

2018-03-27 Thread njayaram2
Github user njayaram2 commented on a diff in the pull request: https://github.com/apache/madlib/pull/248#discussion_r177495864 --- Diff: src/ports/postgres/modules/recursive_partitioning/decision_tree.py_in --- @@ -970,16 +970,35 @@ def _get_bins_grps(