[GitHub] madlib pull request #253: MLP: Add install check tests for minibatch with gr...

2018-03-29 Thread kaknikhil
Github user kaknikhil closed the pull request at: https://github.com/apache/madlib/pull/253 ---

[GitHub] madlib issue #253: MLP: Add install check tests for minibatch with grouping

2018-03-29 Thread kaknikhil
Github user kaknikhil commented on the issue: https://github.com/apache/madlib/pull/253 Closed by ab7166ff4fc55311ec29bb8b54d17becd9bb1750 ---

[GitHub] madlib pull request #251: MLP: Simplify initialization of model coefficients

2018-03-29 Thread iyerr3
Github user iyerr3 commented on a diff in the pull request: https://github.com/apache/madlib/pull/251#discussion_r178204767 --- Diff: src/modules/convex/mlp_igd.cpp --- @@ -98,23 +98,28 @@ mlp_igd_transition::run(AnyType ) { double is_classification_double =

[GitHub] madlib pull request #251: MLP: Simplify initialization of model coefficients

2018-03-29 Thread njayaram2
Github user njayaram2 commented on a diff in the pull request: https://github.com/apache/madlib/pull/251#discussion_r178204067 --- Diff: src/modules/convex/mlp_igd.cpp --- @@ -98,23 +98,28 @@ mlp_igd_transition::run(AnyType ) { double is_classification_double

[GitHub] madlib issue #250: MLP: Allow one-hot encoded dependent var for classificati...

2018-03-29 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/madlib/pull/250 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/madlib-pr-build/416/ ---

[GitHub] madlib pull request #250: MLP: Allow one-hot encoded dependent var for class...

2018-03-29 Thread njayaram2
Github user njayaram2 commented on a diff in the pull request: https://github.com/apache/madlib/pull/250#discussion_r178167691 --- Diff: src/ports/postgres/modules/convex/mlp_igd.py_in --- @@ -667,7 +678,8 @@ def _validate_dependent_var(source_table, dependent_varname,

[GitHub] madlib pull request #250: MLP: Allow one-hot encoded dependent var for class...

2018-03-29 Thread njayaram2
Github user njayaram2 commented on a diff in the pull request: https://github.com/apache/madlib/pull/250#discussion_r178168389 --- Diff: src/ports/postgres/modules/convex/mlp_igd.py_in --- @@ -856,8 +868,16 @@ def mlp_predict(schema_madlib, model_table, data_table, id_col_name,

[GitHub] madlib pull request #250: MLP: Allow one-hot encoded dependent var for class...

2018-03-29 Thread njayaram2
Github user njayaram2 commented on a diff in the pull request: https://github.com/apache/madlib/pull/250#discussion_r178168247 --- Diff: src/ports/postgres/modules/convex/mlp_igd.py_in --- @@ -667,7 +678,8 @@ def _validate_dependent_var(source_table, dependent_varname,

[GitHub] madlib pull request #250: MLP: Allow one-hot encoded dependent var for class...

2018-03-29 Thread njayaram2
Github user njayaram2 commented on a diff in the pull request: https://github.com/apache/madlib/pull/250#discussion_r178168263 --- Diff: src/ports/postgres/modules/convex/mlp_igd.py_in --- @@ -667,7 +678,8 @@ def _validate_dependent_var(source_table, dependent_varname,

[GitHub] madlib issue #251: MLP: Simplify initialization of model coefficients

2018-03-29 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/madlib/pull/251 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/madlib-pr-build/415/ ---

[GitHub] madlib issue #251: MLP: Simplify initialization of model coefficients

2018-03-29 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/madlib/pull/251 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/madlib-pr-build/414/ ---

[GitHub] madlib pull request #250: MLP: Allow one-hot encoded dependent var for class...

2018-03-29 Thread kaknikhil
Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/250#discussion_r177912997 --- Diff: src/ports/postgres/modules/convex/mlp_igd.py_in --- @@ -667,7 +678,8 @@ def _validate_dependent_var(source_table, dependent_varname,

[GitHub] madlib pull request #250: MLP: Allow one-hot encoded dependent var for class...

2018-03-29 Thread kaknikhil
Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/250#discussion_r177912480 --- Diff: src/ports/postgres/modules/convex/mlp_igd.py_in --- @@ -667,7 +678,8 @@ def _validate_dependent_var(source_table, dependent_varname,

[GitHub] madlib pull request #250: MLP: Allow one-hot encoded dependent var for class...

2018-03-29 Thread kaknikhil
Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/250#discussion_r177913869 --- Diff: src/ports/postgres/modules/convex/mlp_igd.py_in --- @@ -856,8 +868,16 @@ def mlp_predict(schema_madlib, model_table, data_table, id_col_name,

[GitHub] madlib issue #253: MLP: Add install check tests for minibatch with grouping

2018-03-29 Thread iyerr3
Github user iyerr3 commented on the issue: https://github.com/apache/madlib/pull/253 LGTM ---