Github user kaknikhil closed the pull request at:
https://github.com/apache/madlib/pull/253
---
Github user kaknikhil commented on the issue:
https://github.com/apache/madlib/pull/253
Closed by ab7166ff4fc55311ec29bb8b54d17becd9bb1750
---
Github user iyerr3 commented on a diff in the pull request:
https://github.com/apache/madlib/pull/251#discussion_r178204767
--- Diff: src/modules/convex/mlp_igd.cpp ---
@@ -98,23 +98,28 @@ mlp_igd_transition::run(AnyType ) {
double is_classification_double =
Github user njayaram2 commented on a diff in the pull request:
https://github.com/apache/madlib/pull/251#discussion_r178204067
--- Diff: src/modules/convex/mlp_igd.cpp ---
@@ -98,23 +98,28 @@ mlp_igd_transition::run(AnyType ) {
double is_classification_double
Github user asfgit commented on the issue:
https://github.com/apache/madlib/pull/250
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/madlib-pr-build/416/
---
Github user njayaram2 commented on a diff in the pull request:
https://github.com/apache/madlib/pull/250#discussion_r178167691
--- Diff: src/ports/postgres/modules/convex/mlp_igd.py_in ---
@@ -667,7 +678,8 @@ def _validate_dependent_var(source_table,
dependent_varname,
Github user njayaram2 commented on a diff in the pull request:
https://github.com/apache/madlib/pull/250#discussion_r178168389
--- Diff: src/ports/postgres/modules/convex/mlp_igd.py_in ---
@@ -856,8 +868,16 @@ def mlp_predict(schema_madlib, model_table,
data_table, id_col_name,
Github user njayaram2 commented on a diff in the pull request:
https://github.com/apache/madlib/pull/250#discussion_r178168247
--- Diff: src/ports/postgres/modules/convex/mlp_igd.py_in ---
@@ -667,7 +678,8 @@ def _validate_dependent_var(source_table,
dependent_varname,
Github user njayaram2 commented on a diff in the pull request:
https://github.com/apache/madlib/pull/250#discussion_r178168263
--- Diff: src/ports/postgres/modules/convex/mlp_igd.py_in ---
@@ -667,7 +678,8 @@ def _validate_dependent_var(source_table,
dependent_varname,
Github user asfgit commented on the issue:
https://github.com/apache/madlib/pull/251
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/madlib-pr-build/415/
---
Github user asfgit commented on the issue:
https://github.com/apache/madlib/pull/251
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/madlib-pr-build/414/
---
Github user kaknikhil commented on a diff in the pull request:
https://github.com/apache/madlib/pull/250#discussion_r177912997
--- Diff: src/ports/postgres/modules/convex/mlp_igd.py_in ---
@@ -667,7 +678,8 @@ def _validate_dependent_var(source_table,
dependent_varname,
Github user kaknikhil commented on a diff in the pull request:
https://github.com/apache/madlib/pull/250#discussion_r177912480
--- Diff: src/ports/postgres/modules/convex/mlp_igd.py_in ---
@@ -667,7 +678,8 @@ def _validate_dependent_var(source_table,
dependent_varname,
Github user kaknikhil commented on a diff in the pull request:
https://github.com/apache/madlib/pull/250#discussion_r177913869
--- Diff: src/ports/postgres/modules/convex/mlp_igd.py_in ---
@@ -856,8 +868,16 @@ def mlp_predict(schema_madlib, model_table,
data_table, id_col_name,
Github user iyerr3 commented on the issue:
https://github.com/apache/madlib/pull/253
LGTM
---
15 matches
Mail list logo