[GitHub] madlib issue #282: Utilites: Add CTAS while dropping some columns

2018-07-11 Thread iyerr3
Github user iyerr3 commented on the issue: https://github.com/apache/madlib/pull/282 That's just the way it has to be if it needs to be a link (bold) like the other functions. There are some other functions in that list that have parameters and you can get their info by

[GitHub] madlib issue #282: Utilites: Add CTAS while dropping some columns

2018-07-11 Thread fmcquillan99
Github user fmcquillan99 commented on the issue: https://github.com/apache/madlib/pull/282 looks like user docs lost the params description for dropcols() ---

[GitHub] madlib issue #282: Utilites: Add CTAS while dropping some columns

2018-07-11 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/madlib/pull/282 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/madlib-pr-build/550/ ---

[GitHub] madlib pull request #291: Feature: Vector to Columns

2018-07-11 Thread iyerr3
Github user iyerr3 commented on a diff in the pull request: https://github.com/apache/madlib/pull/291#discussion_r201876969 --- Diff: src/ports/postgres/modules/internal/test/unit_tests/test_db_utils.py_in --- @@ -0,0 +1,60 @@ +# coding=utf-8 +# +# Licensed to the

[GitHub] madlib pull request #291: Feature: Vector to Columns

2018-07-11 Thread iyerr3
Github user iyerr3 commented on a diff in the pull request: https://github.com/apache/madlib/pull/291#discussion_r201877031 --- Diff: src/ports/postgres/modules/utilities/test/unit_tests/test_utilities.py_in --- @@ -243,6 +243,9 @@ class UtilitiesTestCase(unittest.TestCase):

[GitHub] madlib pull request #290: madpack: Add madpack option to run unit tests.

2018-07-11 Thread iyerr3
Github user iyerr3 commented on a diff in the pull request: https://github.com/apache/madlib/pull/290#discussion_r201876197 --- Diff: src/ports/postgres/modules/convex/test/unit_tests/test_mlp_igd.py_in --- @@ -126,10 +126,11 @@ class MLPMiniBatchTestCase(unittest.TestCase):

[GitHub] madlib issue #282: Utilites: Add CTAS while dropping some columns

2018-07-11 Thread iyerr3
Github user iyerr3 commented on the issue: https://github.com/apache/madlib/pull/282 @fmcquillan99 Suggested changes have been made in latest commit. ---

[GitHub] madlib issue #290: madpack: Add madpack option to run unit tests.

2018-07-11 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/madlib/pull/290 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/madlib-pr-build/548/ ---

[GitHub] madlib issue #290: madpack: Add madpack option to run unit tests.

2018-07-11 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/madlib/pull/290 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/madlib-pr-build/547/ ---

[GitHub] madlib issue #290: madpack: Add madpack option to run unit tests.

2018-07-11 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/madlib/pull/290 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/madlib-pr-build/546/ ---

[GitHub] madlib pull request #291: Feature: Vector to Columns

2018-07-11 Thread ArvindSridhar
GitHub user ArvindSridhar opened a pull request: https://github.com/apache/madlib/pull/291 Feature: Vector to Columns JIRA: MADLIB-1240 The vec2cols function enables users to split up a single column into multiple columns, given that the input column contains array entries. For

[GitHub] madlib issue #282: Utilites: Add CTAS while dropping some columns

2018-07-11 Thread fmcquillan99
Github user fmcquillan99 commented on the issue: https://github.com/apache/madlib/pull/282 There is a bit of inconsistency related to the last param `cols_to_drop` ``` SELECT madlib.dropcols( 'houses', 'houses_out',

[GitHub] madlib issue #290: madpack: Add madpack option to run unit tests.

2018-07-11 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/madlib/pull/290 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/madlib-pr-build/544/ ---

[GitHub] madlib pull request #290: madpack: Add madpack option to run unit tests.

2018-07-11 Thread njayaram2
GitHub user njayaram2 opened a pull request: https://github.com/apache/madlib/pull/290 madpack: Add madpack option to run unit tests. JIRA: MADLIB-1252 Unit tests in MADlib are written in python files, that are located in the .../test/unit_tests/ folders, whose names

[GitHub] madlib issue #287: Fix incorrect dict expansion in table header

2018-07-11 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/madlib/pull/287 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/madlib-pr-build/543/ ---

[GitHub] madlib issue #287: Fix incorrect dict expansion in table header

2018-07-11 Thread fmcquillan99
Github user fmcquillan99 commented on the issue: https://github.com/apache/madlib/pull/287 This latest commit makes the following changes to use docs: 1) clarify cv for SVM and add user examples 2) clarify cv for elastic net and fix user examples 3) correct rmse calc

[GitHub] madlib pull request #289: RF: Add impurity variable importance

2018-07-11 Thread iyerr3
Github user iyerr3 commented on a diff in the pull request: https://github.com/apache/madlib/pull/289#discussion_r201728550 --- Diff: src/modules/recursive_partitioning/DT_impl.hpp --- @@ -1512,6 +1512,9 @@ DecisionTree::computeVariableImportance( uint64_t