Github user asfgit closed the pull request at:
https://github.com/apache/madlib/pull/250
---
Github user njayaram2 commented on a diff in the pull request:
https://github.com/apache/madlib/pull/250#discussion_r178167691
--- Diff: src/ports/postgres/modules/convex/mlp_igd.py_in ---
@@ -667,7 +678,8 @@ def _validate_dependent_var(source_table,
dependent_varname,
Github user njayaram2 commented on a diff in the pull request:
https://github.com/apache/madlib/pull/250#discussion_r178168389
--- Diff: src/ports/postgres/modules/convex/mlp_igd.py_in ---
@@ -856,8 +868,16 @@ def mlp_predict(schema_madlib, model_table,
data_table, id_col_name,
Github user njayaram2 commented on a diff in the pull request:
https://github.com/apache/madlib/pull/250#discussion_r178168247
--- Diff: src/ports/postgres/modules/convex/mlp_igd.py_in ---
@@ -667,7 +678,8 @@ def _validate_dependent_var(source_table,
dependent_varname,
Github user njayaram2 commented on a diff in the pull request:
https://github.com/apache/madlib/pull/250#discussion_r178168263
--- Diff: src/ports/postgres/modules/convex/mlp_igd.py_in ---
@@ -667,7 +678,8 @@ def _validate_dependent_var(source_table,
dependent_varname,
Github user kaknikhil commented on a diff in the pull request:
https://github.com/apache/madlib/pull/250#discussion_r177912997
--- Diff: src/ports/postgres/modules/convex/mlp_igd.py_in ---
@@ -667,7 +678,8 @@ def _validate_dependent_var(source_table,
dependent_varname,
Github user kaknikhil commented on a diff in the pull request:
https://github.com/apache/madlib/pull/250#discussion_r177912480
--- Diff: src/ports/postgres/modules/convex/mlp_igd.py_in ---
@@ -667,7 +678,8 @@ def _validate_dependent_var(source_table,
dependent_varname,
Github user kaknikhil commented on a diff in the pull request:
https://github.com/apache/madlib/pull/250#discussion_r177913869
--- Diff: src/ports/postgres/modules/convex/mlp_igd.py_in ---
@@ -856,8 +868,16 @@ def mlp_predict(schema_madlib, model_table,
data_table, id_col_name,
GitHub user njayaram2 opened a pull request:
https://github.com/apache/madlib/pull/250
MLP: Allow one-hot encoded dependent var for classification
JIRA:MADLIB-1222
MLP currently automatically encodes categorical variables for
classification but does not allow already