[GitHub] madlib issue #249: RF: Use NULL::integer[] when no continuous features

2018-03-27 Thread kaknikhil 
Github user kaknikhil commented on the issue:

https://github.com/apache/madlib/pull/249
  
The changes look good. +1 for adding an install check test.

I noticed that `con_features` is populated by 
`decision_tree.py:_classify_features` which does something like `con_types = 
['real', 'float8', 'double precision', 'numeric']`. Is it better to call the 
utilities function `is_psql_numeric_type`  ? 


---

[GitHub] madlib issue #249: RF: Use NULL::integer[] when no continuous features

2018-03-26 Thread asfgit 
Github user asfgit commented on the issue:

https://github.com/apache/madlib/pull/249
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/madlib-pr-build/406/



---

[GitHub] madlib issue #249: RF: Use NULL::integer[] when no continuous features

2018-03-26 Thread fmcquillan99 
Github user fmcquillan99 commented on the issue:

https://github.com/apache/madlib/pull/249
  
See https://issues.apache.org/jira/browse/MADLIB-1219 for results from my 
tests.

LGTM



---

[GitHub] madlib issue #249: RF: Use NULL::integer[] when no continuous features

2018-03-25 Thread asfgit 
Github user asfgit commented on the issue:

https://github.com/apache/madlib/pull/249
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/madlib-pr-build/402/



---