[GitHub] madlib pull request #338: Install/Dev check: Add new test cases for some mod...

2018-11-15 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/madlib/pull/338


---


[GitHub] madlib pull request #338: Install/Dev check: Add new test cases for some mod...

2018-11-15 Thread kaknikhil
Github user kaknikhil commented on a diff in the pull request:

https://github.com/apache/madlib/pull/338#discussion_r234052747
  
--- Diff: src/ports/postgres/modules/pmml/test/pmml.ic.sql_in ---
@@ -0,0 +1,119 @@
+/* --- 
*//**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ *
+ *//* 
--- */
+DROP TABLE IF EXISTS abalone CASCADE;
+
+CREATE TABLE abalone (
+id integer,
+sex text,
+length double precision,
+diameter double precision,
+height double precision,
+whole double precision,
+shucked double precision,
+viscera double precision,
+shell double precision,
+rings integer
+);
+
+INSERT INTO abalone VALUES
+(3151, 'F', 0.655027, 0.505004, 
0.165008, 1.36699, 0.583519, 
0.351479, 0.396019, 10),
--- End diff --

Since this is an install check test, can we cut down on the dataset size 
and call the `glm` and the `pmml` functions only once. 


---


[GitHub] madlib pull request #338: Install/Dev check: Add new test cases for some mod...

2018-11-15 Thread njayaram2
GitHub user njayaram2 opened a pull request:

https://github.com/apache/madlib/pull/338

Install/Dev check: Add new test cases for some modules

Some modules such as array_ops and pmml did not have any install check
files, while stemmer did not have any test files. This commit adds some
basic test cases for these modules.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/madlib/madlib ic-pmml-stemmer

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/madlib/pull/338.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #338


commit c351f176b305fb44bd87bc6a4f79c099a3d6fbe3
Author: Nandish Jayaram 
Date:   2018-09-29T00:15:40Z

Install/Dev check: Add new test cases for some modules

Some modules such as array_ops and pmml did not have any install check
files, while stemmer did not have any test files. This commit adds some
basic test cases for these modules.




---