[GitHub] incubator-madlib pull request #174: Change test_train_split to train_test_sp...

2017-08-18 Thread orhankislal
GitHub user orhankislal opened a pull request: https://github.com/apache/incubator-madlib/pull/174 Change test_train_split to train_test_split You can merge this pull request into a Git repository by running: $ git pull https://github.com/orhankislal/incubator-madlib

[GitHub] incubator-madlib pull request #165: Release 1.12: Version numbering and upgr...

2017-08-17 Thread orhankislal
Github user orhankislal commented on a diff in the pull request: https://github.com/apache/incubator-madlib/pull/165#discussion_r133772221 --- Diff: src/madpack/changelist.yaml --- @@ -9,27 +9,39 @@ # file installed on the upgrade version. All other files (that don't have

[GitHub] incubator-madlib pull request #166: Sample: test_train_split

2017-08-14 Thread orhankislal
Github user orhankislal commented on a diff in the pull request: https://github.com/apache/incubator-madlib/pull/166#discussion_r133094253 --- Diff: src/ports/postgres/modules/sample/test_train_split.py_in --- @@ -0,0 +1,311 @@ +# coding=utf-8 +# +# Licensed

[GitHub] incubator-madlib pull request #166: Sample: test_train_split

2017-08-14 Thread orhankislal
Github user orhankislal commented on a diff in the pull request: https://github.com/apache/incubator-madlib/pull/166#discussion_r133094303 --- Diff: src/ports/postgres/modules/sample/test_train_split.py_in --- @@ -0,0 +1,311 @@ +# coding=utf-8 +# +# Licensed

[GitHub] incubator-madlib pull request #166: Sample: test_train_split

2017-08-14 Thread orhankislal
Github user orhankislal commented on a diff in the pull request: https://github.com/apache/incubator-madlib/pull/166#discussion_r133093991 --- Diff: src/ports/postgres/modules/sample/test_train_split.sql_in --- @@ -0,0 +1,321

[GitHub] incubator-madlib pull request #167: Update RELEASE_NOTES for v1.12 release

2017-08-14 Thread orhankislal
GitHub user orhankislal opened a pull request: https://github.com/apache/incubator-madlib/pull/167 Update RELEASE_NOTES for v1.12 release You can merge this pull request into a Git repository by running: $ git pull https://github.com/orhankislal/incubator-madlib release

[GitHub] incubator-madlib pull request #165: Release 1.12: Version numbering and upgr...

2017-08-11 Thread orhankislal
Github user orhankislal commented on a diff in the pull request: https://github.com/apache/incubator-madlib/pull/165#discussion_r132792819 --- Diff: deploy/gppkg/madlib.spec.in --- @@ -7,7 +7,7 @@ BuildRoot: @MADLIB_GPPKG_RPM_SOURCE_DIR@ Summary:Apache MADlib

[GitHub] incubator-madlib pull request #165: Release 1.12: Version numbering and upgr...

2017-08-11 Thread orhankislal
Github user orhankislal commented on a diff in the pull request: https://github.com/apache/incubator-madlib/pull/165#discussion_r132792193 --- Diff: deploy/gppkg/madlib.spec.in --- @@ -7,7 +7,7 @@ BuildRoot: @MADLIB_GPPKG_RPM_SOURCE_DIR@ Summary:Apache MADlib

[GitHub] incubator-madlib pull request #165: Release 1.12: Version numbering and upgr...

2017-08-10 Thread orhankislal
GitHub user orhankislal opened a pull request: https://github.com/apache/incubator-madlib/pull/165 Release 1.12: Version numbering and upgrade related changes Updates the version number to 1.12 for the release candidate. Updates the changelists and other related files

[GitHub] incubator-madlib issue #162: MLP: Multilayer Perceptron Phase 2

2017-08-10 Thread orhankislal
Github user orhankislal commented on the issue: https://github.com/apache/incubator-madlib/pull/162 GPDB 5 IC passes as well. LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-madlib pull request #162: MLP: Multilayer Perceptron Phase 2

2017-08-10 Thread orhankislal
Github user orhankislal commented on a diff in the pull request: https://github.com/apache/incubator-madlib/pull/162#discussion_r132541348 --- Diff: src/ports/postgres/modules/convex/test/mlp.sql_in --- @@ -241,9 +247,8 @@ SELECT mlp_predict( select * from mlp_prediction

[GitHub] incubator-madlib pull request #162: MLP: Multilayer Perceptron Phase 2

2017-08-10 Thread orhankislal
Github user orhankislal commented on a diff in the pull request: https://github.com/apache/incubator-madlib/pull/162#discussion_r132541507 --- Diff: src/ports/postgres/modules/convex/test/mlp.sql_in --- @@ -241,9 +247,8 @@ SELECT mlp_predict( select * from mlp_prediction

[GitHub] incubator-madlib issue #157: Multiple: Check optimizer_control before updati...

2017-08-07 Thread orhankislal
Github user orhankislal commented on the issue: https://github.com/apache/incubator-madlib/pull/157 LGTM +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-madlib pull request #158: MADLIB-1133. TLP graduation - remove ref...

2017-08-03 Thread orhankislal
Github user orhankislal commented on a diff in the pull request: https://github.com/apache/incubator-madlib/pull/158#discussion_r131209570 --- Diff: tool/jenkins/rat_check.sh --- @@ -22,15 +22,16 @@ set -exu workdir=`pwd` +reponame=incubator-madlib --- End

[GitHub] incubator-madlib issue #157: Multiple: Check optimizer_control before updati...

2017-08-02 Thread orhankislal
Github user orhankislal commented on the issue: https://github.com/apache/incubator-madlib/pull/157 Tested on GPDB 4.3.12. kmeans IC fails with the following error: ``` SELECT * FROM kmeanspp('kmeans_2d', 'position', 10); psql:/tmp/madlib.tPVzko/kmeans/test

[GitHub] incubator-madlib pull request #154: Graph/bugs

2017-08-01 Thread orhankislal
Github user orhankislal commented on a diff in the pull request: https://github.com/apache/incubator-madlib/pull/154#discussion_r130721434 --- Diff: src/ports/postgres/modules/graph/bfs.py_in --- @@ -47,8 +48,8 @@ def _validate_bfs(vertex_table, vertex_id, edge_table, edge_params

[GitHub] incubator-madlib issue #154: Graph/bugs

2017-07-31 Thread orhankislal
Github user orhankislal commented on the issue: https://github.com/apache/incubator-madlib/pull/154 @iyerr3 Do you have any other comments on this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] incubator-madlib issue #155: Feature: Weakly connected components helper fun...

2017-07-28 Thread orhankislal
Github user orhankislal commented on the issue: https://github.com/apache/incubator-madlib/pull/155 LGTM +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-madlib issue #154: Graph/bugs

2017-07-27 Thread orhankislal
Github user orhankislal commented on the issue: https://github.com/apache/incubator-madlib/pull/154 Thanks for the comments. I'll fix them right away. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] incubator-madlib pull request #152: Feature/graph measures 1

2017-07-24 Thread orhankislal
Github user orhankislal commented on a diff in the pull request: https://github.com/apache/incubator-madlib/pull/152#discussion_r129121134 --- Diff: src/ports/postgres/modules/graph/measures.sql_in --- @@ -0,0 +1,820

[GitHub] incubator-madlib pull request #152: Feature/graph measures 1

2017-07-24 Thread orhankislal
Github user orhankislal commented on a diff in the pull request: https://github.com/apache/incubator-madlib/pull/152#discussion_r129096107 --- Diff: src/ports/postgres/modules/graph/test/measures.sql_in --- @@ -0,0 +1,150

[GitHub] incubator-madlib pull request #152: Feature/graph measures 1

2017-07-24 Thread orhankislal
Github user orhankislal commented on a diff in the pull request: https://github.com/apache/incubator-madlib/pull/152#discussion_r129095148 --- Diff: src/ports/postgres/modules/graph/measures.sql_in --- @@ -0,0 +1,820

[GitHub] incubator-madlib issue #151: MADLIB-1138. Add basic code coverage support:

2017-07-21 Thread orhankislal
Github user orhankislal commented on the issue: https://github.com/apache/incubator-madlib/pull/151 Tested on OS X and Linux. LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-madlib issue #146: CI: Add concourse scripts for testing with GPDB...

2017-07-11 Thread orhankislal
Github user orhankislal commented on the issue: https://github.com/apache/incubator-madlib/pull/146 Closing the pull request since the proposed pipeline is too dependent on the GPDB scripts. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] incubator-madlib issue #144: Feautre: Weakly Connected Components

2017-06-28 Thread orhankislal
Github user orhankislal commented on the issue: https://github.com/apache/incubator-madlib/pull/144 LGTM +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-madlib pull request #144: Feautre: Weakly Connected Components

2017-06-28 Thread orhankislal
Github user orhankislal commented on a diff in the pull request: https://github.com/apache/incubator-madlib/pull/144#discussion_r124611697 --- Diff: src/ports/postgres/modules/graph/wcc.sql_in --- @@ -0,0 +1,261

[GitHub] incubator-madlib pull request #144: Feautre: Weakly Connected Components

2017-06-28 Thread orhankislal
Github user orhankislal commented on a diff in the pull request: https://github.com/apache/incubator-madlib/pull/144#discussion_r124604406 --- Diff: src/ports/postgres/modules/graph/test/wcc.sql_in --- @@ -0,0 +1,92

[GitHub] incubator-madlib pull request #142: DT: Include NULL rows in count for termi...

2017-06-23 Thread orhankislal
Github user orhankislal commented on a diff in the pull request: https://github.com/apache/incubator-madlib/pull/142#discussion_r123856874 --- Diff: src/modules/recursive_partitioning/DT_impl.hpp --- @@ -486,8 +485,18 @@ DecisionTree::expand(const Accumulator

[GitHub] incubator-madlib pull request #142: DT: Include NULL rows in count for termi...

2017-06-22 Thread orhankislal
Github user orhankislal commented on a diff in the pull request: https://github.com/apache/incubator-madlib/pull/142#discussion_r123618828 --- Diff: src/modules/recursive_partitioning/DT_impl.hpp --- @@ -486,8 +485,18 @@ DecisionTree::expand(const Accumulator

[GitHub] incubator-madlib pull request #142: DT: Include NULL rows in count for termi...

2017-06-22 Thread orhankislal
Github user orhankislal commented on a diff in the pull request: https://github.com/apache/incubator-madlib/pull/142#discussion_r123577006 --- Diff: src/modules/recursive_partitioning/DT_impl.hpp --- @@ -486,8 +485,18 @@ DecisionTree::expand(const Accumulator

[GitHub] incubator-madlib pull request #142: DT: Include NULL rows in count for termi...

2017-06-22 Thread orhankislal
Github user orhankislal commented on a diff in the pull request: https://github.com/apache/incubator-madlib/pull/142#discussion_r123573305 --- Diff: src/modules/recursive_partitioning/DT_impl.hpp --- @@ -446,21 +446,20 @@ DecisionTree::updatePrimarySplit( predictions.row

[GitHub] incubator-madlib pull request #143: Sample: Add stratified sampling

2017-06-21 Thread orhankislal
GitHub user orhankislal opened a pull request: https://github.com/apache/incubator-madlib/pull/143 Sample: Add stratified sampling JIRA: MADLIB-986 Add stratified sampling with the following options. - With or without grouping - With or without replacement

[GitHub] incubator-madlib pull request #140: APSP: Remove multiple updates for GPDB c...

2017-06-14 Thread orhankislal
Github user orhankislal closed the pull request at: https://github.com/apache/incubator-madlib/pull/140 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-madlib issue #136: Graph: Add APSP with grouping

2017-05-25 Thread orhankislal
Github user orhankislal commented on the issue: https://github.com/apache/incubator-madlib/pull/136 @raghur1 I was trying to avoid the distinct on clause to speed up the implementation but you are right to point this out, this output is not correct. Should be fixed with my latest

[GitHub] incubator-madlib pull request #136: Graph: Add APSP with grouping

2017-05-17 Thread orhankislal
GitHub user orhankislal opened a pull request: https://github.com/apache/incubator-madlib/pull/136 Graph: Add APSP with grouping JIRA: MADLIB-1099 - Add all pairs shortest path algorithm with grouping support. This algorithm provides the minimum cost (sum of edge

[GitHub] incubator-madlib pull request #133: Build: Add CDATA block to avoid invalid ...

2017-05-16 Thread orhankislal
Github user orhankislal commented on a diff in the pull request: https://github.com/apache/incubator-madlib/pull/133#discussion_r116803630 --- Diff: src/ports/postgres/modules/recursive_partitioning/test/random_forest.sql_in --- @@ -9,6 +9,8 @@ CREATE TABLE dt_golf

[GitHub] incubator-madlib pull request #120: DT: Assign memory only for reachable nod...

2017-04-19 Thread orhankislal
Github user orhankislal commented on a diff in the pull request: https://github.com/apache/incubator-madlib/pull/120#discussion_r112341893 --- Diff: src/modules/recursive_partitioning/decision_tree.cpp --- @@ -235,7 +259,14 @@ dt_apply::run(AnyType & args){

[GitHub] incubator-madlib pull request #121: Release 1.11: Upgrade related changes

2017-04-19 Thread orhankislal
Github user orhankislal commented on a diff in the pull request: https://github.com/apache/incubator-madlib/pull/121#discussion_r112305864 --- Diff: src/madpack/changelist_1.9.1_1.11.yaml --- @@ -0,0 +1,126 @@ +# Changelist for MADlib version 1.9.1 to 1.11 --- End diff

[GitHub] incubator-madlib pull request #119: Multiple: Minor changes for GPDB5 and HA...

2017-04-18 Thread orhankislal
GitHub user orhankislal opened a pull request: https://github.com/apache/incubator-madlib/pull/119 Multiple: Minor changes for GPDB5 and HAWQ2.2 support - Separate multi-command plpy.execute commands - Disable some install check tests temporarily You can merge this pull request

[GitHub] incubator-madlib pull request #112: Feautre: Add grouping support for PageRa...

2017-04-11 Thread orhankislal
Github user orhankislal commented on a diff in the pull request: https://github.com/apache/incubator-madlib/pull/112#discussion_r111041205 --- Diff: src/ports/postgres/modules/graph/pagerank.py_in --- @@ -158,44 +313,198 @@ def pagerank(schema_madlib, vertex_table, vertex_id

[GitHub] incubator-madlib pull request #112: Feautre: Add grouping support for PageRa...

2017-04-11 Thread orhankislal
Github user orhankislal commented on a diff in the pull request: https://github.com/apache/incubator-madlib/pull/112#discussion_r111040473 --- Diff: src/ports/postgres/modules/graph/pagerank.py_in --- @@ -158,44 +313,198 @@ def pagerank(schema_madlib, vertex_table, vertex_id

[GitHub] incubator-madlib pull request #112: Feautre: Add grouping support for PageRa...

2017-04-11 Thread orhankislal
Github user orhankislal commented on a diff in the pull request: https://github.com/apache/incubator-madlib/pull/112#discussion_r111033008 --- Diff: src/ports/postgres/modules/graph/pagerank.py_in --- @@ -158,44 +313,198 @@ def pagerank(schema_madlib, vertex_table, vertex_id

[GitHub] incubator-madlib pull request #112: Feautre: Add grouping support for PageRa...

2017-04-11 Thread orhankislal
Github user orhankislal commented on a diff in the pull request: https://github.com/apache/incubator-madlib/pull/112#discussion_r111038142 --- Diff: src/ports/postgres/modules/graph/pagerank.py_in --- @@ -158,44 +313,198 @@ def pagerank(schema_madlib, vertex_table, vertex_id

[GitHub] incubator-madlib pull request #113: Graph: Add grouping support to SSSP

2017-04-07 Thread orhankislal
GitHub user orhankislal opened a pull request: https://github.com/apache/incubator-madlib/pull/113 Graph: Add grouping support to SSSP JIRA: MADLIB-1081 - This commit adds grouping support for SSSP as well as its path function. You can merge this pull request into a Git

[GitHub] incubator-madlib pull request #109: Feature: PageRank

2017-03-28 Thread orhankislal
Github user orhankislal commented on a diff in the pull request: https://github.com/apache/incubator-madlib/pull/109#discussion_r108511453 --- Diff: src/ports/postgres/modules/graph/pagerank.py_in --- @@ -0,0 +1,290 @@ +# coding=utf-8 +# +# Licensed to the Apache

[GitHub] incubator-madlib pull request #109: Feature: PageRank

2017-03-28 Thread orhankislal
Github user orhankislal commented on a diff in the pull request: https://github.com/apache/incubator-madlib/pull/109#discussion_r108298553 --- Diff: src/ports/postgres/modules/graph/pagerank.py_in --- @@ -0,0 +1,290 @@ +# coding=utf-8 +# +# Licensed to the Apache

[GitHub] incubator-madlib pull request #109: Feature: PageRank

2017-03-28 Thread orhankislal
Github user orhankislal commented on a diff in the pull request: https://github.com/apache/incubator-madlib/pull/109#discussion_r108503192 --- Diff: src/ports/postgres/modules/graph/pagerank.py_in --- @@ -0,0 +1,290 @@ +# coding=utf-8 +# +# Licensed to the Apache

[GitHub] incubator-madlib pull request #109: Feature: PageRank

2017-03-28 Thread orhankislal
Github user orhankislal commented on a diff in the pull request: https://github.com/apache/incubator-madlib/pull/109#discussion_r108299103 --- Diff: src/ports/postgres/modules/graph/pagerank.py_in --- @@ -0,0 +1,290 @@ +# coding=utf-8 +# +# Licensed to the Apache

[GitHub] incubator-madlib pull request #108: Pivot: Add support for array output

2017-03-23 Thread orhankislal
Github user orhankislal commented on a diff in the pull request: https://github.com/apache/incubator-madlib/pull/108#discussion_r10937 --- Diff: src/ports/postgres/modules/utilities/test/pivot.sql_in --- @@ -168,3 +168,17 @@ SELECT pivot('pivset_ext', 'pivout', 'id', 'piv

[GitHub] incubator-madlib pull request #105: Graph:

2017-03-06 Thread orhankislal
Github user orhankislal commented on a diff in the pull request: https://github.com/apache/incubator-madlib/pull/105#discussion_r104527390 --- Diff: src/ports/postgres/modules/graph/graph_utils.py_in --- @@ -0,0 +1,102 @@ +# coding=utf-8 +# +# Licensed to the Apache

[GitHub] incubator-madlib pull request #105: Graph:

2017-03-06 Thread orhankislal
Github user orhankislal commented on a diff in the pull request: https://github.com/apache/incubator-madlib/pull/105#discussion_r104521502 --- Diff: src/ports/postgres/modules/graph/graph_utils.py_in --- @@ -0,0 +1,102 @@ +# coding=utf-8 +# +# Licensed to the Apache

[GitHub] incubator-madlib issue #105: Graph:

2017-02-28 Thread orhankislal
Github user orhankislal commented on the issue: https://github.com/apache/incubator-madlib/pull/105 Thanks for the comments @iyerr3. I tried to reorganize the algorithm explanation a bit, please let me know what you think. --- If your project is set up for it, you can reply

[GitHub] incubator-madlib issue #106: Build: Fix module sort order for PGXN installat...

2017-02-27 Thread orhankislal
Github user orhankislal commented on the issue: https://github.com/apache/incubator-madlib/pull/106 LGTM +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-madlib pull request #100: Fix pom.xml to pass mvn apache-rat:check...

2017-02-12 Thread orhankislal
Github user orhankislal commented on a diff in the pull request: https://github.com/apache/incubator-madlib/pull/100#discussion_r100708801 --- Diff: pom.xml --- @@ -393,6 +395,7 @@ src/ports/greenplum/cmake/FindGreenplum_4_2.cmake src/ports

[GitHub] incubator-madlib pull request #100: Fix pom.xml to pass mvn apache-rat:check...

2017-02-12 Thread orhankislal
Github user orhankislal commented on a diff in the pull request: https://github.com/apache/incubator-madlib/pull/100#discussion_r100708526 --- Diff: configure --- @@ -22,6 +22,24 @@ cmake "$@" .. cd .. cat <Makefile +# +# Licensed to the Ap

[GitHub] incubator-madlib pull request #100: Fix pom.xml to pass mvn apache-rat:check...

2017-02-10 Thread orhankislal
Github user orhankislal commented on a diff in the pull request: https://github.com/apache/incubator-madlib/pull/100#discussion_r100578729 --- Diff: pom.xml --- @@ -393,6 +395,7 @@ src/ports/greenplum/cmake/FindGreenplum_4_2.cmake src/ports

[GitHub] incubator-madlib pull request #100: Fix pom.xml to pass mvn apache-rat:check...

2017-02-10 Thread orhankislal
Github user orhankislal commented on a diff in the pull request: https://github.com/apache/incubator-madlib/pull/100#discussion_r100577189 --- Diff: pom.xml --- @@ -45,6 +45,7 @@ ReadMe_Build.txt ReleaseNotes.txt licenses

[GitHub] incubator-madlib pull request #100: Fix pom.xml to pass mvn apache-rat:check...

2017-02-10 Thread orhankislal
Github user orhankislal commented on a diff in the pull request: https://github.com/apache/incubator-madlib/pull/100#discussion_r100578272 --- Diff: configure --- @@ -22,6 +22,24 @@ cmake "$@" .. cd .. cat <Makefile +# +# Licensed to the Ap

[GitHub] incubator-madlib pull request #100: Fix pom.xml to pass mvn apache-rat:check...

2017-02-10 Thread orhankislal
Github user orhankislal commented on a diff in the pull request: https://github.com/apache/incubator-madlib/pull/100#discussion_r100577548 --- Diff: pom.xml --- @@ -89,6 +90,7 @@ doc/design/modules/crf.tex doc/design/modules/decision-trees.tex

[GitHub] incubator-madlib pull request #100: Fix pom.xml to pass mvn apache-rat:check...

2017-02-10 Thread orhankislal
Github user orhankislal commented on a diff in the pull request: https://github.com/apache/incubator-madlib/pull/100#discussion_r100577871 --- Diff: pom.xml --- @@ -643,6 +646,8 @@ src/ports/postgres/modules/utilities/admin.py_in src/ports

[GitHub] incubator-madlib pull request #97: Release: Updates the release notes for v1...

2017-02-03 Thread orhankislal
GitHub user orhankislal opened a pull request: https://github.com/apache/incubator-madlib/pull/97 Release: Updates the release notes for v1.10.0. Note that Release Date has to be updated after the release candidate is approved. You can merge this pull request into a Git repository

[GitHub] incubator-madlib issue #95: Release v1.10:

2017-02-03 Thread orhankislal
Github user orhankislal commented on the issue: https://github.com/apache/incubator-madlib/pull/95 Sounds good, I'll add a warning as well. Actually, should we even allow the user to attempt an upgrade from old versions? --- If your project is set up for it, you can reply

[GitHub] incubator-madlib pull request #95: Release v1.10:

2017-02-02 Thread orhankislal
GitHub user orhankislal opened a pull request: https://github.com/apache/incubator-madlib/pull/95 Release v1.10: - Updates the changelists and other related files for upgrade. Note that upgrade is not supported from versions prior to 1.8. - Removes hardcoded schema name

[GitHub] incubator-madlib issue #89: K-means: support for array input

2017-01-24 Thread orhankislal
Github user orhankislal commented on the issue: https://github.com/apache/incubator-madlib/pull/89 Hi @decibel, thanks for your comments. I removed the regex entirely and replaced it with a built-in madlib function. I addressed your other comments as well. Please let me know what you

[GitHub] incubator-madlib pull request #90: RF: Fixes the online help and example

2017-01-23 Thread orhankislal
GitHub user orhankislal opened a pull request: https://github.com/apache/incubator-madlib/pull/90 RF: Fixes the online help and example You can merge this pull request into a Git repository by running: $ git pull https://github.com/orhankislal/incubator-madlib bugfix

[GitHub] incubator-madlib pull request #89: K-means: support for array input

2017-01-23 Thread orhankislal
GitHub user orhankislal opened a pull request: https://github.com/apache/incubator-madlib/pull/89 K-means: support for array input JIRA: MADLIB-1018 Adds support for array input as data points. The function collates the columns into a column in a temp table. You can

[GitHub] incubator-madlib issue #87: Association Rules: Add rule counts to assoc_rule...

2017-01-20 Thread orhankislal
Github user orhankislal commented on the issue: https://github.com/apache/incubator-madlib/pull/87 LGTM +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-madlib pull request #87: Association Rules: Add rule counts to ass...

2017-01-20 Thread orhankislal
Github user orhankislal commented on a diff in the pull request: https://github.com/apache/incubator-madlib/pull/87#discussion_r97140449 --- Diff: src/ports/postgres/modules/assoc_rules/assoc_rules.py_in --- @@ -504,3 +510,120 @@ def assoc_rules(madlib_schema, support, confidence

[GitHub] incubator-madlib issue #84: PCA: Add grouping support to PCA

2017-01-19 Thread orhankislal
Github user orhankislal commented on the issue: https://github.com/apache/incubator-madlib/pull/84 LGTM +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-madlib issue #81: JIRA: MADLIB-927 Changes made in KNN-help messag...

2017-01-12 Thread orhankislal
Github user orhankislal commented on the issue: https://github.com/apache/incubator-madlib/pull/81 We can try doing a screen share session but I am not sure what to look for. For now, why don't you just prepare a draft of the documentation and I'll compile them for you

[GitHub] incubator-madlib issue #81: JIRA: MADLIB-927 Changes made in KNN-help messag...

2017-01-11 Thread orhankislal
Github user orhankislal commented on the issue: https://github.com/apache/incubator-madlib/pull/81 Not sure how to tackle. It is interesting that you don't get any actual errors but a simple confirmation. It seems them makefile (generated by cmake) doesn't even try to build anything

[GitHub] incubator-madlib issue #81: JIRA: MADLIB-927 Changes made in KNN-help messag...

2017-01-11 Thread orhankislal
Github user orhankislal commented on the issue: https://github.com/apache/incubator-madlib/pull/81 And the output of `make doc` is still the same? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] incubator-madlib issue #81: JIRA: MADLIB-927 Changes made in KNN-help messag...

2017-01-11 Thread orhankislal
Github user orhankislal commented on the issue: https://github.com/apache/incubator-madlib/pull/81 If you start with a completely empty folder, what is the output of `cmake ../`? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] incubator-madlib issue #81: JIRA: MADLIB-927 Changes made in KNN-help messag...

2017-01-11 Thread orhankislal
Github user orhankislal commented on the issue: https://github.com/apache/incubator-madlib/pull/81 You'll need doxygen in addition to latex to compile the docs. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] incubator-madlib issue #81: JIRA: MADLIB-927 Changes made in KNN-help messag...

2017-01-11 Thread orhankislal
Github user orhankislal commented on the issue: https://github.com/apache/incubator-madlib/pull/81 Assuming the build folder is inside the `incubator-madlib` folder, try `cmake ../`. Otherwise, give the madlib folder as input. --- If your project is set up for it, you can reply

[GitHub] incubator-madlib issue #81: JIRA: MADLIB-927 Changes made in KNN-help messag...

2017-01-11 Thread orhankislal
Github user orhankislal commented on the issue: https://github.com/apache/incubator-madlib/pull/81 Let's try this. Create a new build folder and run the `cmake` command. Its output should indicate if you can actually generate docs. --- If your project is set up for it, you can reply

[GitHub] incubator-madlib issue #81: JIRA: MADLIB-927 Changes made in KNN-help messag...

2017-01-11 Thread orhankislal
Github user orhankislal commented on the issue: https://github.com/apache/incubator-madlib/pull/81 It is under `doc/user/html` folder. Make sure to compile the code itself with `make` before `make doc`. --- If your project is set up for it, you can reply to this email and have your

[GitHub] incubator-madlib issue #81: JIRA: MADLIB-927 Changes made in KNN-help messag...

2017-01-11 Thread orhankislal
Github user orhankislal commented on the issue: https://github.com/apache/incubator-madlib/pull/81 Oh sorry, I meant run it in the build folder where you run `make`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] incubator-madlib issue #81: JIRA: MADLIB-927 Changes made in KNN-help messag...

2017-01-11 Thread orhankislal
Github user orhankislal commented on the issue: https://github.com/apache/incubator-madlib/pull/81 Yes, the section that starts with `@addtogroup` is the documentation that will be reflected on the website when the pr is merged in the the repo. You will need latex installed on your

[GitHub] incubator-madlib issue #81: JIRA: MADLIB-927 Changes made in KNN-help messag...

2017-01-10 Thread orhankislal
Github user orhankislal commented on the issue: https://github.com/apache/incubator-madlib/pull/81 I think it looks pretty good. We just have to add the documentation and alter the online help. You can take a look at the `pivot.sql_in` file (or any other function) as an example

[GitHub] incubator-madlib issue #81: JIRA: MADLIB-927 Changes made in KNN-help messag...

2017-01-09 Thread orhankislal
Github user orhankislal commented on the issue: https://github.com/apache/incubator-madlib/pull/81 Yes, I just pulled them, I can see the licenses you added. I see there is a madlib aggregate called mode (in utilities.sql_in). That and an altered search path on my end might

[GitHub] incubator-madlib issue #81: JIRA: MADLIB-927 Changes made in KNN-help messag...

2017-01-09 Thread orhankislal
Github user orhankislal commented on the issue: https://github.com/apache/incubator-madlib/pull/81 When I run the install-check I get the following error. ``` select * from madlib.knn('knn_train_data','data','label','knn_test_data','data','id

[GitHub] incubator-madlib pull request #86: DT: Adds verbose option for the dot outpu...

2017-01-06 Thread orhankislal
GitHub user orhankislal opened a pull request: https://github.com/apache/incubator-madlib/pull/86 DT: Adds verbose option for the dot output format. You can merge this pull request into a Git repository by running: $ git pull https://github.com/orhankislal/incubator-madlib

[GitHub] incubator-madlib pull request #81: JIRA: MADLIB-927 Changes made in KNN-help...

2016-12-28 Thread orhankislal
Github user orhankislal commented on a diff in the pull request: https://github.com/apache/incubator-madlib/pull/81#discussion_r94081753 --- Diff: src/ports/postgres/modules/knn/test/knn.sql_in --- @@ -0,0 +1,41 @@ +m4_include(`SQLCommon.m4

[GitHub] incubator-madlib pull request #81: JIRA: MADLIB-927 Changes made in KNN-help...

2016-12-23 Thread orhankislal
Github user orhankislal commented on a diff in the pull request: https://github.com/apache/incubator-madlib/pull/81#discussion_r93790128 --- Diff: src/ports/postgres/modules/knn/test/knn.sql_in --- @@ -0,0 +1,41 @@ +m4_include(`SQLCommon.m4

[GitHub] incubator-madlib pull request #81: JIRA: MADLIB-927 Changes made in KNN-help...

2016-12-23 Thread orhankislal
Github user orhankislal commented on a diff in the pull request: https://github.com/apache/incubator-madlib/pull/81#discussion_r93789678 --- Diff: src/ports/postgres/modules/knn/knn.sql_in --- @@ -0,0 +1,165

[GitHub] incubator-madlib pull request #81: JIRA: MADLIB-927 Changes made in KNN-help...

2016-12-21 Thread orhankislal
Github user orhankislal commented on a diff in the pull request: https://github.com/apache/incubator-madlib/pull/81#discussion_r93346118 --- Diff: src/ports/postgres/modules/knn/knn.sql_in --- @@ -0,0 +1,165

[GitHub] incubator-madlib pull request #81: JIRA: MADLIB-927 Changes made in KNN-help...

2016-12-21 Thread orhankislal
Github user orhankislal commented on a diff in the pull request: https://github.com/apache/incubator-madlib/pull/81#discussion_r93346785 --- Diff: src/ports/postgres/modules/knn/knn.sql_in --- @@ -0,0 +1,165

[GitHub] incubator-madlib pull request #81: JIRA: MADLIB-927 Changes made in KNN-help...

2016-12-21 Thread orhankislal
Github user orhankislal commented on a diff in the pull request: https://github.com/apache/incubator-madlib/pull/81#discussion_r93548578 --- Diff: src/ports/postgres/modules/knn/test/knn.sql_in --- @@ -0,0 +1,41 @@ +m4_include(`SQLCommon.m4

[GitHub] incubator-madlib pull request #81: JIRA: MADLIB-927 Changes made in KNN-help...

2016-12-21 Thread orhankislal
Github user orhankislal commented on a diff in the pull request: https://github.com/apache/incubator-madlib/pull/81#discussion_r93548165 --- Diff: src/ports/postgres/modules/knn/knn.sql_in --- @@ -0,0 +1,165

[GitHub] incubator-madlib pull request #78: Graph: SSSP

2016-12-19 Thread orhankislal
Github user orhankislal commented on a diff in the pull request: https://github.com/apache/incubator-madlib/pull/78#discussion_r93107178 --- Diff: src/ports/postgres/modules/graph/sssp.py_in --- @@ -0,0 +1,372 @@ +# coding=utf-8 +# +# Licensed to the Apache Software

[GitHub] incubator-madlib issue #78: Graph: SSSP

2016-12-19 Thread orhankislal
Github user orhankislal commented on the issue: https://github.com/apache/incubator-madlib/pull/78 Yes that is the idea. I don't bother checking an edge unless its source vertex has been updated in the last pass. --- If your project is set up for it, you can reply to this email

[GitHub] incubator-madlib issue #78: Graph: SSSP

2016-12-16 Thread orhankislal
Github user orhankislal commented on the issue: https://github.com/apache/incubator-madlib/pull/78 @decibel I posted a pseudocode in the JIRA. Please let me know if that clarifies why I needed the multilayered sql code. --- If your project is set up for it, you can reply

[GitHub] incubator-madlib issue #78: Graph: SSSP

2016-12-14 Thread orhankislal
Github user orhankislal commented on the issue: https://github.com/apache/incubator-madlib/pull/78 Here is what I am thinking: We should create a new JIRA for SSSP Phase 2 to explore plpgsql implementation with an array to replace `toupdate` and `message` tables. I am not sure how

[GitHub] incubator-madlib issue #78: Graph: SSSP

2016-12-13 Thread orhankislal
Github user orhankislal commented on the issue: https://github.com/apache/incubator-madlib/pull/78 Unfortunately, GPDB does not support RECURSIVE option in WITH clause. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] incubator-madlib issue #78: Graph: SSSP

2016-12-12 Thread orhankislal
Github user orhankislal commented on the issue: https://github.com/apache/incubator-madlib/pull/78 I'll put the pseudocode in the JIRA (https://issues.apache.org/jira/browse/MADLIB-992) --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] incubator-madlib pull request #78: Graph: SSSP

2016-12-12 Thread orhankislal
Github user orhankislal commented on a diff in the pull request: https://github.com/apache/incubator-madlib/pull/78#discussion_r92069560 --- Diff: src/ports/postgres/modules/graph/sssp.py_in --- @@ -0,0 +1,347 @@ +# coding=utf-8 +# +# Licensed to the Apache Software

[GitHub] incubator-madlib pull request #78: Graph: SSSP

2016-12-12 Thread orhankislal
Github user orhankislal commented on a diff in the pull request: https://github.com/apache/incubator-madlib/pull/78#discussion_r92064461 --- Diff: src/ports/postgres/modules/graph/sssp.py_in --- @@ -0,0 +1,347 @@ +# coding=utf-8 +# +# Licensed to the Apache Software

[GitHub] incubator-madlib issue #68: Adds cluster variance to kmeans for PivotalR sup...

2016-12-07 Thread orhankislal
Github user orhankislal commented on the issue: https://github.com/apache/incubator-madlib/pull/68 Closing this pull request since the version number is already fixed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] incubator-madlib pull request #68: Adds cluster variance to kmeans for Pivot...

2016-12-07 Thread orhankislal
Github user orhankislal closed the pull request at: https://github.com/apache/incubator-madlib/pull/68 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

  1   2   >