Re: [GitHub] incubator-madlib issue #80: KNN Added

2016-12-19 Thread Kazmi,Auon H
and the madlib's community. Regards, Auon From: Nandish Jayaram <njaya...@pivotal.io> Sent: Monday, December 19, 2016 12:51:18 PM To: dev@madlib.incubator.apache.org Subject: Re: [GitHub] incubator-madlib issue #80: KNN Added Great! Let us know if you have any

Re: [GitHub] incubator-madlib issue #80: KNN Added

2016-12-19 Thread Nandish Jayaram
Thanks, >> >> Auon >> >> >> From: Kazmi,Auon H <aka...@ufl.edu> >> Sent: Friday, December 16, 2016 11:09:11 PM >> To: dev@madlib.incubator.apache.org >> Subject: Re: [GitHub] incubator

Re: [GitHub] incubator-madlib issue #80: KNN Added

2016-12-19 Thread Nandish Jayaram
__ > From: Nandish Jayaram <njaya...@pivotal.io> > Sent: Friday, December 16, 2016 8:32:52 PM > To: dev@madlib.incubator.apache.org > Subject: Re: [GitHub] incubator-madlib issue #80: KNN Added > > Hi Auon, > > Hope your exams went well. > > You can do whatever ends up bei

Re: [GitHub] incubator-madlib issue #80: KNN Added

2016-12-17 Thread Wang ChenLiang
Sorry, I was busy with my semester-end exams. >> >> I am reading on Git. Should I repeat the process of checking out madlib >> repo and then again making changes in a local branch? >> >> >> >> Regards, >> >> Auon >> >>

Re: [GitHub] incubator-madlib issue #80: KNN Added

2016-12-17 Thread Rahul Iyer
> From: Nandish Jayaram <njaya...@pivotal.io> > Sent: Friday, December 16, 2016 8:32:52 PM > To: dev@madlib.incubator.apache.org > Subject: Re: [GitHub] incubator-madlib issue #80: KNN Added > > Hi Auon, > > Hope your exams went well. > > You can do whatever ends

Re: [GitHub] incubator-madlib issue #80: KNN Added

2016-12-16 Thread Kazmi,Auon H
: Kazmi,Auon H <aka...@ufl.edu> Sent: Friday, December 16, 2016 11:09:11 PM To: dev@madlib.incubator.apache.org Subject: Re: [GitHub] incubator-madlib issue #80: KNN Added Hi NJ, Thanks for your detailed reply! I will try to do the said things. Thanks, Auon ___

Re: [GitHub] incubator-madlib issue #80: KNN Added

2016-12-16 Thread Kazmi,Auon H
al branch? > > > > Regards, > > Auon > > > From: njayaram2 <g...@git.apache.org> > Sent: Thursday, December 15, 2016 6:24:08 PM > To: dev@madlib.incubator.apache.org > Subject: [GitHub] incubator-madlib issue #80: KNN Added > > Github user

Re: [GitHub] incubator-madlib issue #80: KNN Added

2016-12-16 Thread Nandish Jayaram
nch? > > > > Regards, > > Auon > > > From: njayaram2 <g...@git.apache.org> > Sent: Thursday, December 15, 2016 6:24:08 PM > To: dev@madlib.incubator.apache.org > Subject: [GitHub] incubator-madlib issue #80: KNN Added > > Github user njayaram2 comm

[GitHub] incubator-madlib issue #80: KNN Added

2016-12-15 Thread njayaram2
Github user njayaram2 commented on the issue: https://github.com/apache/incubator-madlib/pull/80 Overall, this looks great and the code seems to be working correctly. We can certainly make various modifications to it. For instance: - Try to use other distance measures. If we

[GitHub] incubator-madlib issue #80: KNN Added

2016-12-15 Thread njayaram2
Github user njayaram2 commented on the issue: https://github.com/apache/incubator-madlib/pull/80 This is a great start! I will provide some github-specific feedback here, and more knn-specific comments in the code. Git can be daunting to use at first, but it's great once