Re: maven git commit: [MNG-3507] keep green for success: INFO in blue (DEBUG is cyan)

2016-06-15 Thread Jason Dillon
> And if folks really just want any use of green to become blue, then yes  > you can do that now and there is no reason to change anything further.  > Though I kinda doubt that is what folks want when then think about  > customization of colors. I expect folks really want more control over  >

Re: Roadmap Maven 3.4.0

2016-06-15 Thread Mark Derricutt
On 16 Jun 2016, at 8:42, Uwe Barthel wrote: > The custom implementation could be placed in {maven.home}/lib/ext or maybe > also as extension in .mvn/ per project. Hmm, this is actually want I want to do ( re my post on problems with lifecycle extensions ). But was told that ./mvn extensions

Re: Maven Embedder and Lifecycle extensions

2016-06-15 Thread Mark Derricutt
On 15 Jun 2016, at 23:30, Igor Fedorenko wrote: extensions.xml was meant for "non-functional" extensions, things like Takari SmartBuilder, which improves multi-threaded build scheduling but does not affect overall build results. If your extensions change build behaviour in non-trivial ways,

Re: maven git commit: [MNG-3507] keep green for success: INFO in blue (DEBUG is cyan)

2016-06-15 Thread Christian Schulte
Am 06/15/16 um 23:59 schrieb Jason Dillon: > On June 15, 2016 at 12:07:32 AM, Christian Schulte (c...@schulte.it > ) wrote: >> Am 06/15/16 um 00:17 schrieb Jason Dillon: >> > Making the colors configurable seems like a lot of overhead for what is >> > otherwise fairly

Re: maven git commit: [MNG-3507] keep green for success: INFO in blue (DEBUG is cyan)

2016-06-15 Thread Jason Dillon
On June 15, 2016 at 12:07:32 AM, Christian Schulte (c...@schulte.it) wrote: Am 06/15/16 um 00:17 schrieb Jason Dillon:  > Making the colors configurable seems like a lot of overhead for what is > otherwise fairly simple.  >  > I’d recommend leaving the colors asis for now, get this out to let

Re: Roadmap Maven 3.4.0

2016-06-15 Thread Uwe Barthel
Hi Michael, > I have made several comments. Please review and update otherwise I cannot > proceed on the merge. I take a look. Thats a lot of auto formatting things. It’s quite difficult to manage these over different projects in Netbeans. I'll fix that. > Additionally, I am waiting for an

Re: Roadmap Maven 3.4.0

2016-06-15 Thread Michael Osipov
Am 2016-06-14 um 22:46 schrieb Uwe Barthel: Hi, Is there a clear roadmap for version 3.4.0? I ask, because these PRs: https://github.com/apache/maven/pull/70 (integration tests: https://github.com/apache/maven-integration-testing/pull/14) for Item

[GitHub] maven pull request #70: MNG-3092: Adds version range result filter behaviour

2016-06-15 Thread michael-o
Github user michael-o commented on a diff in the pull request: https://github.com/apache/maven/pull/70#discussion_r6723 --- Diff: maven-aether-provider/src/main/java/org/apache/maven/repository/internal/DefaultVersionRangeResolver.java --- @@ -290,7 +312,7 @@ private

[GitHub] maven pull request #70: MNG-3092: Adds version range result filter behaviour

2016-06-15 Thread michael-o
Github user michael-o commented on a diff in the pull request: https://github.com/apache/maven/pull/70#discussion_r67234380 --- Diff: maven-aether-provider/src/main/java/org/apache/maven/repository/internal/DefaultVersionRangeResolver.java --- @@ -193,19 +216,18 @@ public

[GitHub] maven pull request #70: MNG-3092: Adds version range result filter behaviour

2016-06-15 Thread michael-o
Github user michael-o commented on a diff in the pull request: https://github.com/apache/maven/pull/70#discussion_r67234423 --- Diff: maven-aether-provider/src/main/java/org/apache/maven/repository/internal/DefaultVersionRangeResolver.java --- @@ -193,19 +216,18 @@ public

[GitHub] maven pull request #70: MNG-3092: Adds version range result filter behaviour

2016-06-15 Thread michael-o
Github user michael-o commented on a diff in the pull request: https://github.com/apache/maven/pull/70#discussion_r67234434 --- Diff: maven-aether-provider/src/main/java/org/apache/maven/repository/internal/DefaultVersionRangeResolver.java --- @@ -255,7 +277,7 @@ public

[GitHub] maven pull request #70: MNG-3092: Adds version range result filter behaviour

2016-06-15 Thread michael-o
Github user michael-o commented on a diff in the pull request: https://github.com/apache/maven/pull/70#discussion_r67234360 --- Diff: maven-aether-provider/src/main/java/org/apache/maven/repository/internal/DefaultVersionRangeResolver.java --- @@ -136,15 +152,22 @@ public

[GitHub] maven pull request #70: MNG-3092: Adds version range result filter behaviour

2016-06-15 Thread michael-o
Github user michael-o commented on a diff in the pull request: https://github.com/apache/maven/pull/70#discussion_r67234340 --- Diff: maven-aether-provider/src/main/java/org/apache/maven/repository/internal/DefaultVersionRangeResolver.java --- @@ -136,15 +152,22 @@ public

[GitHub] maven pull request #70: MNG-3092: Adds version range result filter behaviour

2016-06-15 Thread michael-o
Github user michael-o commented on a diff in the pull request: https://github.com/apache/maven/pull/70#discussion_r67234319 --- Diff: maven-aether-provider/src/main/java/org/apache/maven/repository/internal/DefaultVersionRangeResolver.java --- @@ -136,15 +152,22 @@ public

[GitHub] maven pull request #70: MNG-3092: Adds version range result filter behaviour

2016-06-15 Thread michael-o
Github user michael-o commented on a diff in the pull request: https://github.com/apache/maven/pull/70#discussion_r67234272 --- Diff: maven-aether-provider/src/main/java/org/apache/maven/repository/internal/DefaultVersionRangeResolver.java --- @@ -88,19 +91,27 @@

[GitHub] maven pull request #70: MNG-3092: Adds version range result filter behaviour

2016-06-15 Thread michael-o
Github user michael-o commented on a diff in the pull request: https://github.com/apache/maven/pull/70#discussion_r67234247 --- Diff: maven-aether-provider/src/main/java/org/apache/maven/repository/internal/DefaultVersionRangeResolver.java --- @@ -88,19 +91,27 @@

[GitHub] maven pull request #70: MNG-3092: Adds version range result filter behaviour

2016-06-15 Thread michael-o
Github user michael-o commented on a diff in the pull request: https://github.com/apache/maven/pull/70#discussion_r67234207 --- Diff: maven-aether-provider/src/main/java/org/apache/maven/repository/internal/DefaultVersionRangeResolver.java --- @@ -63,14 +64,16 @@ import

[GitHub] maven-integration-testing pull request #14: MNG-3092: Adds integration tests...

2016-06-15 Thread michael-o
Github user michael-o commented on a diff in the pull request: https://github.com/apache/maven-integration-testing/pull/14#discussion_r67233942 --- Diff: core-it-suite/src/test/resources/mng-3092/repo/org/apache/maven/its/mng3092/a/2.0-SNAPSHOT/a-2.0-20100408.111215-1.pom --- @@

[GitHub] maven-integration-testing pull request #14: MNG-3092: Adds integration tests...

2016-06-15 Thread michael-o
Github user michael-o commented on a diff in the pull request: https://github.com/apache/maven-integration-testing/pull/14#discussion_r67233825 --- Diff:

[GitHub] maven-integration-testing pull request #14: MNG-3092: Adds integration tests...

2016-06-15 Thread michael-o
Github user michael-o commented on a diff in the pull request: https://github.com/apache/maven-integration-testing/pull/14#discussion_r67233789 --- Diff:

[GitHub] maven-integration-testing pull request #14: MNG-3092: Adds integration tests...

2016-06-15 Thread michael-o
Github user michael-o commented on a diff in the pull request: https://github.com/apache/maven-integration-testing/pull/14#discussion_r67233439 --- Diff: core-it-suite/src/test/resources/mng-3092/filter-extension/pom.xml --- @@ -0,0 +1,73 @@ + + + +

[GitHub] maven-integration-testing pull request #14: MNG-3092: Adds integration tests...

2016-06-15 Thread michael-o
Github user michael-o commented on a diff in the pull request: https://github.com/apache/maven-integration-testing/pull/14#discussion_r67233418 --- Diff: core-it-suite/src/test/resources/mng-3092/filter-extension/pom.xml --- @@ -0,0 +1,73 @@ + + + +

[GitHub] maven-integration-testing pull request #14: MNG-3092: Adds integration tests...

2016-06-15 Thread michael-o
Github user michael-o commented on a diff in the pull request: https://github.com/apache/maven-integration-testing/pull/14#discussion_r67233328 --- Diff: core-it-suite/src/test/resources/mng-3092/filter-extension/pom.xml --- @@ -0,0 +1,73 @@ + + + +

[GitHub] maven-integration-testing pull request #14: MNG-3092: Adds integration tests...

2016-06-15 Thread michael-o
Github user michael-o commented on a diff in the pull request: https://github.com/apache/maven-integration-testing/pull/14#discussion_r67233290 --- Diff: core-it-suite/src/test/resources/mng-3092/filter-extension/pom.xml --- @@ -0,0 +1,73 @@ + + + +

[GitHub] maven-integration-testing pull request #14: MNG-3092: Adds integration tests...

2016-06-15 Thread michael-o
Github user michael-o commented on a diff in the pull request: https://github.com/apache/maven-integration-testing/pull/14#discussion_r67233223 --- Diff: core-it-suite/src/test/resources/mng-3092/filter-extension/pom.xml --- @@ -0,0 +1,74 @@ + + + +

[GitHub] maven-integration-testing pull request #14: MNG-3092: Adds integration tests...

2016-06-15 Thread michael-o
Github user michael-o commented on a diff in the pull request: https://github.com/apache/maven-integration-testing/pull/14#discussion_r67233084 --- Diff: core-it-suite/src/test/java/org/apache/maven/it/MavenITmng3092VersionRangeResultFilterExtensionTest.java --- @@ -0,0 +1,132

[GitHub] maven-integration-testing pull request #14: MNG-3092: Adds integration tests...

2016-06-15 Thread michael-o
Github user michael-o commented on a diff in the pull request: https://github.com/apache/maven-integration-testing/pull/14#discussion_r67233139 --- Diff: core-it-suite/src/test/java/org/apache/maven/it/MavenITmng3092VersionRangeResultFilterExtensionTest.java --- @@ -0,0 +1,132

[GitHub] maven-integration-testing pull request #14: MNG-3092: Adds integration tests...

2016-06-15 Thread michael-o
Github user michael-o commented on a diff in the pull request: https://github.com/apache/maven-integration-testing/pull/14#discussion_r67233015 --- Diff: core-it-suite/src/test/java/org/apache/maven/it/MavenITmng3092VersionRangeResultFilterExtensionTest.java --- @@ -0,0 +1,132

[GitHub] maven-integration-testing issue #14: MNG-3092: Adds integration tests for ve...

2016-06-15 Thread michael-o
Github user michael-o commented on the issue: https://github.com/apache/maven-integration-testing/pull/14 This merge cannot be accepted. See comments inline as well as: * the It does not pass because the repo is oncomplete. Several JARs are missing and Maven complains about

Re: Edge case in artifact filtering algorithm

2016-06-15 Thread Robert Scholte
On Wed, 15 Jun 2016 00:02:47 +0200, Michael Osipov wrote: Am 2016-06-14 um 23:45 schrieb Robert Scholte: too much fun to fix this. http://svn.apache.org/viewvc?rev=1748472=rev should do the trick. Still some doc updates required Good! We still must take great care

Re: Maven Embedder and Lifecycle extensions

2016-06-15 Thread Igor Fedorenko
extensions.xml was meant for "non-functional" extensions, things like Takari SmartBuilder, which improves multi-threaded build scheduling but does not affect overall build results. If your extensions change build behaviour in non-trivial ways, your build is not Maven any more and you should expect

Re: maven git commit: [MNG-3507] keep green for success: INFO in blue (DEBUG is cyan)

2016-06-15 Thread Christian Schulte
Am 06/15/16 um 00:17 schrieb Jason Dillon: > Making the colors configurable seems like a lot of overhead for what is > otherwise fairly simple. > > I’d recommend leaving the colors asis for now, get this out to let users > actually make use of it, and then consider adding complexity later to

Re: maven git commit: [MNG-3507] keep green for success: INFO in blue (DEBUG is cyan)

2016-06-15 Thread Uwe Barthel
Hi, > DEBUG/INFO/WARNING/ERROR schemes I'm thinking at: > 1. bold cyan/bold green/bold yellow/bold red (initial) > 2. bold cyan/bold blue/bold yellow/bold red (current) > 3. cyan/blue/bold yellow/bold red (idea to have INFO less visible) I prefer to use the standard console color (customised by

Re: maven git commit: [MNG-3507] keep green for success: INFO in blue (DEBUG is cyan)

2016-06-15 Thread Hervé BOUTEMY
Sorry guys, I did this while looking at a soccer match :) , not on my main computer, then without communicating... This one is a little bit like the Jenkins debate on the green vs blue bullet: this time, this was a remark on MNG-3507 that bold green on every INFO was too much... Then I found

Re: Can't build Maven site for m-assembly-p trunk

2016-06-15 Thread Karl Heinz Marbaise
Hi, the maven-artifat-transfer shared component needed to be released first which is used by maven-assembly-plugin... Kind regards Karl Heinz Marbaise On 6/15/16 12:07 AM, Olivier Lamy wrote: Hi Anders, Have you finished with assembly plugin? As said last week I'd like to release it soon.