Re: Lets talk about our changes openly. maven-surefire git commit: [SUREFIRE-1324] Surefire incorrectly suppresses exceptions when closing resources.

Hello, Christian Schulte schrieb am Di., 3. Jan. 2017 um 02:57 Uhr: > Am 01/02/17 um 21:01 schrieb Benson Margulies: > > On Mon, Jan 2, 2017 at 1:38 PM, Hervé BOUTEMY > wrote: > > > >> Christian, > >> > >> Please read Tibor's concerns: > >> - big change,

Re: Lets talk about our changes openly. maven-surefire git commit: [SUREFIRE-1324] Surefire incorrectly suppresses exceptions when closing resources.

Am 01/02/17 um 21:01 schrieb Benson Margulies: > On Mon, Jan 2, 2017 at 1:38 PM, Hervé BOUTEMY wrote: > >> Christian, >> >> Please read Tibor's concerns: >> - big change, >> - near release (with parallel branches for JUnit 5) >> And I'll add: noise, like addition of final,

Re: Lets talk about our changes openly. maven-surefire git commit: [SUREFIRE-1324] Surefire incorrectly suppresses exceptions when closing resources.

There may be a misunderstanding here. I do not blame anyone for those surefire failures I am getting on Jenkins and locally. This is nothing I am interested in. I very seldomly take a look at commit history. If I do, only to find out about - well - the history of changes or because I need to

Re: Lets talk about our changes openly. maven-surefire git commit: [SUREFIRE-1324] Surefire incorrectly suppresses exceptions when closing resources.

Am 01/02/17 um 21:01 schrieb Benson Margulies: > On Mon, Jan 2, 2017 at 1:38 PM, Hervé BOUTEMY wrote: > >> Christian, >> >> Please read Tibor's concerns: >> - big change, >> - near release (with parallel branches for JUnit 5) >> And I'll add: noise, like addition of final,

Re: [DISCUSS] Big Scrub for proposed 3.5.0 (if we reset master)

FIX-3.5.0: MNG-5889 .mvn directory should be picked when using --file seconded Regards, Hervé Le samedi 31 décembre 2016, 21:14:59 CET Stephen Connolly a écrit : > FIX-3.5.0: MNG-5607, MNG-5815, MNG-5823, MNG-5824, MNG-5836, MNG-5837, > MNG-5889, MNG-5904, MNG-5946, MNG-5963, MNG-5967,

Re: [DISCUSS] Big Scrub for proposed 3.5.0 (if we reset master)

looking for seconds on new features related to site url calculations: MNG-4508 - No way to avoid adding artifactId to site urls MNG-5878 - add support for module name != artifactId in every calculated URLs (project, SCM, site): special project.directory property MNG-5951 - add an option to avoid

Re: [DISCUSS] Big Scrub for proposed 3.5.0 (if we reset master)

in general, I completely agree in this specific case, where there were changes in 1.1.0 and 1.2.0-SNAPSHOT that we won't integrate yet, Aether 1.0.2 followed by Artifact Resolver 1.0.3 with only coordinate changes (but not code) seems easier to understand Regards, Hervé Le lundi 2 janvier

Re: [DISCUSS] Big Scrub for proposed 3.5.0 (if we reset master)

On Monday, 2 January 2017, Michael Osipov wrote: > Am 2017-01-02 um 21:34 schrieb Stephen Connolly: > >> On 2 January 2017 at 20:15, Michael Osipov wrote: >> >> Am 2017-01-02 um 20:35 schrieb Stephen Connolly: >>> >>> On 2 January 2017 at 18:49, Michael

Re: [DISCUSS] Big Scrub for proposed 3.5.0 (if we reset master)

Am 2017-01-02 um 21:34 schrieb Stephen Connolly: On 2 January 2017 at 20:15, Michael Osipov wrote: Am 2017-01-02 um 20:35 schrieb Stephen Connolly: On 2 January 2017 at 18:49, Michael Osipov wrote: Am 2017-01-01 um 15:51 schrieb Stephen Connolly:

Re: [DISCUSS] Big Scrub for proposed 3.5.0 (if we reset master)

On 2 January 2017 at 20:34, Stephen Connolly < stephen.alan.conno...@gmail.com> wrote: > > > On 2 January 2017 at 20:15, Michael Osipov wrote: > >> Am 2017-01-02 um 20:35 schrieb Stephen Connolly: >> >>> On 2 January 2017 at 18:49, Michael Osipov wrote:

Re: [DISCUSS] Big Scrub for proposed 3.5.0 (if we reset master)

On 2 January 2017 at 20:15, Michael Osipov wrote: > Am 2017-01-02 um 20:35 schrieb Stephen Connolly: > >> On 2 January 2017 at 18:49, Michael Osipov wrote: >> >> Am 2017-01-01 um 15:51 schrieb Stephen Connolly: >>> >>> On 1 January 2017 at 00:55,

Re: [DISCUSS] Big Scrub for proposed 3.5.0 (if we reset master)

On Mon, 02 Jan 2017 21:04:57 +0100, Stephen Connolly wrote: On 31 December 2016 at 20:10, Stephen Connolly < stephen.alan.conno...@gmail.com> wrote: Here are the changes in current master since 3.3.9 (with some minor changes omitted) Issue ID Target

Re: [DISCUSS] Big Scrub for proposed 3.5.0 (if we reset master)

Am 2017-01-02 um 20:35 schrieb Stephen Connolly: On 2 January 2017 at 18:49, Michael Osipov wrote: Am 2017-01-01 um 15:51 schrieb Stephen Connolly: On 1 January 2017 at 00:55, Michael Osipov wrote: I just went through the list my issues. Here is a

Re: [DISCUSS] Big Scrub for proposed 3.5.0 (if we reset master)

On 31 December 2016 at 20:10, Stephen Connolly < stephen.alan.conno...@gmail.com> wrote: > Here are the changes in current master since 3.3.9 (with some minor > changes omitted) > > Issue ID Target Version Summary > == >

Re: Lets talk about our changes openly. maven-surefire git commit: [SUREFIRE-1324] Surefire incorrectly suppresses exceptions when closing resources.

On Mon, Jan 2, 2017 at 1:38 PM, Hervé BOUTEMY wrote: > Christian, > > Please read Tibor's concerns: > - big change, > - near release (with parallel branches for JUnit 5) > And I'll add: noise, like addition of final, reordering of imports, > addition/ > suppression of

Re: [DISCUSS] Big Scrub for proposed 3.5.0 (if we reset master)

On 2 January 2017 at 18:49, Michael Osipov wrote: > Am 2017-01-01 um 15:51 schrieb Stephen Connolly: > >> On 1 January 2017 at 00:55, Michael Osipov wrote: >> >> I just went through the list my issues. Here is a safe list I would >>> merge/cherry-pick

Re: [DISCUSS] Big Scrub for proposed 3.5.0 (if we reset master)

Am 2017-01-01 um 18:44 schrieb Guillaume Boué: This is the list of JIRA issues that targets colourised logging / are related to it: MNG-3507 ANSI color logging for improved output visibilityThis is the root JIRA issue. MNG-3705 Expression: ${executedProject} doesn't work in reports

Re: [DISCUSS] Big Scrub for proposed 3.5.0 (if we reset master)

Am 2017-01-01 um 18:44 schrieb Guillaume Boué: Le 01/01/2017 à 01:55, Michael Osipov a écrit : I just went through the list my issues. Here is a safe list I would merge/cherry-pick into new master: FIX-3.5.0: MNG-5457, Note: this is dependant upon MRESOLVER-2 (commit

Re: [DISCUSS] Big Scrub for proposed 3.5.0 (if we reset master)

Am 2017-01-01 um 15:51 schrieb Stephen Connolly: On 1 January 2017 at 00:55, Michael Osipov wrote: I just went through the list my issues. Here is a safe list I would merge/cherry-pick into new master: FIX-3.5.0: MNG-5567, Affects behaviour, I recommend 3.5.1 but I

Re: Lets talk about our changes openly. maven-surefire git commit: [SUREFIRE-1324] Surefire incorrectly suppresses exceptions when closing resources.

Christian, Please read Tibor's concerns: - big change, - near release (with parallel branches for JUnit 5) And I'll add: noise, like addition of final, reordering of imports, addition/ suppression of empty lines Please follow Tibor's request, which tries to be as kind as possible: > So now

Re: Lets talk about our changes openly. maven-surefire git commit: [SUREFIRE-1324] Surefire incorrectly suppresses exceptions when closing resources.

Am 01/02/17 um 18:45 schrieb Tibor Digana: > Why then you did not provide logs in Jira? > MasterProcessCommand.java would behave with or without your change because > the read() method will always wait for at least one byte to read. The only > exception is read(byte[]) will return 0 if and only if

Re: Lets talk about our changes openly. maven-surefire git commit: [SUREFIRE-1324] Surefire incorrectly suppresses exceptions when closing resources.

I am not checking out surefire because I am bored. I get blamed for failing ITs and I am quite pissed that the CI system is sending out failure notifications and all you see is an issue with surefire and not with the build job or the actual build you get an email for. With current master, there

Re: Lets talk about our changes openly. maven-surefire git commit: [SUREFIRE-1324] Surefire incorrectly suppresses exceptions when closing resources.

Why then you did not provide logs in Jira? MasterProcessCommand.java would behave with or without your change because the read() method will always wait for at least one byte to read. The only exception is read(byte[]) will return 0 if and only if byte[] length is 0. Other problems with the commit

Re: Lets talk about our changes openly. maven-surefire git commit: [SUREFIRE-1324] Surefire incorrectly suppresses exceptions when closing resources.

On a side note to this: I am getting quite a few IT failures building surefire locally with Maven 3.3.9 also without that commit. If surefire is unreliable, Maven is unreliable. Am 01/02/17 um 18:22 schrieb Christian Schulte: > And now everyone please take a look at that commit and tell me what

Re: Lets talk about our changes openly. maven-surefire git commit: [SUREFIRE-1324] Surefire incorrectly suppresses exceptions when closing resources.

And now everyone please take a look at that commit and tell me what is so hard about it to review? You are not able to scroll through this and verify what is going on? It's something very trivial.

Re: Lets talk about our changes openly. maven-surefire git commit: [SUREFIRE-1324] Surefire incorrectly suppresses exceptions when closing resources.

The normal Apache process here is this: if someone finds a commit sufficiently objectionable, as per CTR, they https://www.apache.org/foundation/glossary.html#Veto it. It gets reverted post haste, no vote is needed. According to the Apache methodology, a change which has been made or proposed

Re: Lets talk about our changes openly. maven-surefire git commit: [SUREFIRE-1324] Surefire incorrectly suppresses exceptions when closing resources.

Well I'm not happy with how development has evolved here, hence my rather vocal stepping up tovtr and pull core back into order. If you want to do a reset, you'll need a vote from committers ok-zing the reset. Do NOT call a vote without ensuring that you have consensus *first*. Votes should be

Lets talk about our changes openly. maven-surefire git commit: [SUREFIRE-1324] Surefire incorrectly suppresses exceptions when closing resources.

I also have such feeling that Maven became a playground. Last week I saw it in reality and after Robert told me we made playground in our sources I could not believe this could happen in such professional project like Maven. I would appreciate it if the change [1]

[GitHub] maven issue #49: Added support for MAVEN_ARGS in mvn, mvnDebug, and mvnyjp

Github user leonyxb commented on the issue: https://github.com/apache/maven/pull/49 @michael-o New JIRA added: https://issues.apache.org/jira/browse/MNG-6143 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] maven issue #49: Added support for MAVEN_ARGS in mvn, mvnDebug, and mvnyjp

Github user michael-o commented on the issue: https://github.com/apache/maven/pull/49 @leonyxb Open a new JIRA issue for this regression. At best with a PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] maven issue #49: Added support for MAVEN_ARGS in mvn, mvnDebug, and mvnyjp

Github user leonyxb commented on the issue: https://github.com/apache/maven/pull/49 $MAVEN_CONFIG does not exist on mvn.cmd, really need it on windows. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does