Review for 3.5.0

2017-01-22 Thread Karl Heinz Marbaise
Hi, I have taken a look into the list and the following issue can be part of 3.5.0 from my point of view: MNG-5297 Site should tell 'prerequisites.maven is deprecated' MNG-5904 Remove the whole Ant build (Already someone working on that?) MNG-6014 Removing ArtifactHandler for

[GitHub] maven pull request #100: Spelling

2017-01-22 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/maven/pull/100#discussion_r97253963 --- Diff: maven-core/src/test/java/org/apache/maven/lifecycle/internal/stub/LifecycleExecutionPlanCalculatorStub.java --- @@ -88,7 +88,7 @@ public fin

[GitHub] maven pull request #100: Spelling

2017-01-22 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/maven/pull/100#discussion_r97254243 --- Diff: maven-model-builder/src/test/java/org/apache/maven/model/interpolation/AbstractModelInterpolatorTest.java --- @@ -67,7 +67,7 @@ protected void assert

[GitHub] maven pull request #100: Spelling

2017-01-22 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/maven/pull/100#discussion_r97253779 --- Diff: maven-compat/src/main/java/org/apache/maven/repository/MetadataResolutionRequest.java --- @@ -108,14 +108,14 @@ public MetadataResolutionRequest setL

[GitHub] maven pull request #100: Spelling

2017-01-22 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/maven/pull/100#discussion_r97253878 --- Diff: maven-core/src/main/java/org/apache/maven/project/ProjectSorter.java --- @@ -105,7 +105,7 @@ public ProjectSorter( Collection projects )

[GitHub] maven pull request #100: Spelling

2017-01-22 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/maven/pull/100#discussion_r97253624 --- Diff: maven-compat/src/main/java/org/apache/maven/repository/MetadataGraphNode.java --- @@ -57,7 +57,7 @@ public MetadataGraphNode addIncident( MetadataGra

[GitHub] maven pull request #100: Spelling

2017-01-22 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/maven/pull/100#discussion_r97253891 --- Diff: maven-core/src/main/java/org/apache/maven/repository/DelegatingLocalArtifactRepository.java --- @@ -61,7 +61,7 @@ public void setIdeWorkspace( LocalA

[GitHub] maven pull request #100: Spelling

2017-01-22 Thread jsoref
GitHub user jsoref opened a pull request: https://github.com/apache/maven/pull/100 Spelling You can merge this pull request into a Git repository by running: $ git pull https://github.com/jsoref/maven spelling Alternatively you can review and apply these changes as the patch

Re: please review MNG-5904 branch - Remove the whole Ant Build

2017-01-22 Thread Hervé BOUTEMY
picky, but true done Regards, Hervé Le dimanche 22 janvier 2017, 19:49:47 CET Michael Osipov a écrit : > Am 2017-01-22 um 17:50 schrieb Hervé BOUTEMY: > > everything is in the title > > > > more than removal of Ant build, what I want to have in master quite fast > > is > > the equivalent > > m

Re: Progress check for 3.5.0

2017-01-22 Thread Stephen Connolly
Go for it On Sun 22 Jan 2017 at 22:14, Michael Osipov wrote: > Am 2017-01-22 um 21:18 schrieb Michael Osipov: > > > Am 2017-01-22 um 17:35 schrieb Christian Schulte: > > >> Am 22.01.2017 um 13:58 schrieb Michael Osipov: > > >>> [..] > > >>> MNG-5837 Syntax error in bin/mvn on Solaris SPARC > > >

[GitHub] maven-wagon issue #22: Implementation for Secure FTP (FTPS protocol)

2017-01-22 Thread wiiitek
Github user wiiitek commented on the issue: https://github.com/apache/maven-wagon/pull/22 Hello, I believe that this pull request is not needed anymore. @flavioarcega , could you confirm that FTPS protocol is working for you with maven-wagon 2.11: http://maven.apache.org/compo

Re: Progress check for 3.5.0

2017-01-22 Thread Michael Osipov
Am 2017-01-22 um 21:18 schrieb Michael Osipov: Am 2017-01-22 um 17:35 schrieb Christian Schulte: Am 22.01.2017 um 13:58 schrieb Michael Osipov: [..] MNG-5837 Syntax error in bin/mvn on Solaris SPARC FIX-3.5.0 This is a trivial fix but to be more precise, it has to be split it two separate i

Re: Progress check for 3.5.0

2017-01-22 Thread Christian Schulte
Am 01/22/17 um 21:18 schrieb Michael Osipov: > Am 2017-01-22 um 17:35 schrieb Christian Schulte: >> Am 22.01.2017 um 13:58 schrieb Michael Osipov: >>> [..] >>> MNG-5837 Syntax error in bin/mvn on Solaris SPARC >> >> FIX-3.5.0 > > This is a trivial fix but to be more precise, it has to be split it

Re: Progress check for 3.5.0

2017-01-22 Thread Christian Schulte
Am 01/22/17 um 22:20 schrieb Stephen Connolly: > Please just name each branch by the issue it is using > > Naming branches MNG-xxx+MNG-yyy is not necessary > > We can see in the history that it's On top and the names will get > ridiculous as you add more That's why I stopped creating even more r

Re: Progress check for 3.5.0

2017-01-22 Thread Stephen Connolly
Please just name each branch by the issue it is using Naming branches MNG-xxx+MNG-yyy is not necessary We can see in the history that it's On top and the names will get ridiculous as you add more On Sun 22 Jan 2017 at 21:12, Christian Schulte wrote: > Am 01/22/17 um 20:15 schrieb Stephen Connol

Re: Progress check for 3.5.0

2017-01-22 Thread Christian Schulte
Am 01/22/17 um 20:15 schrieb Stephen Connolly: > If you want to stack your branches in order that's fine and would save > rebasing. > > Just start with the first and push that as first issue's branch, then > continue with second issue on top of first, etc. > > We'll see from the branch history an

Re: please review MNG-5904 branch - Remove the whole Ant Build

2017-01-22 Thread Michael Osipov
Am 2017-01-22 um 19:58 schrieb Karl Heinz Marbaise: Hi, On 22/01/17 19:49, Michael Osipov wrote: Am 2017-01-22 um 17:50 schrieb Hervé BOUTEMY: everything is in the title more than removal of Ant build, what I want to have in master quite fast is the equivalent mvn -DdistributionTargetFolder="

Re: Progress check for 3.5.0

2017-01-22 Thread Michael Osipov
Am 2017-01-22 um 17:35 schrieb Christian Schulte: Am 22.01.2017 um 13:58 schrieb Michael Osipov: [..] MNG-5837 Syntax error in bin/mvn on Solaris SPARC FIX-3.5.0 This is a trivial fix but to be more precise, it has to be split it two separate issues: 1. local issue: naive Linux user appro

[VOTE] Release Apache Maven Invoker version 3.0.0 (shared component)

2017-01-22 Thread Robert Scholte
Hi, We solved 9 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317922&version=12331463&styleName=Text There are still a couple of issues left in JIRA: https://issues.apache.org/jira/issues/?jql=project%20%3D%2012317922%20AND%20%20component%20%3D%20maven-invoker%20AND%

Re: please review MNG-5904 branch - Remove the whole Ant Build

2017-01-22 Thread Michael Osipov
Am 2017-01-22 um 19:58 schrieb Karl Heinz Marbaise: Hi, On 22/01/17 19:49, Michael Osipov wrote: Am 2017-01-22 um 17:50 schrieb Hervé BOUTEMY: everything is in the title more than removal of Ant build, what I want to have in master quite fast is the equivalent mvn -DdistributionTargetFolder="

Re: Progress check for 3.5.0

2017-01-22 Thread Stephen Connolly
If you want to stack your branches in order that's fine and would save rebasing. Just start with the first and push that as first issue's branch, then continue with second issue on top of first, etc. We'll see from the branch history and if something breaks along the way we can identify it easily

Re: please review MNG-5904 branch - Remove the whole Ant Build

2017-01-22 Thread Karl Heinz Marbaise
Hi, On 22/01/17 19:49, Michael Osipov wrote: Am 2017-01-22 um 17:50 schrieb Hervé BOUTEMY: everything is in the title more than removal of Ant build, what I want to have in master quite fast is the equivalent mvn -DdistributionTargetFolder="xxx" clean package It should be DdistributionTarget

Re: please review MNG-5904 branch - Remove the whole Ant Build

2017-01-22 Thread Michael Osipov
Am 2017-01-22 um 17:50 schrieb Hervé BOUTEMY: everything is in the title more than removal of Ant build, what I want to have in master quite fast is the equivalent mvn -DdistributionTargetFolder="xxx" clean package It should be DdistributionTargetDirectory, folder is a Windows concept from Ex

Re: [VOTE] Release Apache Maven Artifact Resolver version 1.0.3

2017-01-22 Thread Robert Scholte
+1 one remark: I've created MRESOLVER-16[1] which states that the license should have a prominent spot on the site, especially since we're using the org.eclipse.aether package namespace. For now the website will be patched, next release it must be part of the release. thanks, Robert [1]

Re: Progress check for 3.5.0

2017-01-22 Thread Christian Schulte
Am 22.01.2017 um 18:14 schrieb Stephen Connolly: > Why are you needing to rebase constantly? > > Unless the merge has conflicts you should be fine pushing to master post > merge... if there is a test failure post merge (due to an unanticipated > interaction) we can just add the fix on top If some

Re: Progress check for 3.5.0

2017-01-22 Thread Stephen Connolly
Why are you needing to rebase constantly? Unless the merge has conflicts you should be fine pushing to master post merge... if there is a test failure post merge (due to an unanticipated interaction) we can just add the fix on top On Sun 22 Jan 2017 at 16:36, Christian Schulte wrote: > Am 22.01

please review MNG-5904 branch - Remove the whole Ant Build

2017-01-22 Thread Hervé BOUTEMY
everything is in the title more than removal of Ant build, what I want to have in master quite fast is the equivalent mvn -DdistributionTargetFolder="xxx" clean package Regards, Hervé - To unsubscribe, e-mail: dev-unsubscr...@

Re: Progress check for 3.5.0

2017-01-22 Thread Christian Schulte
Am 22.01.2017 um 13:58 schrieb Michael Osipov: > Am 2017-01-22 um 11:22 schrieb Stephen Connolly: >> I'm currently waiting on Hervé to start the 1.0.3 release of resolver. >> >> Once we get that I'm going to start cutting RCs (I plan 2 a week apart) >> >> Once we have a stable RC I will cut the rel

Re: [VOTE] Release Apache Maven Artifact Resolver version 1.0.3

2017-01-22 Thread Karl Heinz Marbaise
Hi, sha1 checked Ok. Tested on JDK 7, JDK 8 and JDK9+139 +1 from me.. The JDK9+139 build failed with the following message which is based on the old versions of plexus-component-metadata (1.7.1 should fix this). So no problem at the moment. maven-parent version 30 will not fix this issue c

[VOTE] Release Apache Maven Artifact Resolver version 1.0.3

2017-01-22 Thread Hervé BOUTEMY
Hi, We solved 1 issue: we renamed Aether to Maven Artifact Resolver, with exact same code as Aether 1.0.2. Staging repo: https://repository.apache.org/content/repositories/maven-1315/ https://repository.apache.org/content/repositories/maven-1315/org/apache/ maven/resolver/maven-resolver/1.0.3/m

Re: [8/8] maven git commit: [MNG-6093] use monkey patched slf4j-simple provider with Maven color

2017-01-22 Thread Hervé BOUTEMY
thanks for the review: such reviews in branches are great to fix such little things without adding stupid dedicated commits I let some more time to others to review this MNG-3507 branch before merging to master (then we'll have color back: great!) Regards, Hervé Le samedi 21 janvier 2017, 18

Re: Progress check for 3.5.0

2017-01-22 Thread Stephen Connolly
If you have a clean build, it is on the agreed list and you are not changing integration tests, merge away. If you have any doubt or concerns, raise them on the list and give it 72h. Merge if nobody comments in 72h On Sun 22 Jan 2017 at 12:58, Michael Osipov wrote: > Am 2017-01-22 um 11:22 schr

Re: reviewing Maven Artifact Resolver MNG-6007 branch

2017-01-22 Thread Hervé BOUTEMY
Le mardi 17 janvier 2017, 11:28:59 CET Robert Scholte a écrit : > http://www.apache.org/dev/licensing-howto.html#source-tree-location thanks for the pointer: it's useful > bq. > LICENSE and NOTICE belong at the top level of the source tree. They may be > named LICENSE.txt and NOTICE.txt, but the b

Re: Progress check for 3.5.0

2017-01-22 Thread Michael Osipov
Am 2017-01-22 um 11:22 schrieb Stephen Connolly: I'm currently waiting on Hervé to start the 1.0.3 release of resolver. Once we get that I'm going to start cutting RCs (I plan 2 a week apart) Once we have a stable RC I will cut the release, and start a clock towards 3.5.1 (6 weeks approx) If y

Re: Progress check for 3.5.0

2017-01-22 Thread Michael Osipov
Am 2017-01-22 um 11:22 schrieb Stephen Connolly: I'm currently waiting on Hervé to start the 1.0.3 release of resolver. Once we get that I'm going to start cutting RCs (I plan 2 a week apart) Once we have a stable RC I will cut the release, and start a clock towards 3.5.1 (6 weeks approx) If y

Progress check for 3.5.0

2017-01-22 Thread Stephen Connolly
I'm currently waiting on Hervé to start the 1.0.3 release of resolver. Once we get that I'm going to start cutting RCs (I plan 2 a week apart) Once we have a stable RC I will cut the release, and start a clock towards 3.5.1 (6 weeks approx) If you miss the boat, you can catch the next one, but w