Re: [VOTE] Release Maven Site Plugin version 3.8.2

2019-07-24 Thread Olivier Lamy
0 (mainly because you know what I'm thinking about this 1.7 thing... but I'm not here to block anything...) release note is a bit "back to the future" containing both controversial informations * [MSITE-828] - Jdk 1.8 required * [MSITE-829] - Upgrade Jetty to 9.4.12 AND * [MSITE-843]

Re: [VOTE] Release Maven Site Plugin version 3.8.2

2019-07-24 Thread Graham Leggett
On 24 Jul 2019, at 21:59, Michael Osipov wrote: > Vote open for 72 hours. > > [ ] +1 > [ ] +0 > [ ] -1 +1 :) Regards, Graham — smime.p7s Description: S/MIME cryptographic signature

Re: ITs in maven-release

2019-07-24 Thread Tibor Digana
typo: TLSv1.2 On Thu, Jul 25, 2019 at 12:14 AM Tibor Digana wrote: > I think a good compromise would be to introduce default value "TLS1.2" for > "https.protocols" in the POM section "properties" which can be overridden > in command line. > > > TLS1.2 > > > On Wed, Jul 24, 2019 at 11:37

Re: ITs in maven-release

2019-07-24 Thread Tibor Digana
I think a good compromise would be to introduce default value "TLS1.2" for "https.protocols" in the POM section "properties" which can be overridden in command line. TLS1.2 On Wed, Jul 24, 2019 at 11:37 PM Clemens Quoss wrote: > Hi Robert, > well it is already handled in the POM only for

Re: ITs in maven-release

2019-07-24 Thread Clemens Quoss
Hi Robert, well it is already handled in the POM only for JDK 7: ...       jdk7       (,1.7]           org.apache.maven.plugins maven-invoker-plugin       ${https.protocols} -Dhttps.protocols=${https.protocols}      

Re: ITs in maven-release

2019-07-24 Thread Clemens Quoss
Hi Tibor, as I already stated I was completely unaware of this whole TLS-not-being-supported-below-1.2 anymore issue. And i just tried and build maven-release successfully with JDK 7 Update 80, but using the UK mirror eplicitly in my settings. I just tried it on my laptop with maven 3.6.1 and

Re: ITs in maven-release

2019-07-24 Thread Robert Scholte
Hi Clemens, We need to stay as close as possible to the real world. With JDK8+ it should work without its being set, so the preferred way it to execute it without the value being set. And this way, once we must move TLS 1.3 we don't have to change all our tests. Here's how we do it with our

Re: [VOTE] Release Maven Site Plugin version 3.8.2

2019-07-24 Thread Tibor Digana
+1 On Wed, Jul 24, 2019 at 9:59 PM Michael Osipov wrote: > Hi, > > We solved 13 issues: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317923=12343145 > > There are still a couple of issues left in JIRA: > >

Re: ITs in maven-release

2019-07-24 Thread Clemens Quoss
Hi Robert, if TLSv1.2 is needed, then why not put it explicitly into the pom in line 266 [0] instead of using ${https.protocols}? Cheers, Clemens [0] https://github.com/apache/maven-release/blob/a94c76f77ef8df1b82e9eef370412ce9b23083a0/maven-release-plugin/pom.xml#L266 Am 23.07.2019 um

Re: [VOTE] Release Maven Site Plugin version 3.8.2

2019-07-24 Thread Michael Osipov
Am 2019-07-24 um 21:59 schrieb Michael Osipov: Hi, We solved 13 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317923=12343145 There are still a couple of issues left in JIRA:

[VOTE] Release Maven Site Plugin version 3.8.2

2019-07-24 Thread Michael Osipov
Hi, We solved 13 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317923=12343145 There are still a couple of issues left in JIRA: https://issues.apache.org/jira/issues/?jql=project%20%3D%20MSITE%20AND%20resolution%20%3D%20Unresolved Staging repo:

Re: ITs in maven-release

2019-07-24 Thread Tibor Digana
Hi Clemens, Does JDK 7u80 work for you on fresh empty local repo? It does not for me on Surefire project! The Maven fails downloading the artifacts from Maven Central this month. Before the build was okay. So I issued the ticket https://issues.apache.org/jira/browse/INFRA-18775 and I hope that

Re: Problems with checkstyle tests on Windows (Was [VOTE] Release Apache Maven Checkstyle Plugin version 3.1.0)

2019-07-24 Thread Enrico Olivelli
Il mer 24 lug 2019, 10:02 Tibor Digana ha scritto: > Hi Enrico, > > Do we have a statement from vendors of PMD and/or Checkstyle libraries that > their rules would turn to platform independence? > I know there was a pull request on GitHub and a promis with the release (I > guess PMD). > Once we

Re: Problems with checkstyle tests on Windows (Was [VOTE] Release Apache Maven Checkstyle Plugin version 3.1.0)

2019-07-24 Thread Tibor Digana
Hi Enrico, Do we have a statement from vendors of PMD and/or Checkstyle libraries that their rules would turn to platform independence? I know there was a pull request on GitHub and a promis with the release (I guess PMD). Once we would have these libraries with modified default values in favor