Re: JSR250 in the lib

2019-10-13 Thread Romain Manni-Bucau
Guess it just comes from guice or friends and since they dont support recent API it was not upgraded. We can upgrade it or just isolate it IMO - but requires some careness since custom components can use it so needs an evolution to toggle it probably. Le lun. 14 oct. 2019 à 03:43, Tibor Digana a

Re: JSR250 in the lib

2019-10-13 Thread Tibor Digana
It is a similar issue to the problem with "javax.inject" API. What about relocating these two APIs to a package "org.apache.maven"? Any thoughts? On Mon, Oct 14, 2019 at 12:11 AM Petar Tahchiev wrote: > Hello guys, > > I just decided to upgrade my build from 3.5.0 to 3.6.2 last night and I >

Re: Surefire 3.0.0-M4 release?

2019-10-13 Thread Tibor Digana
The SUREFIRE-1689 progress has been finished until the CI build succeeds. T On Sun, Oct 13, 2019 at 10:27 AM Robert Scholte wrote: > Ah, there it is :) > > On Sun, 13 Oct 2019 08:21:53 +0200, Romain Manni-Bucau > wrote: > > > Didnt expect my comment about shade to take so much space in this

JSR250 in the lib

2019-10-13 Thread Petar Tahchiev
Hello guys, I just decided to upgrade my build from 3.5.0 to 3.6.2 last night and I stumbled across multiple problems, latest one being the following exception: Nested exception is java.lang.NoSuchMethodError: javax.annotation.Resource.lookup()Ljava/lang/String; Seems like maven 3.6.2 comes

Re: Surefire 3.0.0-M4 release?

2019-10-13 Thread Robert Scholte
Ah, there it is :) On Sun, 13 Oct 2019 08:21:53 +0200, Romain Manni-Bucau wrote: Didnt expect my comment about shade to take so much space in this thread but yes we rely on asm for relocation:

Re: Surefire 3.0.0-M4 release?

2019-10-13 Thread Robert Scholte
On Sun, 13 Oct 2019 00:35:51 +0200, Tibor Digana wrote: It is ONLY required when the runtime is Java 8 or lower AND you need to read the module descriptors. thx for clarifying. Am i right if I say that it would happen with J9/Toolchain used in Compiler but J8 in the Maven build? Is it

Re: Surefire 3.0.0-M4 release?

2019-10-13 Thread Romain Manni-Bucau
Didnt expect my comment about shade to take so much space in this thread but yes we rely on asm for relocation: https://github.com/apache/maven-shade-plugin/blob/master/src/main/java/org/apache/maven/plugins/shade/DefaultShader.java#L453 Le dim. 13 oct. 2019 à 00:20, Robert Scholte a écrit : >