Re: [DISCUSS] Automatically format and sort imports

On Thu, 13 Oct 2022 at 14:38, Guillaume Nodet wrote: > > Le jeu. 13 oct. 2022 à 05:36, Olivier Lamy a écrit : > > > On Thu, 13 Oct 2022 at 02:23, Guillaume Nodet wrote: > > > > > > I'd like to propose merging the following PRs: > > > * https://github.com/apache/maven-shared-resources/pull/1 >

Re: [DISCUSS] Change maven code style

Le mer. 12 oct. 2022 à 22:02, Łukasz Dywicki a écrit : > Maybe its time to think of getting something like spotless [1] applied > to all maven sources? > I think I started the other discussion exactly for that purpose. It's not specifically about spotless, but that one is just one tool, i was

Re: [DISCUSS] Automatically format and sort imports

Le jeu. 13 oct. 2022 à 05:36, Olivier Lamy a écrit : > On Thu, 13 Oct 2022 at 02:23, Guillaume Nodet wrote: > > > > I'd like to propose merging the following PRs: > > * https://github.com/apache/maven-shared-resources/pull/1 > > * https://github.com/apache/maven-site/pull/329 > > *

Re: [DISCUSS] Automatically format and sort imports

On Thu, 13 Oct 2022 at 02:23, Guillaume Nodet wrote: > > I'd like to propose merging the following PRs: > * https://github.com/apache/maven-shared-resources/pull/1 > * https://github.com/apache/maven-site/pull/329 > * https://github.com/apache/maven/pull/824 > *

Re: [DISCUSS] Change maven code style

Agree on changing. +1 for spotless. I already used it and it's very convenient! And this will help to fix PRs which will be screwed. I didn't check in detail the format changes. But can we remove those extra useless spaces as well such: if ( !Files.exists( mojoConfigFile.toPath( ) ) ) On Thu,

Re: [DISCUSS] Change maven code style

Maybe its time to think of getting something like spotless [1] applied to all maven sources? I've seen it used in openhab [2] to rule multiple things and it works well with large codebases with multiple contributors. While it looks like there might be a middle ground between all IDEs, such

Re: [DISCUSS] Change maven code style

+1. If useful we can also add an editorconfig file to automatically configure IDEs but it’s a bit redundant with checkstyle Le mer. 12 oct. 2022 à 18:24, Guillaume Nodet a écrit : > Related to the discussion about automatically formatting and sorting > imports, I think it would be nice, given

Re: [DISCUSS] Change maven code style

Non-binding +1 from me. Gary On Wed, Oct 12, 2022, 12:23 Guillaume Nodet wrote: > Related to the discussion about automatically formatting and sorting > imports, I think it would be nice, given the big reformat commits if those > PRs are to be merged, to eventually discuss some changes to

Re: [DISCUSS] Automatically format and sort imports

Hi, Generally I'm ok for such automatic tasks - we should test if the provided configuration for the IDE is completed and when we execute reformat code in the IDE we will have the same result. śr., 12 paź 2022 o 18:51 Tamás Cservenák napisał(a): > +1 for this. Tested on resolver, that has many

Re: [DISCUSS] Change maven code style

+1 for moving braces to the end line, it is difficult especially with lambda expression śr., 12 paź 2022 o 18:52 Tamás Cservenák napisał(a): > +1 for this formatting change. > > T > > On Wed, Oct 12, 2022, 18:23 Guillaume Nodet wrote: > > > Related to the discussion about automatically

Re: [DISCUSS] Change maven code style

+1 for this formatting change. T On Wed, Oct 12, 2022, 18:23 Guillaume Nodet wrote: > Related to the discussion about automatically formatting and sorting > imports, I think it would be nice, given the big reformat commits if those > PRs are to be merged, to eventually discuss some changes to

Re: [DISCUSS] Automatically format and sort imports

+1 for this. Tested on resolver, that has many old/untouched and hence, badly formatted sources. T On Wed, Oct 12, 2022, 18:23 Guillaume Nodet wrote: > I'd like to propose merging the following PRs: > * https://github.com/apache/maven-shared-resources/pull/1 > *

[DISCUSS] Change maven code style

Related to the discussion about automatically formatting and sorting imports, I think it would be nice, given the big reformat commits if those PRs are to be merged, to eventually discuss some changes to those code style. In particular, I found out that the code is very sparse and my screen is

[DISCUSS] Automatically format and sort imports

I'd like to propose merging the following PRs: * https://github.com/apache/maven-shared-resources/pull/1 * https://github.com/apache/maven-site/pull/329 * https://github.com/apache/maven/pull/824 * https://github.com/apache/maven-resolver/pull/147 ... and more to come The idea is to use

Re: [DISCUSS] Release Maven 4.0.0-alpha-1 this week

Howdy, +1 for release alpha -1 (not vote but opinion) for snapshots in builds -- but I could live with it T On Wed, Oct 12, 2022 at 9:57 AM Maarten Mulders wrote: > Hi all, > > > TL;DR: +1 for releasing an "4.0.0-alpha-1". > > > I think that an "alpha-1" could also be of value for end users.

Re: [DISCUSS] Release Maven 4.0.0-alpha-1 this week

Hi all, TL;DR: +1 for releasing an "4.0.0-alpha-1". I think that an "alpha-1" could also be of value for end users. They might want to experiment with new features, see if they work on their project. Nowadays, I mostly hear people being reluctant to download a SNAPSHOT from a Jenkins

Re: [DISCUSS] Release Maven 4.0.0-alpha-1 this week

Oh, then isn't it a different game (exposing it for us vs for others)? +1 to enable snapshot, at least for the time we migrate the plugins used in our lifecycles. Romain Manni-Bucau @rmannibucau | Blog | Old Blog

Re: [DISCUSS] Release Maven 4.0.0-alpha-1 this week

I think the main reason is that the new API isn't stabilized yet. But having it will allow starting migrating some components / plugins to this new API. Actually, I'd be happy with a SNAPSHOT if we were to relax the fact that we don't add snapshot dependencies on master branches. Le mar. 11 oct.