Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/165
@britter
Sorry for late reply. This error is normal behavior because you used `mvn
verify`. In surefire you should use `mvn install -P run-its`.
We cannot merge master to junit5
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/163
@shafiullas
This commit is quite good but you have to fix the code style and register
this issue at JIRA.
The code conventions are listed in
https://maven.apache.org/developers
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/166#discussion_r154519321
--- Diff:
surefire-providers/surefire-testng-utils/src/main/java/org/apache/maven/surefire/testng/utils/MethodSelector.java
---
@@ -62,6 +62,17
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/166
@krmahadevan
Sorry for late reply. I was ill last time and busy in the work.
The code conventions are listed in
https://maven.apache.org/developers/conventions/code.html
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/166#discussion_r154519159
--- Diff:
surefire-providers/surefire-testng-utils/src/test/testng/utils/MethodSelectorTest.java
---
@@ -0,0 +1,299 @@
+package testng.utils
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/167
@DaGeRe
Pls run the build `mvn install -P run-its "-Djdk.home=e:\Program
Files\Java\jdk9\"` with default JDK 8 and additional JDK9 for few tests as you
can see in syste
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/167
@DaGeRe
Yes we need to add your Jira issue to a final report which is part or final
plugin release.
Only you best know all details to be written in description in Jira,
platform you
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/168
@eolivelli
Thx for contributing. Close this PR. It was pushed to master.
---
-
To unsubscribe, e-mail: dev-unsubscr
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/171
@acogoluegnes
Thx for support regarding Java 9.
Please close this PR. I extended the test and already pushed to master
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/168
The comment `[SUREFIRE-1424] javax.transaction.TransactionManager not
visible with Java9` should be in commit
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/168
If you could squash these two commits in one, it would be great.
---
-
To unsubscribe, e-mail: dev-unsubscr
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/170
@claycephas
This PR was pushed to master yesterday.
Please close this PR, Thx.
---
-
To unsubscribe, e-mail: dev
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/171#discussion_r154193802
--- Diff:
maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/SurefirePropertiesTest.java
---
@@ -70,9 +70,35 @@ public void
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/170
Thx, this PR can be closed.
---
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/167
@DaGeRe
Did you create a ticket in JIRA?
https://issues.apache.org/jira/browse/SUREFIRE
If you did, which ticket number
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/167#discussion_r154174674
--- Diff:
surefire-api/src/main/java/org/apache/maven/surefire/booter/ForkingRunListener.java
---
@@ -200,14 +200,8 @@ void sendProps
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/168
@eolivelli
We need to add a new chapter on the top in
https://github.com/apache/maven-surefire/blob/master/maven-surefire-plugin/src/site/markdown/java9.md
and add the following API
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/171#discussion_r153654392
--- Diff:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/SurefireProperties.java
---
@@ -71,13 +71,22 @@ public
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/171#discussion_r153653384
--- Diff:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/SurefireProperties.java
---
@@ -71,13 +71,22 @@ public
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/171#discussion_r153652515
--- Diff:
maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/SurefirePropertiesTest.java
---
@@ -70,9 +70,16 @@ public void
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/171#discussion_r153652056
--- Diff:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/SurefireProperties.java
---
@@ -71,13 +71,22 @@ public
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/171#discussion_r153650568
--- Diff:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/SurefireProperties.java
---
@@ -71,13 +71,22 @@ public
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/171#discussion_r153650439
--- Diff:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/SurefireProperties.java
---
@@ -71,13 +71,22 @@ public
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/168
@eolivelli
I will have a look. I was busy last week.
---
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/170
Sorry, I mean the commit message. We have one standard of naming
conventions in git history.
---
-
To unsubscribe, e
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/168
@eolivelli
I have finished my changes in master. Can you continue?
---
-
To unsubscribe, e-mail: dev-unsubscr
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/167
Did you test it with Ubuntu UTF-8 and on Windows with encoding 1252 and
with special characters and some language dialects as well
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/170
@claycephas
Nice! Please create Jira ticket and rename this PR to format:
[SUREFIRE-]
---
-
To unsubscribe, e
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/169
Thx for your effort but we have to wait for this till the version 3.0.
The branch will have more merge conflicts. Please rebase this in few months
when we will be about develop 3.0
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/168
It was done. But I don't think you can easily rebase it since some classes
were deleted or methods moved
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/168
Try to name the PR like this ([] brackets):
[SUREFIRE-1424] javax.transaction.TransactionManager not visible with Java9
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/168
I had to prefer pushing my commit regarding Jigsaw modularity supported in
Surefire project because it was too big to merge after yours. Please create a
new PR with your changes
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/168#discussion_r151860070
--- Diff:
surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/Java9FullApiIT.java
---
@@ -78,12 +83,13 @@ public void
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/168#discussion_r151860059
--- Diff: maven-surefire-plugin/src/site/markdown/java9.md ---
@@ -17,15 +17,6 @@ specific language governing permissions and limitations
under
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/150
@ckurban
I could not release `2.21.0.Jigsaw` because I was ill. It's not much work
do to.
---
-
To unsubscribe, e
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/167
Pls do it in a new PR. Here is link for Eclipse/Idea code style xml
https://maven.apache.org/developers/conventions/code.html
On Wed, Oct 11, 2017 at 8:24 PM, Tibor Digana
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/167
You completely changed code style.
Please use ASF Maven code style because here I do not see relevant changes.
On Wed, Oct 11, 2017 at 5:52 PM, DaGeRe <notificati...@github.
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/157
@owenfarrell
Yeah, I have released 2.20.1 and I had to postpone this issue for 2.21.1.
OOM was fixed in 2.20.1 and users could not wait longer. This included
Java9 support.
Java
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/150
@mpkorstanje
Currently we are cutting two versions. This week `2.20.1` and
`2.21.0.Jigsaw` next week having support with Jigsaw of Java 9.
This PR is planned in `2.20.2
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/163
@shafiullas
Please rebase your branch.
---
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/163
@shafiullas
Register in Jira and open issue in
https://issues.apache.org/jira/browse/SUREFIRE. The message of the commit and
GitHub issue should be renamed to something like
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/163#discussion_r137895395
--- Diff:
maven-surefire-report-plugin/src/main/java/org/apache/maven/plugins/surefire/report/AbstractSurefireReportMojo.java
---
@@ -34,13 +27,21
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/143
@surli
You have not answered my questions yet. Let's do it now about making
releases. Register in Jira and open issue in
https://issues.apache.org/jira/browse/SUREFIRE. The message
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/141
@britter
I think this was forgotten. Should I process it?
---
-
To unsubscribe, e-mail: dev-unsubscr
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/159
@andrew-j-cohen
We do not have rights to close this issue. Please close it!
---
-
To unsubscribe, e-mail: dev
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/114
@Fuud
This branch was rebased and pushed to master. Please close it.
Thx for contributing.
---
-
To unsubscribe
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/114
https://issues.apache.org/jira/browse/SUREFIRE-1409
---
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/164
@owenfarrell
Sorry I could not have a look. I was busy. Now I want to finish my code and
open it for contribution
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/150#discussion_r136932755
--- Diff:
surefire-providers/common-junit48/src/main/java/org/apache/maven/surefire/common/junit48/FailingMethodFilter.java
---
@@ -1,85 +0,0
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/150#discussion_r136932487
--- Diff:
surefire-providers/common-junit48/src/main/java/org/apache/maven/surefire/common/junit48/MatchMethodDescriptions.java
---
@@ -0,0 +1,74
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/150#discussion_r136932256
--- Diff:
surefire-providers/common-junit48/src/main/java/org/apache/maven/surefire/common/junit48/MatchMethodDescriptions.java
---
@@ -0,0 +1,74
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/150#discussion_r136932062
--- Diff:
surefire-providers/common-junit48/src/main/java/org/apache/maven/surefire/common/junit48/FailingMethodFilter.java
---
@@ -1,85 +0,0
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/150#discussion_r136931552
--- Diff:
surefire-integration-tests/src/test/resources/junit47-rerun-failing-tests-with-cucumber/pom.xml
---
@@ -0,0 +1,88
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/150#discussion_r136931515
--- Diff:
maven-surefire-plugin/src/site/apt/examples/rerun-failing-tests.apt.vm ---
@@ -140,10 +140,14 @@ mvn
-D${thisPlugin.toLowerCase
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/150#discussion_r136931399
--- Diff:
surefire-integration-tests/src/test/resources/junit47-rerun-failing-tests-with-cucumber/pom.xml
---
@@ -0,0 +1,88
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/157
@owenfarrell
My tests passed on this code. I have to continue to develop and refactor
more.
List testDepends = project.getTestArtifacts
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/157
@owenfarrell
I will try by myself. I will let you know with new branch and we can
discuss it.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/157
@owenfarrell
It would be easier for you not to rever 569 in this PR but create a new PR
from master. I pushed a new fix to master today. The master will be idle for
you.
---
If your
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/157#discussion_r135766258
--- Diff:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
---
@@ -847,12 +847,31 @@ private
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/157#discussion_r135765515
--- Diff:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
---
@@ -847,12 +847,31 @@ private
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/157#discussion_r135765205
--- Diff:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
---
@@ -847,12 +847,31 @@ private
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/157#discussion_r135765053
--- Diff:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
---
@@ -847,12 +847,31 @@ private
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/157
@owenfarrell
I found the root cause.
The dependency to scan is examined with outputDirectory, but IT 569 has
shources to share in `src/test/java` so the artifact would match
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/157
@owenfarrell
I built the project. It was ok but then I realized you modified IT 569
which I do not like because this was a feature and I want to guarantee that old
tests pass without
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/161
@jon-bell
Thx for contributing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/157
@JoelNGeorge
@owenfarrell
Pls let me run the build and next steps.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/159
@andrew-j-cohen
Please close this PR. It was already merged in Surefire project.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/161
@jon-bell
Ok, now your IT passed. I will run whole test set now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/162
@britter
Done. I added enforcer configuration. I hope it will be fine.
Let me know if you have something to do for me.
Sometimes I am without internet connection for several days
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/162
Sorry my bad, yes master has enforcer with JDK8 (due to javadoc checks
within compile time) however maven.compoler.source/target is 1.6.
I will have a look in to junit5 branch
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/162
@britter
Actually the master is on JDK6 and the branch junit5 could be on JDK5 that
time we created it.
Maybe you should fix the enforcer configuration to similar to the one
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/157
@owenfarrell
I have not had yet. I am reviewing other in parallel.
I will have a look in few days.
---
If your project is set up for it, you can reply to this email and have your
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/161
@jon-bell
I will investigate this issue:
`Could not find artifact org.apache.maven.surefire:it-parent:pom:1.0 in
central (https://repo.maven.apache.org/maven2)`
---
If your project
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/155
@britter
#155 and #154 are done. Pls let me know if I should continue with #153.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/155
@britter
In what order should this PR and
https://github.com/apache/maven-surefire/pull/153 be pushed?
Is https://github.com/apache/maven-surefire/pull/154 independent?
---
If your
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/161
@jon-bell
Please squash your commits into one single commit and override your branch.
Name the final commit
`[SUREFIRE-1396] Provider class path is incorrect for custom provider
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/161#discussion_r130488490
--- Diff:
surefire-integration-tests/src/test/resources/surefire-1396-pluggableproviders-classpath-provider/pom.xml
---
@@ -0,0 +1,61
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/150
ok, take your time. No worries. Just rebase the PR after your team finished
the release. Surefire need some week to make release as well.
---
If your project is set up for it, you can reply
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/161#discussion_r130447743
--- Diff:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
---
@@ -2755,7 +2755,16 @@ public
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/161#discussion_r130445462
--- Diff:
surefire-integration-tests/src/test/resources/surefire-1396-pluggableproviders-classpath-provider/pom.xml
---
@@ -0,0 +1,61
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/161#discussion_r130445317
--- Diff:
surefire-integration-tests/src/test/resources/surefire-1396-pluggableproviders-classpath-provider/pom.xml
---
@@ -0,0 +1,61
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/161#discussion_r130444914
--- Diff:
surefire-integration-tests/src/test/resources/surefire-1396-pluggableproviders-classpath-provider/pom.xml
---
@@ -0,0 +1,61
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/150
@mpkorstanje
You changed something in your code or what happened that snapshot was not
available?
Is the release 2.0.0 coming soon?
---
If your project is set up for it, you can
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/155
@britter
We have finished feature SUREFIRE 1302 and I am going get back to JUnit5.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/159
@andrew-j-cohen
thx, merged. This PR can be closed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/158
@StephenKing
Thx, this PR was pushed to master and can be closed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/160
@MatousJobanek
It should be sanity check and Mojo should fail if `threadCount` is <= 0 &&
isApplicable.
IsApplicable is TRUE if `forkMode` is "pertest"
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/157
I have been busy with other ticket. Where did we finish. Do you need a help?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/160
If you plan a new commit, pls do not create two. Amend the previous one.
Thx.
On Tue, Jul 25, 2017 at 5:29 PM, Tibor Digana <tibor.dig...@googlemail.com>
wrote:
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/160
Pls check it together with documentation of param "forkMode". I think
threadCount can be used with forkMode as well.
On Tue, Jul 25, 2017 at 4:24 PM, Matous Jobanek &
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/157
No, no.
No worries.
You should build entire project `mvn install` and not the individual IT.
The ITs cannot run separately, you can trigger it from building entire
project from
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/157
Would you add integration test?
See the module `surefire-integration-tests` and
`src/test/java/org/apache/maven/surefire/its/jiras`.
It's easy. Pickup some existing test, e.g
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/157#discussion_r125169778
--- Diff:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
---
@@ -847,12 +847,33 @@ private
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/157#discussion_r125169703
--- Diff:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
---
@@ -847,12 +847,33 @@ private
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/157#discussion_r125169693
--- Diff:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
---
@@ -847,12 +847,33 @@ private
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/157#discussion_r125169671
--- Diff:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
---
@@ -847,12 +847,33 @@ private
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/157
Pls squash both commits to one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/153#discussion_r121260609
--- Diff:
surefire-integration-tests/src/test/resources/junit-plattform/pom.xml ---
@@ -0,0 +1,58 @@
+
+
+
+http://maven.apache.org
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/153#discussion_r121260527
--- Diff:
surefire-integration-tests/src/test/resources/junit-plattform/pom.xml ---
@@ -0,0 +1,58 @@
+
+
+
+http://maven.apache.org
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/153#discussion_r121260260
--- Diff:
surefire-integration-tests/src/test/resources/junit-plattform/src/test/java/junitplattform/BasicTest.java
---
@@ -0,0 +1,65
1 - 100 of 507 matches
Mail list logo
