Re: [08/17] maven git commit: [MNG-6182] ModelResolver interface enhancements.

2017-03-19 Thread Stephen Connolly
On Sun 19 Mar 2017 at 02:58, Christian Schulte wrote: > Branch name is MNG-6182 > > < > https://git-wip-us.apache.org/repos/asf?p=maven.git;a=shortlog;h=refs/heads/MNG-6182 > > > > Commit is > > < >

Re: [08/17] maven git commit: [MNG-6182] ModelResolver interface enhancements.

2017-03-18 Thread Christian Schulte
Branch name is MNG-6182 Commit is Should I create a separate JIRA issue for this? Regards, --

Re: [08/17] maven git commit: [MNG-6182] ModelResolver interface enhancements.

2017-03-18 Thread Stephen Connolly
On Sat 18 Mar 2017 at 21:58, Christian Schulte wrote: > Am 03/18/17 um 14:04 schrieb Stephen Connolly: > > Given that these new methods actually have implementations, could we see > > about having at least a unit test of the new code - since it will not be > > covered by any

Re: [08/17] maven git commit: [MNG-6182] ModelResolver interface enhancements.

2017-03-18 Thread Christian Schulte
Am 03/18/17 um 14:04 schrieb Stephen Connolly: > Given that these new methods actually have implementations, could we see > about having at least a unit test of the new code - since it will not be > covered by any test. There would be an integration test for the code. Since nothing uses it, no

Re: [08/17] maven git commit: [MNG-6182] ModelResolver interface enhancements.

2017-03-18 Thread Stephen Connolly
Given that these new methods actually have implementations, could we see about having at least a unit test of the new code - since it will not be covered by any test. If we have no test and no usage, then we could realistically replace the implementations with `throw new