[GitHub] maven pull request: Removing redundant test

2016-05-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/maven/pull/85 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] maven pull request: Removing redundant test

2016-05-27 Thread michael-o
Github user michael-o commented on the pull request: https://github.com/apache/maven/pull/85#issuecomment-72407 I will have a look at it in the next couple of days. There might be some overlapping tests but I wanted to cover as much as possible of the code paths. --- If your

[GitHub] maven pull request: Removing redundant test

2016-05-27 Thread august782
GitHub user august782 opened a pull request: https://github.com/apache/maven/pull/85 Removing redundant test In FileSizeFormatTest, the two tests testProgressedSizeWithZeroSize and testProgressedSizeZeroAndSizeZero are exactly the same, so one of them should be deleted. This pull