Re: Encoding issues for 2.0.8

2007-06-24 Thread Hervé BOUTEMY
Le samedi 23 juin 2007, Kenney Westerhof a écrit : > Hervé BOUTEMY wrote: > > Le samedi 23 juin 2007, Brett Porter a écrit : > >> We shouldn't permit relative entities in the POM - it would cause > >> grief when deployed to the repository. > >> > >> - Brett > > > > ok, then the target API is read(I

Re: Encoding issues for 2.0.8

2007-06-23 Thread Kenney Westerhof
Hervé BOUTEMY wrote: Le samedi 23 juin 2007, Brett Porter a écrit : We shouldn't permit relative entities in the POM - it would cause grief when deployed to the repository. - Brett ok, then the target API is read(InputStream) I won't add read(URL). I think read(URL) is actually the only go

Re: Encoding issues for 2.0.8

2007-06-23 Thread Hervé BOUTEMY
Le samedi 23 juin 2007, Brett Porter a écrit : > We shouldn't permit relative entities in the POM - it would cause > grief when deployed to the repository. > > - Brett ok, then the target API is read(InputStream) I won't add read(URL). regards, Hervé > > On 23/06/2007, at 5:29 AM, Hervé BOUTEMY

Re: Encoding issues for 2.0.8

2007-06-22 Thread Brett Porter
We shouldn't permit relative entities in the POM - it would cause grief when deployed to the repository. - Brett On 23/06/2007, at 5:29 AM, Hervé BOUTEMY wrote: Le vendredi 22 juin 2007, Arnaud HERITIER a écrit : Be careful, because when you read an xml file with a reader (or an inputstream

Re: Encoding issues for 2.0.8

2007-06-22 Thread Hervé BOUTEMY
Le vendredi 22 juin 2007, Arnaud HERITIER a écrit : > Be careful, because when you read an xml file with a reader (or an > inputstream) instead of a path (or an url) you can't use relative entities > in xml (because the parser can't know where the main doc is). yes, read(InputStream) is better than

Re: Encoding issues for 2.0.8

2007-06-22 Thread Jason van Zyl
On 21 Jun 07, at 10:26 PM 21 Jun 07, Hervé BOUTEMY wrote: Le jeudi 21 juin 2007, Jason van Zyl a écrit : It seems like there are many problems with encoding that could be easily solved with a couple tweaks to modello, specifically the reader and writing so I've scheduled these for 2.0.8. There

Re: Encoding issues for 2.0.8

2007-06-22 Thread Arnaud HERITIER
Be careful, because when you read an xml file with a reader (or an inputstream) instead of a path (or an url) you can't use relative entities in xml (because the parser can't know where the main doc is). This is not a problem because we discourage the usage of xml entities in our xml documents, bu

Re: Encoding issues for 2.0.8

2007-06-22 Thread Hervé BOUTEMY
Le vendredi 22 juin 2007, Kenney Westerhof a écrit : > Hi, Hi, > > indeed, it's a case of doing new XXXInputstream( something, "encoding" ), > or a reader. Some work has been done on this, IIRC. > > The problem is that you need to prescan the xml declaration, so you start > parsing until you get t

Re: Encoding issues for 2.0.8

2007-06-22 Thread Kenney Westerhof
Hi, indeed, it's a case of doing new XXXInputstream( something, "encoding" ), or a reader. Some work has been done on this, IIRC. The problem is that you need to prescan the xml declaration, so you start parsing until you get the first xml language element that is not a comment, (an xml element

Re: Encoding issues for 2.0.8

2007-06-22 Thread Arnaud HERITIER
In maven 1.1 we are already using the stax reader/writer to support XML entities, and it's working fine... Arnaud On 22/06/07, Brett Porter <[EMAIL PROTECTED]> wrote: On 22/06/2007, at 11:38 AM, Jason van Zyl wrote: > Does it buy us anything? You've tried it so I don't know but the > source

Re: Encoding issues for 2.0.8

2007-06-21 Thread Hervé BOUTEMY
Le jeudi 21 juin 2007, Jason van Zyl a écrit : > It seems like there are many problems with encoding that could be > easily solved with a couple tweaks to modello, specifically the > reader and writing so I've scheduled these for 2.0.8. There some > patches for these and hopefully Herve will work h

Re: Encoding issues for 2.0.8

2007-06-21 Thread Brett Porter
On 22/06/2007, at 11:38 AM, Jason van Zyl wrote: Does it buy us anything? You've tried it so I don't know but the source to the xpp3 stuff isn't that big. As I understand it, the xpp3 guy works on the stax RI (not sure if he's completely moved on to doing that - I went to check the xpp3

Re: Encoding issues for 2.0.8

2007-06-21 Thread Jason van Zyl
On 21 Jun 07, at 6:23 PM 21 Jun 07, Brett Porter wrote: Sounds good. The only caution I'd exercise is that I think one of them introduces POM elements - I'm not sure if we want them into 2.0.8. If we do add them, that's fine though I'm not entirely sure what the current situation is with

Re: Encoding issues for 2.0.8

2007-06-21 Thread Brett Porter
Sounds good. The only caution I'd exercise is that I think one of them introduces POM elements - I'm not sure if we want them into 2.0.8. If we do add them, that's fine though I'm not entirely sure what the current situation is with Maven reading POMs from the repository with elements it do

Encoding issues for 2.0.8

2007-06-21 Thread Jason van Zyl
It seems like there are many problems with encoding that could be easily solved with a couple tweaks to modello, specifically the reader and writing so I've scheduled these for 2.0.8. There some patches for these and hopefully Herve will work his magic with his suggested fix. I like the ide