Re: MNG-5356 Make encrypt/decrypt logic pluggable

2012-11-13 Thread Anders Hammar
Ok. I'll see to that she signs a cla. /Anders (mobile) Den 13 nov 2012 17:28 skrev "Stephen Connolly" < stephen.alan.conno...@gmail.com>: > On 13 November 2012 15:04, Olivier Lamy wrote: > > > 2012/11/13 Anders Hammar : > > >> Changes looks good for me. > > >> > > > > > > Thanks for having a loo

Re: MNG-5356 Make encrypt/decrypt logic pluggable

2012-11-13 Thread Stephen Connolly
On 13 November 2012 15:04, Olivier Lamy wrote: > 2012/11/13 Anders Hammar : > >> Changes looks good for me. > >> > > > > Thanks for having a look! > > One specific thing I'm not sure about is the maven-security artifactId. > Is > > it good, or should we maybe use maven-crypto. maven-security coul

Re: MNG-5356 Make encrypt/decrypt logic pluggable

2012-11-13 Thread Olivier Lamy
2012/11/13 Anders Hammar : >> Changes looks good for me. >> > > Thanks for having a look! > One specific thing I'm not sure about is the maven-security artifactId. Is > it good, or should we maybe use maven-crypto. maven-security could in the > future contain more than the crypto things. > > Most o

MNG-5356 Make encrypt/decrypt logic pluggable

2012-11-13 Thread Olivier Lamy
Changes looks good for me. Most of the large changes has been done Karin Karlsson (can we have cla ?) Any special reason to use a package org.maven ? New files doesn't have license header but " //TODO: add copyright " Thanks -- Olivier Lamy Talend: http://coders.talend.com http://twitter.com/ol

Re: MNG-5356 Make encrypt/decrypt logic pluggable

2012-11-13 Thread Stephen Connolly
On 13 November 2012 11:28, Anders Hammar wrote: > > Changes looks good for me. > > > > Thanks for having a look! > One specific thing I'm not sure about is the maven-security artifactId. Is > it good, or should we maybe use maven-crypto. maven-security could in the > future contain more than the

Re: MNG-5356 Make encrypt/decrypt logic pluggable

2012-11-13 Thread Anders Hammar
> Changes looks good for me. > Thanks for having a look! One specific thing I'm not sure about is the maven-security artifactId. Is it good, or should we maybe use maven-crypto. maven-security could in the future contain more than the crypto things. Most of the large changes has been done Karin K

Fwd: MNG-5356 Make encrypt/decrypt logic pluggable

2012-11-13 Thread Olivier Lamy
resend as I have issues with my @apache.o mailbox. -- Forwarded message -- From: Olivier Lamy Date: 2012/11/12 Subject: MNG-5356 Make encrypt/decrypt logic pluggable To: Maven Developers List Changes looks good for me. Most of the large changes has been done Karin Karlsson

Re: MNG-5356: Make encrypt/decrypt logic pluggable

2012-10-04 Thread Jason van Zyl
I have another set of commits and tests but go ahead and make whatever changes you want I can work with it. On Oct 4, 2012, at 12:01 AM, Anders Hammar wrote: > Well, we have Jason's commits on trunk I believe and he's said he will > get some ITs for that. > The thing is that switching from 3.0.

Re: MNG-5356: Make encrypt/decrypt logic pluggable

2012-10-04 Thread Anders Hammar
Well, we have Jason's commits on trunk I believe and he's said he will get some ITs for that. The thing is that switching from 3.0.5 to 3.1 is not just a POM change, we need to reconfigure the ITs saying the should work on 3.0.5 to say they would work on 3.1 instead. I think we already have a coupl

Re: MNG-5356: Make encrypt/decrypt logic pluggable

2012-10-03 Thread Kristian Rosenvold
As long as we have a real and uncontroversial 3.1 change I'm happy about investing in a new version number ;) Kristian Den 3. okt. 2012 kl. 21:58 skrev Anders Hammar : >> That will probably require to bump core version to 3.1 :-) > > Right, I'd like to get this into the planned 3.1 release. > Th

Re: MNG-5356: Make encrypt/decrypt logic pluggable

2012-10-03 Thread Anders Hammar
> That will probably require to bump core version to 3.1 :-) Right, I'd like to get this into the planned 3.1 release. Thanks for bringing this up. :-) For the ITs, I think it would be good if we bumped the version of core to 3.1-SNAPSHOT as we then can correctly specify what versions these new t

Re: MNG-5356: Make encrypt/decrypt logic pluggable

2012-10-03 Thread Olivier Lamy
2012/10/3 Anders Hammar : > When using Maven in enterprise environments I often find in annoying > that encrypting passwords is a hassle to set up. I would like to have > the possibility to simplify this by, for example, re-using some > existing solution. I've created MNG-5356 to track this. > > Lo

MNG-5356: Make encrypt/decrypt logic pluggable

2012-10-03 Thread Anders Hammar
When using Maven in enterprise environments I often find in annoying that encrypting passwords is a hassle to set up. I would like to have the possibility to simplify this by, for example, re-using some existing solution. I've created MNG-5356 to track this. Looking at the code though, the current