Re: [VOTE] Release Maven Enforcer version 1.3 (take 2)

2013-06-30 Thread sebb
On 29 June 2013 11:47, Robert Scholte rfscho...@apache.org wrote: Hi Sebb, none of these files will end up in Maven Central, they are all used for tests. However, they do end up in the source release which is published via the ASF mirrors. It's vital that all released source files have the

Re: [VOTE] Release Maven Enforcer version 1.3 (take 2)

2013-06-30 Thread Stephen Connolly
On Sunday, 30 June 2013, sebb wrote: On 29 June 2013 11:47, Robert Scholte rfscho...@apache.org javascript:; wrote: Hi Sebb, none of these files will end up in Maven Central, they are all used for tests. However, they do end up in the source release which is published via the ASF

Re: [VOTE] Release Maven Enforcer version 1.3 (take 2)

2013-06-30 Thread sebb
On 30 June 2013 21:04, Stephen Connolly stephen.alan.conno...@gmail.com wrote: On Sunday, 30 June 2013, sebb wrote: On 29 June 2013 11:47, Robert Scholte rfscho...@apache.org javascript:; wrote: Hi Sebb, none of these files will end up in Maven Central, they are all used for tests.

Re: [VOTE] Release Maven Enforcer version 1.3 (take 2)

2013-06-29 Thread Robert Scholte
Hi Sebb, none of these files will end up in Maven Central, they are all used for tests. For me that's not enough reason to cancel the vote. thanks, Robert Op Thu, 27 Jun 2013 12:26:03 +0200 schreef sebb seb...@gmail.com: On 25 June 2013 21:23, Robert Scholte rfscho...@apache.org wrote:

Re: [VOTE] Release Maven Enforcer version 1.3 (take 2)

2013-06-28 Thread Hervé BOUTEMY
+1 Regards, Hervé Le mardi 25 juin 2013 22:23:13 Robert Scholte a écrit : Hi, We solved 15 issues: http://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=11530version=190 11 There are still a couple of issues left in JIRA:

Re: [VOTE] Release Maven Enforcer version 1.3 (take 2)

2013-06-28 Thread Robert Scholte
+1 Op Tue, 25 Jun 2013 22:23:13 +0200 schreef Robert Scholte rfscho...@apache.org: Hi, We solved 15 issues: http://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=11530version=19011 There are still a couple of issues left in JIRA:

Re: [VOTE] Release Maven Enforcer version 1.3 (take 2)

2013-06-27 Thread Olivier Lamy
+1 2013/6/26 Robert Scholte rfscho...@apache.org: Hi, We solved 15 issues: http://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=11530version=19011 There are still a couple of issues left in JIRA: http://jira.codehaus.org/secure/IssueNavigator.jspa?reset=truepid=11530status=1

Re: [VOTE] Release Maven Enforcer version 1.3 (take 2)

2013-06-27 Thread sebb
On 25 June 2013 21:23, Robert Scholte rfscho...@apache.org wrote: Hi, We solved 15 issues: http://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=11530version=19011 There are still a couple of issues left in JIRA:

Re: [VOTE] Release Maven Enforcer version 1.3 (take 2)

2013-06-26 Thread Tony Chemit
On Tue, 25 Jun 2013 22:23:13 +0200 Robert Scholte rfscho...@apache.org wrote: +1, tony. Hi, We solved 15 issues: http://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=11530version=19011 There are still a couple of issues left in JIRA:

Re: [VOTE] Release Maven Enforcer version 1.3

2013-06-24 Thread Baptiste MATHUS
+1 on that one: going onto a major version change like 2.x could be better here imo. I'm totally OK with releasing things that are more correct (not working correctly about artifact resolution here). But since this is likely to break a lot of internal rules (for example, it's gonna break 50% of

Re: [VOTE] Release Maven Enforcer version 1.3

2013-06-23 Thread Olivier Lamy
+1 2013/6/22 Robert Scholte rfscho...@apache.org: Hi, We solved 15 issues: http://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=11530version=19011 There are still a couple of issues left in JIRA: http://jira.codehaus.org/secure/IssueNavigator.jspa?reset=truepid=11530status=1

Re: [VOTE] Release Maven Enforcer version 1.3

2013-06-23 Thread Baptiste MATHUS
-0.9 (non binding). I just tested on a local project, codehaus mojo EnforceBytecodeVersion fails with an NPE with m-enforcer-p 1.3 but correctly thows an EnforcerRuleException with 1.2. That is, as I am the one who wrote that rule, that's perfectly possible I'm doing something stooopid in the

Re: [VOTE] Release Maven Enforcer version 1.3

2013-06-23 Thread Robert Scholte
Hi Baptiste, you're hitting the result of the changes due to MENFORCER-42[1] Up until 1.2 the dependencies were resolved instead of calculated. So if you run 'mvn validate' you can't use the results of the reactor, since those files aren't available yet. So the build will fail or it will use

Re: [VOTE] Release Maven Enforcer version 1.3

2013-06-23 Thread Baptiste MATHUS
Hi, No problem, I'll see how I can fix that. FWIW, I've just run the ITs of mojo's extra-enforcer-rules project with m-enforcer-p:1.3. This gives: [ERROR] The following builds failed: [ERROR] * enforce-bytecode-version-jdkVersionOption\pom.xml [ERROR] *

Re: [VOTE] Release Maven Enforcer version 1.3

2013-06-23 Thread Mirko Friedenhagen
Hello, I did the tests wrongly for extra-enforcer-rules, the new version of enforcer is backwards incompatible: org.apache.maven.plugins.enforcer.AbstractStandardEnforcerRule had a public message field in 1.2, this is now (1.3) private and uses getMessage and setMessage methods. This would mean

Re: [VOTE] Release Maven Enforcer version 1.3

2013-06-22 Thread Mirko Friedenhagen
+1 (non-binding) tested with two homegrown plugins, the extra-enforcer-rules and one small multi-module project. Regards Mirko -- http://illegalstateexception.blogspot.com/ https://github.com/mfriedenhagen/ https://bitbucket.org/mfriedenhagen/ On Sat, Jun 22, 2013 at 2:26 PM, Robert Scholte