Re: Shade improvement: filtering

2008-01-16 Thread Mauro Talevi
David Blevins wrote: Mauro, is it possible you can publish a new snapshot or update the perms on the metadata files? Done both. Cheers - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL

Shade improvement: filtering

2008-01-15 Thread David Blevins
I need the ability to include/exclude classes from certain artifacts when creating the shaded jar. In OpenEJB we have a situation where one of the jars we are adding to the shaded jar contains a class also part of another jar added to the shade. The class in question truly belongs to one

Re: Shade improvement: filtering

2008-01-15 Thread Daniel Kulp
David, I'm OK with you committing this except for a few minor nits: 1) Javadoc for the parameter you added. The description about the includes/excludes needs to be added to the javadoc for the parameter so the generated site has that information. 2) Code formatting isn't quite right for

Re: Shade improvement: filtering

2008-01-15 Thread David Blevins
Thanks for reviewing! On Jan 15, 2008, at 6:09 PM, Daniel Kulp wrote: David, I'm OK with you committing this except for a few minor nits: 1) Javadoc for the parameter you added. The description about the includes/excludes needs to be added to the javadoc for the parameter so the

Re: Shade improvement: filtering

2008-01-15 Thread David Blevins
On Jan 15, 2008, at 6:47 PM, David Blevins wrote: Thanks for reviewing! On Jan 15, 2008, at 6:09 PM, Daniel Kulp wrote: David, I'm OK with you committing this except for a few minor nits: 1) Javadoc for the parameter you added. The description about the includes/excludes needs to be

Re: Shade improvement: filtering

2008-01-15 Thread David Blevins
Mauro, is it possible you can publish a new snapshot or update the perms on the metadata files? -David On Jan 15, 2008, at 9:02 PM, David Blevins wrote: On Jan 15, 2008, at 6:47 PM, David Blevins wrote: Thanks for reviewing! On Jan 15, 2008, at 6:09 PM, Daniel Kulp wrote: David, I'm