Re: cdi-api leaking?

Perfect, thanks a lot for the help. Let me know if I can support him - even if I guess you are already doing it ;). Le mer. 9 déc. 2020 à 21:02, Michael Osipov a écrit : > Am 2020-12-09 um 11:39 schrieb Romain Manni-Bucau: > > Any issue moving forward on https://github.com/apache/maven/pull/408

Re: cdi-api leaking?

Am 2020-12-09 um 11:39 schrieb Romain Manni-Bucau: Any issue moving forward on https://github.com/apache/maven/pull/408 ? No issue, I have delegated the IT to a former colleague who is looking for simple issues to contribute. Turning your test case into an IT seems like a perfect fit. M

Re: cdi-api leaking?

+1 for dropping. Also already had problems with it. LieGrue, strub > Am 01.12.2020 um 17:50 schrieb Romain Manni-Bucau : > > Up, > > Encountered a few bugs related to this regression, wonder how we want to > tackle it. > My 2cts would be to drop cdi-api and replace the single used > annotation

Re: cdi-api leaking?

I'm missing an integration-test that confirms the need for this, otherwise I expect this discussion might pop up again every several years. Just ensure it breaks if the exported packages are activated again for clear reasons. Robert On 9-12-2020 11:39:35, Romain Manni-Bucau wrote: Any issue

Re: cdi-api leaking?

Any issue moving forward on https://github.com/apache/maven/pull/408 ? Romain Manni-Bucau @rmannibucau | Blog | Old Blog | Github | LinkedIn

Re: cdi-api leaking?

created https://github.com/apache/maven/pull/408 about it Romain Manni-Bucau @rmannibucau | Blog | Old Blog | Github | LinkedIn

Re: cdi-api leaking?

Up, Encountered a few bugs related to this regression, wonder how we want to tackle it. My 2cts would be to drop cdi-api and replace the single used annotation from there by a maven one. If we don't want to break plugins (not sure any use that) we can rewrite it with asm or equivalent at load

Re: cdi-api leaking?

commented inline Romain Manni-Bucau @rmannibucau | Blog | Old Blog | Github | LinkedIn | Book

Re: cdi-api leaking?

On Tuesday, 6 February 2018 at 13:25, Romain Manni-Bucau wrote: > 2018-02-06 12:25 GMT+01:00 Stuart McCulloch (mailto:mccu...@gmail.com)>: > > > The "javax.enterprise.inject" CDI package was explicitly exported as part > > of the ongoing effort to migrate legacy Plexus

Re: cdi-api leaking?

2018-02-06 12:25 GMT+01:00 Stuart McCulloch : > The "javax.enterprise.inject" CDI package was explicitly exported as part > of the ongoing effort to migrate legacy Plexus components onto more modern > standard annotations. > Hmm, this looks wrong from my window cause Maven

Re: cdi-api leaking?

The "javax.enterprise.inject" CDI package was explicitly exported as part of the ongoing effort to migrate legacy Plexus components onto more modern standard annotations. Specifically, the @javax.enterprise.inject.Typed annotation lets components state they are only visible for injection under

Re: cdi-api leaking?

2018-02-06 9:41 GMT+01:00 Tibor Digana : > Personally I would like to see a new Git branch with CDI 2.0 and the > integration test results on Jenkins. > This would give us more confidence. > Question: Does the CDI 2.0 have any NEW mandatory descriptive methods > without

Re: cdi-api leaking?

Personally I would like to see a new Git branch with CDI 2.0 and the integration test results on Jenkins. This would give us more confidence. Question: Does the CDI 2.0 have any NEW mandatory descriptive methods without default value already introduced in OLD annotations CDI 1.0/1.1? On Tue, Feb

Re: cdi-api leaking?

For the reproducer here it is https://github.com/rmannibucau/test-maven-plugin - pretty trivial you'll see ;). 2018-02-06 8:05 GMT+01:00 Tibor Digana : > Changing the package would not be possible in 3.x. > Why? In particular since it is an old regression already

Re: cdi-api leaking?

Changing the package would not be possible in 3.x. Guessing the version 4.0.0. WDYT? On Tue, Feb 6, 2018 at 8:01 AM, Tibor Digana wrote: > The question is maybe about what is realistic for Maven devs. > Shading the CPI package (to something like org.apache.maven.cdi.*)

Re: cdi-api leaking?

The question is maybe about what is realistic for Maven devs. Shading the CPI package (to something like org.apache.maven.cdi.*) would be maybe the case instead of removing the original CDI and reinventing the wheel. On Tue, Feb 6, 2018 at 7:52 AM, Hervé BOUTEMY wrote: >

Re: cdi-api leaking?

and does the MNG issue contain a reproducible test case for us to investigate more precisely? Regards, Hervé Le lundi 5 février 2018, 22:11:56 CET Robert Scholte a écrit : > Is there a MNG[1] issue? > > Robert > > [1] https://issues.apache.org/jira/browse/MNG > > On Sat, 03 Feb 2018

Re: cdi-api leaking?

Created https://issues.apache.org/jira/browse/MNG-6354 A more advanced solution would be to enable plugins to customize what they import. Romain Manni-Bucau @rmannibucau | Blog | Old Blog

Re: cdi-api leaking?

On 6 February 2018 at 06:08, Romain Manni-Bucau wrote: > I do and it works in several cases but it is a lot of work to handle the > classloader right and found several plugins just broken cause they use a > parent first strategy. This API being so easily pulled -

Re: cdi-api leaking?

I do and it works in several cases but it is a lot of work to handle the classloader right and found several plugins just broken cause they use a parent first strategy. This API being so easily pulled - spring/jaxrs can easily pull it - it shouldnt sit here by default IMHO. Dont think there is a

Re: cdi-api leaking?

This must be a big problem for you actually. Can you use isolated ClassLoader, set Context ClassLoader in current Thread and back the origin, reflectively create a new instance of a factory and build an object which runs your code during the plugin execution? When the plugin's job has finally

Re: cdi-api leaking?

Is there a MNG[1] issue? Robert [1] https://issues.apache.org/jira/browse/MNG On Sat, 03 Feb 2018 16:29:49 +0100, Romain Manni-Bucau wrote: Up? Le 19 janv. 2018 13:18, "Romain Manni-Bucau" a écrit : Hi guys, cdi-api is still in maven lib

Re: cdi-api leaking?

Up? Le 19 janv. 2018 13:18, "Romain Manni-Bucau" a écrit : > Hi guys, > > cdi-api is still in maven lib and breaks any plugin using it since it is > an old version, can it be dropped or at least isolated from plugin > classloaders? > > Thanks, > Romain Manni-Bucau >

cdi-api leaking?

Hi guys, cdi-api is still in maven lib and breaks any plugin using it since it is an old version, can it be dropped or at least isolated from plugin classloaders? Thanks, Romain Manni-Bucau @rmannibucau | Blog | Old Blog