platform dependent newline is a feature, to respect user platform
I see your preference and agree to disagree: it's definitely a no for me on
this
Le dimanche 17 janvier 2021, 18:41:33 CET Elliotte Rusty Harold a écrit :
> On Sun, Jan 17, 2021 at 3:41 PM Hervé BOUTEMY wrote:
> > there is a chec
On Sun, Jan 17, 2021 at 3:41 PM Hervé BOUTEMY wrote:
>
> there is a checkError() method we should probably check before closing, that
> seems a good idea
>
Remembering (and forgetting) to call an error checking method at the
right time is the unreliable anti-pattern IOException was created to
avo
there is a checkError() method we should probably check before closing, that
seems a good idea
Le samedi 16 janvier 2021, 20:49:53 CET Elliotte Rusty Harold a écrit :
> On Sat, Jan 16, 2021 at 8:31 AM Hervé BOUTEMY wrote:
> > I see this objection more and more lately.
> > I don't really understa
On Sat, Jan 16, 2021 at 8:31 AM Hervé BOUTEMY wrote:
>
> I see this objection more and more lately.
> I don't really understand it, I consider it vaguely theoretical, and don't see
> any concrete issue.
>
This is very much a concrete issue. I/O is unreliable. Sometimes it
fails. When it does an I
I don't remember the discussion.
What do you think about JSR-330 in plugin code?
sob., 16 sty 2021 o 09:37 Hervé BOUTEMY napisał(a):
> my strategy in this plugin was to use maven-shared-utils, of course when
> no
> API exists in JDK
> If I did it wrong in some cases, don't hesitate to provide a
my strategy in this plugin was to use maven-shared-utils, of course when no
API exists in JDK
If I did it wrong in some cases, don't hesitate to provide a PR
And if there is a newer version of JDK that provides APIs to replace maven-
shared-utils, we should document it in maven-shared-utils, and t
PR welcome: yes, that would be nice
Le vendredi 15 janvier 2021, 12:54:36 CET Elliotte Rusty Harold a écrit :
> There are some good integration tests. Unit tests would help round this out.
>
> Most classes and method appear public by default. It's not obvious
> they need to be. I think almost all
I see this objection more and more lately.
I don't really understand it, I consider it vaguely theoretical, and don't see
any concrete issue.
but I see a concrete issue on using OutputStreamWriter API instead of
PrintWriter: I don't have "println(...)"
perhaps something should be reported to th
PR welcome for deprecation removal
on JDK 8, I'm -1 because I know that it's a one char update in a pom file, but
I don't see any benefit, I only see drawback: it can be used in less cases.
And concretely, on Reproducible Central [1], if I upgrade JDK prerequisite to
JDK 8, I have 16 releases th
thank you Matthieu
on splitting buildinfo generation and check, everybody starts with this logic
when thinking, even me. Then during implementation, I discovered that in
reality we don't check against a downloaded reference buildinfo file, but we
check against a reference buildinfo that we buil
Hi,
I use
org.apache.maven.repository.RepositorySystem#createArtifactWithClassifier -
it is not
Maybe the java version can also be upgraded to 1.8 New plugin and start
with 1.7 is a special requirement for it?
pt., 15 sty 2021 o 12:50 Elliotte Rusty Harold
napisał(a):
> I noticed this code i
We've already discussed this.
The name is intended to be generic and can be seen as a "brother" of the
maven-dependency-plugin.
Where the dependency plugin handles the (dependency) graph, the artifact plugin
is about the (artifact) file.
I expect more goals to be added.
thanks,
Robert
On 15-1-20
Where possible I'd try to replace plexus utils such as StringUtils and
FileUtils with better maintained JDK or Apache commons alternatives.
On Thu, Jan 14, 2021 at 7:10 PM Hervé BOUTEMY wrote:
>
> I want to release Maven Artifact Plugin soon, version 0.1
>
> I did a first documentation:
> https:/
There are some good integration tests. Unit tests would help round this out.
Most classes and method appear public by default. It's not obvious
they need to be. I think almost all of them could be private or
package private instead. They can always be made public later if a
need is uncovered, but
The use of PrintWriter in BuildInfoWriter is error prone because it
swallows exceptions. This should be replaced with an
OutputStreamWriter.
On Thu, Jan 14, 2021 at 7:10 PM Hervé BOUTEMY wrote:
>
> I want to release Maven Artifact Plugin soon, version 0.1
>
> I did a first documentation:
> https:
I noticed this code in ReferenceBuildInfo:
Artifact buildinfo =
artifactFactory.createArtifactWithClassifier(
project.getGroupId(), project.getArtifactId(),
project.getVersion(), "buildinfo", "" );
The problem is that ArtifactFactory is deprecated and has been fo
The name of this plugin, Maven Artifact Plugin, seems very generic. It
really gives no indication of its purpose. Perhaps consider a rename
at this early stage to maven-buildinfo-plugin or
maven-reproduce-plugin.
On Thu, Jan 14, 2021 at 7:10 PM Hervé BOUTEMY wrote:
>
> I want to release Maven Art
Hi Hervé,
As far as I understood the docs, the _buildinfo_ goal has 2 purposes:
1. generate the .buildinfo file
2. optionally check it against some reference
Shouldn't these two use cases be provided by two different goals?
By having them in the same goal the "reference.repo" property "pollutes"
I want to release Maven Artifact Plugin soon, version 0.1
I did a first documentation:
https://maven.apache.org/plugins-archives/maven-artifact-plugin-LATEST/
review, feedback, PRs welcome
Regards,
Hervé
-
To unsubscribe,
19 matches
Mail list logo
