[GitHub] maven pull request #105: MNG-6173 MavenSession.getAllProjects() should retur...

GitHub user cboehme opened a pull request: https://github.com/apache/maven/pull/105 MNG-6173 MavenSession.getAllProjects() should return all projects in the reactor This commit moves the initialisation of the allProjects field in MavenSession into the DefaultGraphBuilder as the

Re: Recent issues found in Surefire master/Maven Clean Plugin 3.0.0 with Maven master

Am 02/20/17 um 01:10 schrieb Tibor Digana: > Can somebody explore what is different between these two surefire builds > (failed and successful) and why?: > https://builds.apache.org/view/Maven%20Master%20Release%20Status/ This one is run with current Maven master using JDK 7. >

Re: Recent issues found in Surefire master/Maven Clean Plugin 3.0.0 with Maven master

Am 02/20/17 um 01:10 schrieb Tibor Digana: > I meant this build which is in good conditions > https://builds.apache.org/view/Maven%20Master%20Release%20Status/job/maven-master-release-status-test-surefire-linux/30/console > > Can somebody explore what is different between these two surefire

Re: Build of maven-dependency-analyzer fails on Windows.

Am 02/20/17 um 01:53 schrieb Christian Schulte: > Hi, > > I cannot build 'maven-dependency-analyzer' trunk on Windows. Is there > some dependency I could upgrade to get this going? This is what I am > doing locally: > > svn checkout /repos/asf/maven/shared/trunk/maven-dependency-analyzer >

Build of maven-dependency-analyzer fails on Windows.

Hi, I cannot build 'maven-dependency-analyzer' trunk on Windows. Is there some dependency I could upgrade to get this going? This is what I am doing locally: svn checkout /repos/asf/maven/shared/trunk/maven-dependency-analyzer cd maven-dependency-analyzer mvn verify

Re: Recent issues found in Surefire master/Maven Clean Plugin 3.0.0 with Maven master

Am 02/20/17 um 01:10 schrieb Tibor Digana: > I meant this build which is in good conditions > https://builds.apache.org/view/Maven%20Master%20Release%20Status/job/maven-master-release-status-test-surefire-linux/30/console This points to a console with IT failures. That build never succeeded on

Re: Recent issues found in Surefire master/Maven Clean Plugin 3.0.0 with Maven master

@Michael I have pushed new experimental changes with *FileDescriptor.out* in the branch 2.19.2-experimental. Can you pls trigger the build on FreeBSD? I use only one IT and the build passed successfully - ForkedModeIT. Running org.apache.maven.surefire.its.ForkModeIT Tests run: 12, Failures: 0,

Re: Recent issues found in Surefire master/Maven Clean Plugin 3.0.0 with Maven master

I meant this build which is in good conditions https://builds.apache.org/view/Maven%20Master%20Release%20Status/job/maven-master-release-status-test-surefire-linux/30/console Can somebody explore what is different between these two surefire builds (failed and successful) and why?:

Re: Recent issues found in Surefire master/Maven Clean Plugin 3.0.0 with Maven master

Am 02/19/17 um 23:58 schrieb Tibor Digana: > and they are getting really nervous. So we have to make a release and later > we will finish fix for FreeBSD. I am still facing native problem with > reliably streaming data over standard output streams with subprocess. > We with Kristian Roselvold were

Re: Recent issues found in Surefire master/Maven Clean Plugin 3.0.0 with Maven master

Currently there is another issue. Events from plugin don't arrive to forked jvm. I have placed more logs. We will run the ITs again with Michael tomorrow. I open to check logs in the morning and in the evening. The Version 2.19.1 has these issues as well. So it is not a regression. We have to

Re: Recent issues found in Surefire master/Maven Clean Plugin 3.0.0 with Maven master

Especially as we know the forked money should *exit before* the main process, so we should be able to flush the ACK... The timeout would just be a fallback to prevent zombies On Sun 19 Feb 2017 at 21:09, Michael Osipov wrote: > I made this proposal to Tibor too. The forked

Re: Recent issues found in Surefire master/Maven Clean Plugin 3.0.0 with Maven master

I made this proposal to Tibor too. The forked VM sends the Z, waits for an ACK and then exits. This should be idiot proof. Am 2017-02-19 um 22:04 schrieb Stephen Connolly: Can we invert the sequence? The forked process sends a Z Then the controller sends back an ACK of some sort. If the

Re: Recent issues found in Surefire master/Maven Clean Plugin 3.0.0 with Maven master

Can we invert the sequence? The forked process sends a Z Then the controller sends back an ACK of some sort. If the forked process hasn't received the ACK say 5s after sending the Z is just says screw it and does an exit? On Sun 19 Feb 2017 at 20:34, Christian Schulte wrote: >

Re: Recent issues found in Surefire master/Maven Clean Plugin 3.0.0 with Maven master

Am 19.02.2017 um 21:10 schrieb Michael Osipov: > Am 2017-02-19 um 19:54 schrieb Christian Schulte: >> Am 02/19/17 um 19:52 schrieb Christian Schulte: >>> Am 02/19/17 um 19:47 schrieb Christian Schulte: Am 02/19/17 um 13:06 schrieb Michael Osipov: > Socket give you, of course, a lot of

Re: Recent issues found in Surefire master/Maven Clean Plugin 3.0.0 with Maven master

Am 2017-02-19 um 19:54 schrieb Christian Schulte: Am 02/19/17 um 19:52 schrieb Christian Schulte: Am 02/19/17 um 19:47 schrieb Christian Schulte: Am 02/19/17 um 13:06 schrieb Michael Osipov: Socket give you, of course, a lot of control, but they also impose an overhead compares to named pipes

Re: Recent issues found in Surefire master/Maven Clean Plugin 3.0.0 with Maven master

"Initially, the standard error stream is unbuffered; " Maybe just use System.err instead of System.out to avoid any buffering, if there is no other solution. - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For

Re: Recent issues found in Surefire master/Maven Clean Plugin 3.0.0 with Maven master

Am 02/19/17 um 19:52 schrieb Christian Schulte: > Am 02/19/17 um 19:47 schrieb Christian Schulte: >> Am 02/19/17 um 13:06 schrieb Michael Osipov: >>> Socket give you, of course, a lot of control, but they also impose an >>> overhead compares to named pipes (mkfifo, CreateNamePipe). >>> >>> I

Re: Recent issues found in Surefire master/Maven Clean Plugin 3.0.0 with Maven master

Am 02/19/17 um 19:47 schrieb Christian Schulte: > Am 02/19/17 um 13:06 schrieb Michael Osipov: >> Socket give you, of course, a lot of control, but they also impose an >> overhead compares to named pipes (mkfifo, CreateNamePipe). >> >> I think our biggest problem is that stdout is subject to

Re: Recent issues found in Surefire master/Maven Clean Plugin 3.0.0 with Maven master

Am 02/19/17 um 13:06 schrieb Michael Osipov: > Socket give you, of course, a lot of control, but they also impose an > overhead compares to named pipes (mkfifo, CreateNamePipe). > > I think our biggest problem is that stdout is subject to buffering > issues and in case if System#exit() status Z

Re: svn commit: r1783494 - /maven/shared/branches/maven-shared-utils-0.9.x/src/main/java/org/apache/maven/shared/utils/cli/StreamFeeder.java

yes, PrintStream, but we have OutputStream which does not flush like PrintStream. Nevertheless, I found we implement FlushReceiver which allows me to flush entire word. This fix flushed a byte. So we perform better in Surefire with flushed word and maybe we would not need to have this fix in

Re: Recent issues found in Surefire master/Maven Clean Plugin 3.0.0 with Maven master

On Sun 19 Feb 2017 at 12:06, Michael Osipov wrote: > Socket give you, of course, a lot of control, but they also impose an > overhead compares to named pipes (mkfifo, CreateNamePipe). Yep but windows restricts choice of technology. Docker for Windows (as in where Windows

Re: Recent issues found in Surefire master/Maven Clean Plugin 3.0.0 with Maven master

On Sun 19 Feb 2017 at 11:51, Tibor Digana wrote: > Too much work for socket, and port can be used by other process. Random assignment of port and pass the "secret" on launch. Any unexpected socket connection you just reject. Yes it is more work but how cool to have

Re: Recent issues found in Surefire master/Maven Clean Plugin 3.0.0 with Maven master

Michael, pls try to build now. It might be multiple issues we are facing. The threading issue workaround was pushed to 2.19.2-experimental. On Sun, Feb 19, 2017 at 1:07 PM, Michael Osipov-2 [via Maven] < ml-node+s40175n5899236...@n5.nabble.com> wrote: > Socket give you, of course, a lot of

Re: Recent issues found in Surefire master/Maven Clean Plugin 3.0.0 with Maven master

Socket give you, of course, a lot of control, but they also impose an overhead compares to named pipes (mkfifo, CreateNamePipe). I think our biggest problem is that stdout is subject to buffering issues and in case if System#exit() status Z is the buffer, never written out. Surefire thinks

Re: Recent issues found in Surefire master/Maven Clean Plugin 3.0.0 with Maven master

Too much work for socket, and port can be used by other process. But We have good news, see IRC [12:43] ThreadedStreamConsumer#23504796 run() :: items :: Z,0,BYE! [12:43] we received Z [12:44] now I have to find why ForkStarter is faster to check the Z event [12:45] because ForkStarter does

Re: Recent issues found in Surefire master/Maven Clean Plugin 3.0.0 with Maven master

What about using a local host bound socket rather than studio? In fact a socket could open up other options like forking the tests inside docker, or running the surefire forks on remote JVMs. Plus we gain more control (modulo TCP retry/timeouts) On Sun 19 Feb 2017 at 11:16, Tibor Digana

Re: Recent issues found in Surefire master/Maven Clean Plugin 3.0.0 with Maven master

Currently I placed sleep(1sec) before child process exit(0). If the reader process ThreadedStreamConsumer would read buffer entirely within 1 sec and the build pass then I have to add a confirmation mechanism where the exit event must be confirmed by plugin until short period of time. Later we

Re: Recent issues found in Surefire master/Maven Clean Plugin 3.0.0 with Maven master

Am 2017-02-18 um 23:19 schrieb Christian Schulte: Am 02/17/17 um 21:48 schrieb Michael Osipov: Hi folks, Christian Schulte asked me a couple of days ago wether I am able to build Surefire master with Maven master. It was constantly failing for him on his OpenBSD machines. Since I have several