Re: I think we are ready for 3.5.0-alpha-1

2017-02-21 Thread Tibor Digana
Stephen, so you avoided the duplicates. I have questions. Is it really necessary to keep duplicates of system properties in *List** args*? Is it necessary to pass ordered duplicates to CLI Manager and to rely on CLI Manager to take care of removing duplicates? *CommandLine config =

Injecting MavenProject

2017-02-21 Thread Petar Tahchiev
Hello guys, I've recently found out something weird while working with the asciidoctor maven plugin.My project has the following structure: PARENT: - MODULEA - MODULEB - MODULEC and the asciidoctor team have created this doxia parser to be able to render asciidoc content as part of your

Re: I think we are ready for 3.5.0-alpha-1

2017-02-21 Thread Stephen Connolly
On 21 February 2017 at 09:35, Tibor Digana wrote: > Stephen, so you avoided the duplicates. > I have questions. > > Is it really necessary to keep duplicates of system properties in > *List** args*? > Is it necessary to pass ordered duplicates to CLI Manager and to rely

Extensions

2017-02-21 Thread Jörg Schaible
Hi, Maven supports an own extension mechanism described in https://maven.apache.org/pom.html#Extensions. I was under the expresseion that it can be used to inject new components into the Plexus container that are available for any other plugin (as long as they set the extensions flag to

Re: Injecting MavenProject

2017-02-21 Thread Igor Fedorenko
MavenProject is injected as a MojoExecutionScope'd component (see DefaultBuildPluginManager around line 119). Since old-style Plexus components are singleton's by default, there is only one AsciidoctorParser instance which holds the first MavenProject it was used with for the entire build. Couple

Re: Fwd: How to name modules, automatic and otherwise

2017-02-21 Thread Stephen Connolly
Yep. We can be opinionated, but we should allow others to follow their own opinions (even if they are "wrong")... we just don't have to make it easy! On Tue 21 Feb 2017 at 22:16, Hervé BOUTEMY wrote: > Maven tool can't check everything against developper's will: we

Re: Injecting MavenProject

2017-02-21 Thread Hervé BOUTEMY
IIUC, this feature is available since Maven 3.2.1 (MNG-5530) Regards, Hervé Le mardi 21 février 2017, 22:54:41 CET Igor Fedorenko a écrit : > MavenProject is injected as a MojoExecutionScope'd component (see > DefaultBuildPluginManager around line 119). Since old-style Plexus > components are

Re: I think we are ready for 3.5.0-alpha-1

2017-02-21 Thread Robert Scholte
This looks better to me. Thanks, Robert Verzonden vanaf Samsung Mobile. Oorspronkelijk bericht Van: Stephen Connolly Datum:21-02-2017 01:16 (GMT+01:00) Aan: Maven Developers List Onderwerp: Re: I think we are ready

Re: Injecting MavenProject

2017-02-21 Thread Hervé BOUTEMY
ie. see line 61 of the maven-plugin-tools annotations reference documentation http://maven.apache.org/plugin-tools/maven-plugin-tools-annotations/ index.html#Supported_Annotations Regards, Hervé Le mardi 21 février 2017, 19:47:05 CET Robert Scholte a écrit : > On Tue, 21 Feb 2017 16:16:55

Re: Fwd: How to name modules, automatic and otherwise

2017-02-21 Thread Hervé BOUTEMY
Maven tool can't check everything against developper's will: we already have bad reputation because we put contraints on the build. We can't force people, we can't enforce rules. We can define good conventions and ease their use. Regards, Hervé Le mardi 21 février 2017, 03:41:12 CET

Re: Injecting MavenProject

2017-02-21 Thread Robert Scholte
On Tue, 21 Feb 2017 16:16:55 +0100, Petar Tahchiev wrote: Hello guys, I've recently found out something weird while working with the asciidoctor maven plugin.My project has the following structure: PARENT: - MODULEA - MODULEB - MODULEC and the asciidoctor team

Re: I think we are ready for 3.5.0-alpha-1

2017-02-21 Thread Stephen Connolly
Argh! [ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.17:test (default-test) on project maven-it-plugin-class-loader: Execution default-test of goal org.apache.maven.plugins:maven-surefire-plugin:2.17:test failed: The forked VM terminated without properly saying

Re: I think we are ready for 3.5.0-alpha-1

2017-02-21 Thread Stephen Connolly
now using the branch name m6078... hopefully that will pull the windows builds under the limit On 21 February 2017 at 16:04, Stephen Connolly < stephen.alan.conno...@gmail.com> wrote: > Argh! > > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-surefire-plugin:2.17:test