Re: HPI plugin

Hi Benjamin, Sorry for the confusion, but my question was directed to the Maven core committers. Basil - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org

Re: HPI plugin

Basil, I am a Maven committer. If you want to have replies from specific persons, don't use the developer mailing list. There is no such role as a core committer. There's only the PMC, which are not necessarily the most active committers. To be honest, I don't think "core" committers will give yo

Re: [VOTE] Release Apache Maven 4.0.0-alpha-7

niedz., 25 cze 2023 o 12:33 Karl Heinz Marbaise napisał(a): > Hi, > > I've tested several projects with it and also in relationship with Maven > 3.9.X.. > > The same as in Maven 3.9.3 .. plugins used which have issues like the > maven-site-plugin (3.12.1) and being reported via > `-Dmaven.plugin.

Re: HPI plugin

Howdy, In general looks ok (aside the plugin artifactId, that is a valid concern), but here are few remarks: * get rid org.apache.maven.shared.dependency.graph.DependencyGraphBuilder (maven-dependency-tree). While not officially deprecated (yet), this suffers from same issues as all other legacy/m

Re: HPI plugin

What was left out: get rid of get rid org.apache.maven.shared.dependency.graph.DependencyGraphBuilder and replace it with direct resolver, you can find plenty of examples here https://github.com/apache/maven-resolver/tree/master/maven-resolver-demos/maven-resolver-demo-snippets/src/main/java/org/ap

Re: [VOTE] Release Apache Maven 4.0.0-alpha-7

One finding after my tests: https://issues.apache.org/jira/browse/MNG-7825 sob., 24 cze 2023 o 12:56 Guillaume Nodet napisał(a): > I'm starting a new vote to release this new alpha. > > 67 issues solved: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12316922&version=123530

Re: [VOTE] Release Apache Maven 3.9.3

Howdy, created https://issues.apache.org/jira/browse/MNG-7826 as it seems that: * jacoco 0.8.10 is "bad" in this respect (FTR is fixed but not yet released, see JIRA issue), * validation report by Maven 3.9.2 is correct, * while Maven 3.9.3 misses to report it This is not a deal-breaker, but seem

[RESULT] [VOTE] Release Apache Maven 3.9.3

Howdy, The vote has passed with the following result: +1b: Romain, Henning, Karl Heinz +2nb: Delany PMC quorum: reached I will promote the artifacts to the central repo, the source release ZIP file and add this release to the board report. Thanks T

Re: [VOTE] Release Apache Maven 3.9.3

And just as an afterthought... This is clear example of "good outcome" of plugin warning, see this issue: https://github.com/jacoco/jacoco/issues/1435 If these would NOT be shown by default to users, I assume this issue would never be reported either. T On Mon, Jun 26, 2023 at 12:47 PM Tamás C

Re: [VOTE] Release Apache Maven 3.9.3

+1 pt., 23 cze 2023 o 15:34 Tamás Cservenák napisał(a): > Howdy, > > We solved 22 issues: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12316922&version=12353255 > > There are still a couple of issues left in JIRA: > > https://issues.apache.org/jira/issues/?jql=project%20%

Re: [VOTE] Release Apache Maven 3.9.3

+1 Le ven. 23 juin 2023 à 15:34, Tamás Cservenák a écrit : > Howdy, > > We solved 22 issues: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12316922&version=12353255 > > There are still a couple of issues left in JIRA: > > https://issues.apache.org/jira/issues/?jql=project%

Re: [VOTE] Release Apache Maven 4.0.0-alpha-7

+1 sob., 24 cze 2023 o 12:56 Guillaume Nodet napisał(a): > I'm starting a new vote to release this new alpha. > > 67 issues solved: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12316922&version=12353052 > > Staging repository: > https://repository.apache.org/content/repos

Re: [RESULT] [VOTE] Release Apache Maven 3.9.3

A slight correction re votes (and my mistake: Henning is not PMC): +1b: Romain, Karl Heinz, Slawek and Guillaume +1nb: Delany, Henning On Mon, Jun 26, 2023 at 12:53 PM Tamás Cservenák wrote: > Howdy, > > The vote has passed with the following result: > > +1b: Romain, Henning, Karl Heinz > +2nb:

[ANN] Apache Maven 3.9.3 released

The Apache Maven team is pleased to announce the release of the Apache Maven 3.9.3 Apache Maven is a software project management and comprehension tool. Based on the concept of a project object model (POM), Maven can manage a project's build, reporting and documentation from a central piece of inf

Re: [RESULT] [VOTE] Release Apache Maven 3.9.3

Hi, On 26.06.23 12:53, Tamás Cservenák wrote: Howdy, The vote has passed with the following result: +1b: Romain, Henning, Karl Heinz Missing: * Slawomir Jaranowski * Tamás Cservanák Also please CC post on private pmc list. Kind regards Karl Heinz +2nb: Delany PMC quorum: reached I wil

Re: [RESULT] [VOTE] Release Apache Maven 3.9.3

Hi, On 26.06.23 15:48, Karl Heinz Marbaise wrote: Hi, On 26.06.23 12:53, Tamás Cservenák wrote: Howdy, The vote has passed with the following result: +1b: Romain, Henning, Karl Heinz Missing:  * Slawomir Jaranowski  * Tamás Cservanák and also missed: * Guillaume Nodet Kind regards Kar

Weird behavior in plugin phase resolution

Hi all, With JB Onofré we discussed a surprising behavior of maven plugin execution chain. Long story short it is this piece of code: https://github.com/apache/maven/blob/master/maven-core/src/main/java/org/apache/maven/lifecycle/internal/DefaultLifecycleMappingDelegate.java#L93 . The overall ide

Re: Weird behavior in plugin phase resolution

Just a few remarks: 1) There might be situations were no cache is there so it can hurt performance to resolve "useless" plugins (e.g. from deploy phase) and probably long dependency chains. 2) one should not optimize for the error case, if I never test my project it is not the task of maven

Re: Weird behavior in plugin phase resolution

Hi Christoph, Added a few questions inline cause I'm not sure I got it all. Romain Manni-Bucau @rmannibucau | Blog | Old Blog | Github | LinkedIn

Re: Weird behavior in plugin phase resolution

The main point is: If my build is "broken" by adding another phase, it is not broken by that fact, it was broken before. > Do you have some example about that, where it is placed it shouldn't > until you use maven-core as a lib and then you have to reimplement the > maven preconditions AFAIK. I

Re: Weird behavior in plugin phase resolution

Well I agree we should be lazy if we can but not at the cost to make look like fixing the issue is about adding a phase (which makes the plugin ignored actually and does not fix the build). So think the snippet I sent should either always resolve the evaluated plugins or warn a plugin was wrongly r

Re: Weird behavior in plugin phase resolution

I'm not sure what snippet you refer to? If you mean the link, I don't see any issue with it, if a phase is specified there is no need to determine the default what might lead to a mojo never executed because I specify a non existing phase or specify one that is not executed at all... Am 27.06.

Re: Weird behavior in plugin phase resolution

Le mar. 27 juin 2023 à 08:27, Christoph Läubrich a écrit : > I'm not sure what snippet you refer to? If you mean the link, I don't > see any issue with it, if a phase is specified there is no need to > determine the default what might lead to a mojo never executed because I > specify a non existi

Re: Weird behavior in plugin phase resolution

Can you please given an example where adding a phases "fixes" the build, this does not fix anything nor would I suspect a user will use such a solution to fix something that is completely hypothetical for me, as I either would fix the error (e.g. wrong group id) or remove the execution at all..