+1
Milos
On Mon, Jan 4, 2010 at 8:47 AM, Jason van Zyl ja...@sonatype.com wrote:
Hi,
I have reviewed the patches for the parallel build support and I think they
are great.
I think we should just give Kristian access to work with Dan and other
developers who want to support this work.
Hello again,
I wrote you in march (see attached email) aber setting up a maven2
mirror in Germany. Unfortunately I never heard back from you.
The official repo is rather slow when accessed from Germany (due to
small many files and latency I guess), maybe we could help out with
our mirror
Hi,
Personnaly, I'm tempted to move as Won't Fix : MRELEASE-449 and MRELEASE-450.
Regarding MRELEASE-83, I don't really understand why -Dusername
doesn't work (it should :-) ).
Scm 1.3, I will try to do this ASAP (if enough spare time this week)
Concerning MRELEASE-261, this need more tests
Hi,
If you have patches for site documentation, please provide it.
I will apply and yes the documentation is deployed with the release.
--
Olivier
2010/1/4 subir.sasiku...@wipro.com:
Hello,
I submitted patches for SCM-261 and SCM-505 for maven-synergy-provider
of the maven-scm plugin.
+1
Arnaud Héritier
Software Factory Manager
eXo platform - http://www.exoplatform.com
---
http://www.aheritier.net
On Mon, Jan 4, 2010 at 9:02 AM, Milos Kleint mkle...@gmail.com wrote:
+1
Milos
On Mon, Jan 4, 2010 at 8:47 AM, Jason van Zyl ja...@sonatype.com wrote:
Hi,
I have
+1
--
Olivier
2010/1/4 Jason van Zyl ja...@sonatype.com:
Hi,
I have reviewed the patches for the parallel build support and I think they
are great.
I think we should just give Kristian access to work with Dan and other
developers who want to support this work.
+1
Thanks,
Jason
SUREFIRE-555 looks good.
I just have some questions w.r.t. the licensing
Some of the integration test java classes do not seem to have the ASL
header... does this matter?
-Stephen
2010/1/4 Stephen Connolly stephen.alan.conno...@gmail.com:
will do
Sent from my [rhymes with tryPod] ;-)
On 3
Not sure if somebody has added it already, but since I forgot to send
this mail, here it is now
Ping!
-Stephen
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail:
On 2010-01-04, at 4:50 AM, Stephen Connolly wrote:
SUREFIRE-555 looks good.
I just have some questions w.r.t. the licensing
Some of the integration test java classes do not seem to have the ASL
header... does this matter?
Kristian will likely have a CLA on file shortly. You can ping
Stephen Connolly wrote:
Not sure if somebody has added it already, but since I forgot to send
this mail, here it is now
Done.
Benjamin
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands,
Please put them in if you don't mind. I seem to remember that at least
one int-test was missing the license even before I added my additional
test. I will add the license plugin to idea :)
Kristian
Den 4. jan. 2010 kl. 10.50 skrev Stephen Connolly
stephen.alan.conno...@gmail.com
:
Dennis Lundberg wrote:
Which of these do we intend to fix and which can be bumped to the next
version?
Personally, I don't see much value in having an issue scheduled for some
release when nobody has actually time/interest to work on it, thereby
blocking a release. Go for as much as you can
Stephen Connolly wrote:
Here is the test plan.
1. We (=benjamin) run all the builds that are currently working with
m3+plugin-enfocer+new surefire plugin -SNAPHOT. If all builds still
pass with the new surefire plugin, then we say all is good
2. If all is good, we (=benjamin or me or
Can I have karma as well?
I didn't have an account before so I signed up, and my old changes are
correctly mapped to my new account.
Brett Porter wrote:
Done for Herve, which reminds me...
I mapped this for everyone that already had an account - but a lot of
committers didn't. If you want
Can I have karma too:
username: stephenc
2010/1/4 Dennis Lundberg denn...@apache.org:
Can I have karma as well?
I didn't have an account before so I signed up, and my old changes are
correctly mapped to my new account.
Brett Porter wrote:
Done for Herve, which reminds me...
I mapped
+1
-Original Message-
From: Olivier Lamy [mailto:ol...@apache.org]
Sent: Monday, January 04, 2010 3:47 AM
To: Maven Developers List
Subject: Re: [VOTE] Commit access for Kristian Rosenvold
+1
--
Olivier
2010/1/4 Jason van Zyl ja...@sonatype.com:
Hi,
I have reviewed the patches for
+1
Ralph
On Jan 3, 2010, at 11:47 PM, Jason van Zyl wrote:
Hi,
I have reviewed the patches for the parallel build support and I think they
are great.
I think we should just give Kristian access to work with Dan and other
developers who want to support this work.
+1
Thanks,
+1
--
jesse mcconnell
jesse.mcconn...@gmail.com
On Mon, Jan 4, 2010 at 08:21, Ralph Goers ralph.go...@dslextreme.com wrote:
+1
Ralph
On Jan 3, 2010, at 11:47 PM, Jason van Zyl wrote:
Hi,
I have reviewed the patches for the parallel build support and I think they
are great.
I think
OK,
maven-surefire-plugin is well known to everyone
it's lesser-known sister is failsafe-maven-plugin
failsafe was written (by me) to solve some of the issues of running
integration tests with the maven lifecycle.
the lifecycle has a number of phases
* some crappy phases
* test
* some more
Stephen Connolly wrote:
OK, so that's a tad long, but what do people think?
+1, sounds good to me.
Benjamin
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail:
Go for it. We use the failsafe plugin for Nexus. It would be great if the code
was coalesced.
+1
On 2010-01-04, at 12:43 PM, Stephen Connolly wrote:
OK,
maven-surefire-plugin is well known to everyone
it's lesser-known sister is failsafe-maven-plugin
failsafe was written (by me) to
+1
--
Olivier
2010/1/4 Stephen Connolly stephen.alan.conno...@gmail.com:
OK,
maven-surefire-plugin is well known to everyone
it's lesser-known sister is failsafe-maven-plugin
failsafe was written (by me) to solve some of the issues of running
integration tests with the maven lifecycle.
Stephen,
On Mon, Jan 4, 2010 at 11:43 AM, Stephen Connolly
stephen.alan.conno...@gmail.com wrote:
1. Move failsafe-maven-plugin to
https://svn.apache.org/repos/asf/maven/surefire/trunk/maven-failsafe-plugin
2. Refactor maven-surefire-plugin taking the code that is common with
failsafe into
Sent from my [rhymes with tryPod] ;-)
On 4 Jan 2010, at 18:37, Paul Benedict pbened...@apache.org wrote:
Stephen,
On Mon, Jan 4, 2010 at 11:43 AM, Stephen Connolly
stephen.alan.conno...@gmail.com wrote:
1. Move failsafe-maven-plugin to
Hi Christian,
Thanks for providing the repo!
Please subscribe to repo-maintain...@maven.apache.org, that's the list
for repository matters.
The mirrors are updated once a day, so you can reduce the frequency of
your sync.
Cheers
On Fri, Jan 1, 2010 at 2:51 AM, Christian Rohmann
Vote open for 72 hours.
Ping.
Benjamin
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
+1
On 2010-01-01, at 9:42 AM, Benjamin Bentmann wrote:
Hi,
We solved 1 issue:
http://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=11714version=15200
There are no issues left in JIRA:
http://jira.codehaus.org/secure/IssueNavigator.jspa?reset=truepid=11714status=1
Staging repo:
On Mon, 2010-01-04 at 17:43 +, Stephen Connolly wrote:
2. Refactor maven-surefire-plugin taking the code that is common with
failsafe into common module
3. Refactor maven-failsafe-plugin to use the common module.
In pseudo code SurefirePlugin would be reduced to
execute() {
I see the common code being aabstract base class that extends
abstractmojo
that way, we have less regression risks
anything else will be more of a regression risk IMHO
but I'll take a look while refactoring. my main concern is that the
surefire test coverage is not as good as I'd like
On Mon, 2010-01-04 at 20:17 +, Stephen Connolly wrote:
I see the common code being aabstract base class that extends
abstractmojo
Probably safest. Your pseudocode showing a delegated method call just
had my mouth watering for a smart way to transfer all the wired
properties and mojo
I'm not familiar enough to with the code bases to judge your proposal.
What I'd like though is a new step, before the ones you listed, and that
is to release Surefire 2.5 with whatever is in trunk *first*.
Stephen Connolly wrote:
OK,
maven-surefire-plugin is well known to everyone
it's
no can do. I need to fix the integration tests... they won't work for
release as written... to rewrite them I need failsafe
Sent from my [rhymes with tryPod] ;-)
On 4 Jan 2010, at 22:13, Dennis Lundberg denn...@apache.org wrote:
I'm not familiar enough to with the code bases to judge your
sorry that may have come off a tad rude.
technically I could rewrite the tests without adding the failsafe
stuff, but that would look hacky and maven should show best practice
not hacky
if you want to release 2.5 before Friday, fine... otherwise I'll do it
my way
Sent from my [rhymes
Just so I understand, when you say the ITs won't work for release, do
you mean
1. They will fail the release process
or
2. The current IT coverage is bad
Stephen Connolly wrote:
sorry that may have come off a tad rude.
technically I could rewrite the tests without adding the failsafe
I hesitated on first expressing this opinion, but now that there's
been some push back, I'll share my initial reaction. I like the plan
Stephen set forth, but it may be more appropriate for a 3.0 release of
surefire. Although the majority (if not all) of the plugin's behavior
is unaffected, the
2010/1/4 Dennis Lundberg denn...@apache.org:
Just so I understand, when you say the ITs won't work for release, do
you mean
1. They will fail the release process
mvn release:prepare will always fail because th tests do not stage the
artifacts into the local repo
or
2. The current IT
By refactoring I mean 5 minutes in IntelliJ... Refactor | Extract
Superclass... and then just some cut and paste with IntelliJ's SVN
integration to move the superclass to a new module
(maven-surefire-plugins-common)
I do not think such a refactor warants jumping to 3.0
2010/1/4 Paul Benedict
2010/1/4 Stephen Connolly stephen.alan.conno...@gmail.com:
2010/1/4 Dennis Lundberg denn...@apache.org:
Just so I understand, when you say the ITs won't work for release, do
you mean
1. They will fail the release process
mvn release:prepare will always fail because th tests do not stage the
+1 to merge failsafe within surefire.
But I wouldn't like to have ITs bound to the default lifecycle. In theory we
always put them in a profile to activate them only on demand.
Arnaud Héritier
Software Factory Manager
eXo platform - http://www.exoplatform.com
---
http://www.aheritier.net
On
On 05/01/2010, at 12:38 AM, Stephen Connolly wrote:
Can I have karma too:
username: stephenc
2010/1/4 Dennis Lundberg denn...@apache.org:
Can I have karma as well?
I didn't have an account before so I signed up, and my old changes are
correctly mapped to my new account.
Both done.
+1
Arnaud Héritier
Software Factory Manager
eXo platform - http://www.exoplatform.com
---
http://www.aheritier.net
On Mon, Jan 4, 2010 at 8:53 PM, Jason van Zyl ja...@sonatype.com wrote:
+1
On 2010-01-01, at 9:42 AM, Benjamin Bentmann wrote:
Hi,
We solved 1 issue:
+1
On 04/01/2010, at 6:47 PM, Jason van Zyl wrote:
Hi,
I have reviewed the patches for the parallel build support and I think they
are great.
I think we should just give Kristian access to work with Dan and other
developers who want to support this work.
+1
Thanks,
Jason
+1
Jason van Zyl wrote:
Hi,
I have reviewed the patches for the parallel build support and I think they are
great.
I think we should just give Kristian access to work with Dan and other
developers who want to support this work.
+1
Thanks,
Jason
You're going to need another external plugin to merge the plugin descriptors if
you do this, since by default it doesn't take plugin parameters from external
dependencies. Otherwise the plan sounds fine and minimises disruption.
Refactoring to remove duplication is fine, but I'd be cautious
+1
On Mon, Jan 4, 2010 at 2:47 AM, Jason van Zyl ja...@sonatype.com wrote:
Hi,
I have reviewed the patches for the parallel build support and I think they
are great.
I think we should just give Kristian access to work with Dan and other
developers who want to support this work.
+1
+1
Jason van Zyl wrote:
Hi,
I have reviewed the patches for the parallel build support and I think they are great.
I think we should just give Kristian access to work with Dan and other
developers who want to support this work.
+1
Thanks,
Jason
+1 sounds good.
S.
On Mon, Jan 4, 2010 at 6:43 PM, Stephen Connolly
stephen.alan.conno...@gmail.com wrote:
OK,
maven-surefire-plugin is well known to everyone
it's lesser-known sister is failsafe-maven-plugin
failsafe was written (by me) to solve some of the issues of running
47 matches
Mail list logo
