Re: How to extend the release phases of the DefaultReleaseManager?

2012-06-28 Thread Bernd.Vogt
Thanks for help Stephen. I implemented a prototype which follows the approach to override the default release manager: plugin groupIdorg.apache.maven.plugins/groupId artifactIdmaven-release-plugin/artifactId version2.3.2/version dependencies

plugin annotations retention policy

2012-06-28 Thread Milos Kleint
Hello, I'm in the process of rewriting the nbm-maven-plugin at mojo to use the new annotations instead of javadoc tags. It appears to be working fine, but I'm wondering why the retention policy is CLASS. Since it's only used to generate the xml file, it could be turned into SOURCE and the

Re: plugin annotations retention policy

2012-06-28 Thread Olivier Lamy
Hi, We use asm to collect annotations from compiled classes (so scope compile ) Makes sense ? 2012/6/28 Milos Kleint mkle...@gmail.com: Hello, I'm in the process of rewriting the nbm-maven-plugin at mojo to use the new annotations instead of javadoc tags. It appears to be working fine, but

Re: plugin annotations retention policy

2012-06-28 Thread Milos Kleint
why not use jdk's own annotation processors (which get compiled by javac are we save ourselves an extra mojo execution)? Milos On Thu, Jun 28, 2012 at 11:50 AM, Olivier Lamy ol...@apache.org wrote: Hi, We use asm to collect annotations from compiled classes (so scope compile ) Makes sense ?

Re: plugin annotations retention policy

2012-06-28 Thread Olivier Lamy
could be better maybe. But means 1.6 required. Do you want to work on a branch with this change ? 2012/6/28 Milos Kleint mkle...@gmail.com: why not use jdk's own annotation processors (which get compiled by javac are we save ourselves an extra mojo execution)? Milos On Thu, Jun 28, 2012 at

Re: plugin annotations retention policy

2012-06-28 Thread Igor Fedorenko
What about inheritance? Other tools that may want to do something with the annotations? -- Regards, Igor On 12-06-28 6:06 AM, Olivier Lamy wrote: could be better maybe. But means 1.6 required. Do you want to work on a branch with this change ? 2012/6/28 Milos Kleint mkle...@gmail.com: why

Re: plugin annotations retention policy

2012-06-28 Thread Stephen Connolly
On 28 June 2012 11:33, Igor Fedorenko i...@ifedorenko.com wrote: What about inheritance? +1000 inheritance is one of the reasons we moved to annotations from javadoc tags (though I agree that plugin.xml merging could solve that somewhat, it's messy and ties us back rather than forward Other

maven-surefire pull request: SUREFIRE-879 maven-surefire-report-plugin fail...

2012-06-28 Thread Git at Apache
Github user anistor closed the pull request at: https://github.com/apache/maven-surefire/pull/5 - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org

Re: plugin annotations retention policy

2012-06-28 Thread Olivier Lamy
Oh yes good point I missed that. I essentially work on the anno mode to be able to inherits annotations from reactors modules and/or dependencies. 2012/6/28 Igor Fedorenko i...@ifedorenko.com: What about inheritance? Other tools that may want to do something with the annotations? --

Re: Tips to build maven-plugin-tools

2012-06-28 Thread Olivier Lamy
Hi, Yes please create an issue. Which os are you using ? Currently jenkins build are ok. I will add one with jdk1.7 2012/6/28 Tony Chemit che...@codelutin.com: Hy, I try to build the project from the root maven project but I faced some compilation problems : in maven-plugin-tools-javadoc

Re: [VOTE] Release maven-shade-plugin 1.7.1

2012-06-28 Thread Olivier Lamy
+1 2012/6/27 Benson Margulies bimargul...@gmail.com: Hi, We solved 1 issues: ** Bug    * [MSHADE-123] - 1.7 Causes failures in other plugins make basedir point to the build dir There are still plenty of issues left in JIRA. Staging repo:

Re: [VOTE] Release maven-shade-plugin 1.7.1

2012-06-28 Thread Daniel Kulp
+1 Dan On Wednesday, June 27, 2012 07:53:44 AM Benson Margulies wrote: Hi, We solved 1 issues: ** Bug * [MSHADE-123] - 1.7 Causes failures in other plugins make basedir point to the build dir There are still plenty of issues left in JIRA. Staging repo:

Re: [VOTE] Release maven-shade-plugin 1.7.1

2012-06-28 Thread Hervé BOUTEMY
+1 Hervé Le mercredi 27 juin 2012 07:53:44 Benson Margulies a écrit : Hi, We solved 1 issues: ** Bug * [MSHADE-123] - 1.7 Causes failures in other plugins make basedir point to the build dir There are still plenty of issues left in JIRA. Staging repo: